You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/12/24 11:15:07 UTC
[GitHub] [cloudstack] weizhouapache opened a new pull request #5810: ipv6: disable IPv6-only shared network with VR
weizhouapache opened a new pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810
### Description
This PR fixes #5640 by disabling IPv6-only Shared network with VR provider.
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810#issuecomment-1002241098
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache closed pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810#issuecomment-1006576462
@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache closed pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810#issuecomment-1006637449
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810#issuecomment-1000824741
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 2014
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810#issuecomment-1001883806
@rohityadavcloud a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810#issuecomment-1006922462
<b>Trillian test result (tid-2806)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35292 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5810-t2806-kvm-centos7.zip
Smoke tests completed. 87 look OK, 5 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_add_primary_storage_disabled_host | `Error` | 0.65 | test_primary_storage.py
test_01_primary_storage_nfs | `Error` | 0.13 | test_primary_storage.py
ContextSuite context=TestStorageTags>:setup | `Error` | 0.24 | test_primary_storage.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 35.01 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 80.28 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 41.11 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 77.19 | test_kubernetes_clusters.py
test_01_secure_vm_migration | `Error` | 162.65 | test_vm_life_cycle.py
test_02_unsecure_vm_migration | `Error` | 272.46 | test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration | `Error` | 148.04 | test_vm_life_cycle.py
test_08_migrate_vm | `Error` | 45.92 | test_vm_life_cycle.py
test_02_list_snapshots_with_removed_data_store | `Error` | 9.49 | test_snapshots.py
test_02_list_snapshots_with_removed_data_store | `Error` | 9.49 | test_snapshots.py
test_hostha_enable_ha_when_host_in_maintenance | `Error` | 302.88 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810#issuecomment-1006453487
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810#issuecomment-1002420615
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810#issuecomment-1008988318
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810#issuecomment-1001883645
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810#issuecomment-1006360577
@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on a change in pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on a change in pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810#discussion_r779735095
##########
File path: server/src/main/java/com/cloud/network/NetworkServiceImpl.java
##########
@@ -1252,8 +1252,8 @@ public Network createGuestNetwork(CreateNetworkCmd cmd) throws InsufficientCapac
}
}
- boolean ipv4 = true, ipv6 = false;
- if (startIP != null) {
+ boolean ipv4 = false, ipv6 = false;
+ if (org.apache.commons.lang3.StringUtils.isNoneBlank(gateway, netmask)) {
Review comment:
@weizhouapache, recently we adopted `org.apache.commons.lang3.StringUtils` as the default string lib. A checkstyle validation was added to prohibit imports of `org.apache.commons.lang.StringUtils` and `com.google.common.base.Strings`, however it does not cover `import static`. The files that used `import static` were modified to remove the `import static` and use the object `StringUtils` from `lang3`, however, this file went unnoticed.
Could you remove those `import static` (`import static org.apache.commons.lang.StringUtils.isBlank;` and `import static org.apache.commons.lang.StringUtils.isNotBlank;`) from the begin of the file, import the `org.apache.commons.lang3.StringUtils` and use it instead?
I observed that `com.cloud.utils.StringUtils` is already imported and would conflict with `org.apache.commons.lang3.StringUtils`. However, `com.cloud.utils.StringUtils` is used only twice and `org.apache.commons.lang3.StringUtils` will be used several times, therefore, I'd recommend to import `org.apache.commons.lang3.StringUtils` and to use the full class name of `com.cloud.utils.StringUtils`.
##########
File path: server/src/main/java/com/cloud/network/NetworkServiceImpl.java
##########
@@ -1338,6 +1334,10 @@ public Network createGuestNetwork(CreateNetworkCmd cmd) throws InsufficientCapac
if(isBlank(zone.getIp6Dns1()) && isBlank(zone.getIp6Dns2())) {
throw new InvalidParameterValueException("Can only create IPv6 network if the zone has IPv6 DNS! Please configure the zone IPv6 DNS1 and/or IPv6 DNS2.");
}
+
+ if (!ipv4 && ntwkOff.getGuestType() == GuestType.Shared && _networkModel.isProviderForNetworkOffering(Provider.VirtualRouter, networkOfferingId)) {
+ throw new InvalidParameterValueException("Currently IPv6-only Shared network with Virtual Router provider is not supported");
Review comment:
```suggestion
throw new InvalidParameterValueException("Currently IPv6-only Shared network with Virtual Router provider is not supported.");
```
##########
File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
##########
@@ -2642,7 +2642,7 @@ private Network createGuestNetwork(final long networkOfferingId, final String na
&& !_networkModel.areServicesSupportedByNetworkOffering(ntwkOff.getId(), Service.SourceNat)));
if (cidr == null && ip6Cidr == null && cidrRequired) {
if (ntwkOff.getGuestType() == GuestType.Shared) {
- throw new InvalidParameterValueException("StartIp/endIp/gateway/netmask are required when create network of" + " type " + Network.GuestType.Shared);
+ throw new InvalidParameterValueException("gateway/netmask are required when create network of" + " type " + Network.GuestType.Shared);
Review comment:
```suggestion
throw new InvalidParameterValueException(String.format("Gateway/netmask are required when creating %s networks.", Network.GuestType.Shared));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810#issuecomment-1006575971
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810#issuecomment-1009016767
@blueorangutan test keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810#issuecomment-1002259273
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810#issuecomment-1000801825
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 2013
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810#issuecomment-1000822416
@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810#issuecomment-1006817597
@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810#issuecomment-1007797471
<b>Trillian test result (tid-2822)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43297 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5810-t2822-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810#issuecomment-1006454070
@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810#issuecomment-1006641522
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810#issuecomment-1007293467
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810#issuecomment-1000828051
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810#issuecomment-1002420554
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810#issuecomment-1002240780
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810#discussion_r779764635
##########
File path: server/src/main/java/com/cloud/network/NetworkServiceImpl.java
##########
@@ -1252,8 +1252,8 @@ public Network createGuestNetwork(CreateNetworkCmd cmd) throws InsufficientCapac
}
}
- boolean ipv4 = true, ipv6 = false;
- if (startIP != null) {
+ boolean ipv4 = false, ipv6 = false;
+ if (org.apache.commons.lang3.StringUtils.isNoneBlank(gateway, netmask)) {
Review comment:
> @weizhouapache, recently we adopted `org.apache.commons.lang3.StringUtils` as the default string lib. A checkstyle validation was added to prohibit imports of `org.apache.commons.lang.StringUtils` and `com.google.common.base.Strings`, however it does not cover `import static`. The files that used `import static` were modified to remove the `import static` and use the object `StringUtils` from `lang3`, however, this file went unnoticed.
>
> Could you remove those `import static` (`import static org.apache.commons.lang.StringUtils.isBlank;` and `import static org.apache.commons.lang.StringUtils.isNotBlank;`) from the begin of the file, import the `org.apache.commons.lang3.StringUtils` and use it instead?
>
> I observed that `com.cloud.utils.StringUtils` is already imported and would conflict with `org.apache.commons.lang3.StringUtils`. However, `com.cloud.utils.StringUtils` is used only twice and `org.apache.commons.lang3.StringUtils` will be used several times, therefore, I'd recommend to import `org.apache.commons.lang3.StringUtils` and to use the full class name of `com.cloud.utils.StringUtils`.
@GutoVeronezi thanks for your comment. it is good #5386 has been merged into main branch.
However 4.16 does not have it. com.cloud.utils.StringUtils is still imported.
https://github.com/apache/cloudstack/blob/4.16/server/src/main/java/com/cloud/network/NetworkServiceImpl.java#L175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810#issuecomment-1007293045
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810#issuecomment-1007293045
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti removed a comment on pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
sureshanaparti removed a comment on pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810#issuecomment-1009016767
@blueorangutan test keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810#issuecomment-1001923925
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_check_mark: debian :heavy_multiplication_x: suse15. SL-JID 2029
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810#issuecomment-1000797711
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810#issuecomment-1000822334
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810#issuecomment-1002704225
<b>Trillian test result (tid-2751)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37871 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5810-t2751-kvm-centos7.zip
Smoke tests completed. 90 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_05_ping_in_cpvm_success | `Failure` | 14.37 | test_diagnostics.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810#issuecomment-1006427737
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810#issuecomment-1008902799
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810#issuecomment-1006896593
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2125
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on a change in pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on a change in pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810#discussion_r779766177
##########
File path: server/src/main/java/com/cloud/network/NetworkServiceImpl.java
##########
@@ -1252,8 +1252,8 @@ public Network createGuestNetwork(CreateNetworkCmd cmd) throws InsufficientCapac
}
}
- boolean ipv4 = true, ipv6 = false;
- if (startIP != null) {
+ boolean ipv4 = false, ipv6 = false;
+ if (org.apache.commons.lang3.StringUtils.isNoneBlank(gateway, netmask)) {
Review comment:
@weizhouapache, you're right. I didn't noticed it was based in 4.16. Ignore this comment. =3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810#issuecomment-1006816789
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810#issuecomment-1000798460
@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810#issuecomment-1006360359
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810#issuecomment-1007293467
@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810#issuecomment-1006642431
@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810#issuecomment-1008902495
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810#issuecomment-1010750993
> Verified the changes. LGTM
Great, thanks for testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti merged pull request #5810: ipv6: disable IPv6-only shared network with VR
Posted by GitBox <gi...@apache.org>.
sureshanaparti merged pull request #5810:
URL: https://github.com/apache/cloudstack/pull/5810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org