You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "shwstppr (via GitHub)" <gi...@apache.org> on 2024/01/02 09:18:53 UTC

[PR] engine-schema: fix finding guestos mapping with parent version [cloudstack]

shwstppr opened a new pull request, #8426:
URL: https://github.com/apache/cloudstack/pull/8426

   ### Description
   
   Fixes #8412
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   - [ ] build/CI
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   
   #### How did you try to break this feature and the system with this change?
   
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] engine-schema: fix finding guestos mapping with parent version [cloudstack]

Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #8426:
URL: https://github.com/apache/cloudstack/pull/8426#issuecomment-1878397839

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] engine-schema: fix finding guestos mapping with parent version [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8426:
URL: https://github.com/apache/cloudstack/pull/8426#issuecomment-1874956418

   @blueorangutan test matrix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] engine-schema: fix finding guestos mapping with parent version [cloudstack]

Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #8426:
URL: https://github.com/apache/cloudstack/pull/8426#issuecomment-1878528757

   @blueorangutan test matrix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] engine-schema: fix finding guestos mapping with parent version [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8426:
URL: https://github.com/apache/cloudstack/pull/8426#issuecomment-1879480465

   <b>[SF] Trillian test result (tid-8734)</b>
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
   Total time taken: 48151 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8426-t8734-vmware-67u3.zip
   Smoke tests completed. 108 look OK, 1 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_upgrade_kubernetes_cluster | `Failure` | 494.21 | test_kubernetes_clusters.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] engine-schema: fix finding guestos mapping with parent version [cloudstack]

Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #8426:
URL: https://github.com/apache/cloudstack/pull/8426#issuecomment-1873818372

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] engine-schema: fix finding guestos mapping with parent version [cloudstack]

Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #8426:
URL: https://github.com/apache/cloudstack/pull/8426#issuecomment-1880644254

   Tested `Rocky Linux 9` VM import with VMware 8.0.0.2 hypervisor.
   
   ```
   (localcloud) 🐱 > list hypervisorcapabilities hypervisor=VMware filter=id,hypervisor,hypervisorversion,
   {
     "count": 19,
     "hypervisorCapabilities": [
       {
         "hypervisor": "VMware",
         "hypervisorversion": "default",
         "id": "8"
       },
       {
         "hypervisor": "VMware",
         "hypervisorversion": "4.0",
         "id": "9"
       },
       {
         "hypervisor": "VMware",
         "hypervisorversion": "4.1",
         "id": "10"
       },
       {
         "hypervisor": "VMware",
         "hypervisorversion": "5.0",
         "id": "11"
       },
       {
         "hypervisor": "VMware",
         "hypervisorversion": "5.1",
         "id": "12"
       },
       {
         "hypervisor": "VMware",
         "hypervisorversion": "5.5",
         "id": "c57558bf-abc1-11ee-8957-1e00da000152"
       },
       {
         "hypervisor": "VMware",
         "hypervisorversion": "6.0",
         "id": "cbaae7e7-abc1-11ee-8957-1e00da000152"
       },
       {
         "hypervisor": "VMware",
         "hypervisorversion": "6.5",
         "id": "cd741f46-abc1-11ee-8957-1e00da000152"
       },
       {
         "hypervisor": "VMware",
         "hypervisorversion": "6.7",
         "id": "cf92dd65-abc1-11ee-8957-1e00da000152"
       },
       {
         "hypervisor": "VMware",
         "hypervisorversion": "6.7.1",
         "id": "cf92e9d9-abc1-11ee-8957-1e00da000152"
       },
       {
         "hypervisor": "VMware",
         "hypervisorversion": "6.7.2",
         "id": "cf92f45c-abc1-11ee-8957-1e00da000152"
       },
       {
         "hypervisor": "VMware",
         "hypervisorversion": "6.7.3",
         "id": "cf92fed5-abc1-11ee-8957-1e00da000152"
       },
       {
         "hypervisor": "VMware",
         "hypervisorversion": "7.0",
         "id": "d14750d0-abc1-11ee-8957-1e00da000152"
       },
       {
         "hypervisor": "VMware",
         "hypervisorversion": "7.0.1.0",
         "id": "d1487eae-abc1-11ee-8957-1e00da000152"
       },
       {
         "hypervisor": "VMware",
         "hypervisorversion": "7.0.2.0",
         "id": "d2c839eb-abc1-11ee-8957-1e00da000152"
       },
       {
         "hypervisor": "VMware",
         "hypervisorversion": "7.0.3.0",
         "id": "d2c96de9-abc1-11ee-8957-1e00da000152"
       },
       {
         "hypervisor": "VMware",
         "hypervisorversion": "8.0",
         "id": "d414b048-abc1-11ee-8957-1e00da000152"
       },
       {
         "hypervisor": "VMware",
         "hypervisorversion": "8.0.0.1",
         "id": "d414bc3b-abc1-11ee-8957-1e00da000152"
       },
       {
         "hypervisor": "VMware",
         "hypervisorversion": "8.0.1",
         "id": "d67c19b1-abc1-11ee-8957-1e00da000152"
       }
     ]
   }
   ```
   
   Import in UI,
   
   
   https://github.com/apache/cloudstack/assets/153340/d34ca524-acbb-42d6-a4a2-972d99afe270
   
   
   In Logs,
   ```
   2024-01-08 09:23:51,845 DEBUG [c.c.a.t.Request] (API-Job-Executor-31:ctx-dfff55c7 job-38 ctx-4a1de5f8) (logid:7f598e47) Seq 1-5056135006653522013: Received:  { Ans: , MgmtId: 167780543, via: 1(10.0.35.115), Ver: v1, Flags: 10, { GetUnmanagedInstancesAnswer } }
   2024-01-08 09:23:51,845 DEBUG [c.c.a.m.AgentManagerImpl] (API-Job-Executor-31:ctx-dfff55c7 job-38 ctx-4a1de5f8) (logid:7f598e47) Details from executing class com.cloud.agent.api.GetUnmanagedInstancesCommand: 
   2024-01-08 09:23:51,854 DEBUG [c.c.s.d.GuestOSHypervisorDaoImpl] (API-Job-Executor-31:ctx-dfff55c7 job-38 ctx-4a1de5f8) (logid:7f598e47) Mapping for guest OS ID: rockylinux_64Guest for hypervisor: VMware with version: 8.0.0.2 can not be found. Trying to find one for the parent version: 8.0
   2024-01-08 09:23:51,862 DEBUG [c.c.u.AccountManagerImpl] (API-Job-Executor-31:ctx-dfff55c7 job-38 ctx-4a1de5f8) (logid:7f598e47) Access granted to Account [{"accountName":"admin","id":2,"uuid":"e06f184a-abc1-11ee-8957-1e00da000152"}] to Service offering {"id":1,"name":"Small Instance","uuid":"5aebc1b7-5e3a-405f-98cf-dec841af8453"}. by AffinityGroupAccessChecker
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] engine-schema: fix finding guestos mapping with parent version [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8426:
URL: https://github.com/apache/cloudstack/pull/8426#issuecomment-1880824898

   > 
   > @weizhouapache we can discuss #8444 separately. In the original issue, @andrijapanicsb objected to retrieving hypervisor capabilities from the parent version. Also, currently, there is no way to update the minor/patch version capabilities without updating them for the parent version. Therefore, it was discussed to add the contentious versions explicitly for now. Maybe we can introduce something like https://github.com/apache/cloudstack/compare/main...shapeblue:cloudstack:add-updhycapapi-param?expand=1 I'm happy to close #8444 (or keep just the logs part) if we have a consensus we don't need that
   > 
   > Regarding VMwareVmImplementer change, can we have it in a separate PR? I don't think even with having that we have issues right now
   
   
   
   @shwstppr 
   agree
   I am good with merging this now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] engine-schema: fix finding guestos mapping with parent version [cloudstack]

Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #8426:
URL: https://github.com/apache/cloudstack/pull/8426#issuecomment-1874839787

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] engine-schema: fix finding guestos mapping with parent version [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8426:
URL: https://github.com/apache/cloudstack/pull/8426#issuecomment-1878305245

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8206


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] engine-schema: fix finding guestos mapping with parent version [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8426:
URL: https://github.com/apache/cloudstack/pull/8426#issuecomment-1878245730

   @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] engine-schema: fix finding guestos mapping with parent version [cloudstack]

Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #8426:
URL: https://github.com/apache/cloudstack/pull/8426#issuecomment-1878192104

   > @shwstppr Should it be re-targeted to 4.18?
   
   will make the change


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] engine-schema: fix finding guestos mapping with parent version [cloudstack]

Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #8426:
URL: https://github.com/apache/cloudstack/pull/8426#issuecomment-1878244587

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] engine-schema: fix finding guestos mapping with parent version [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8426:
URL: https://github.com/apache/cloudstack/pull/8426#issuecomment-1874873472

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8184


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] engine-schema: fix finding guestos mapping with parent version [cloudstack]

Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #8426:
URL: https://github.com/apache/cloudstack/pull/8426#issuecomment-1876426564

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] engine-schema: fix finding guestos mapping with parent version [cloudstack]

Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala commented on code in PR #8426:
URL: https://github.com/apache/cloudstack/pull/8426#discussion_r1439386526


##########
engine/schema/src/main/java/com/cloud/storage/dao/GuestOSHypervisorDaoImpl.java:
##########
@@ -100,6 +103,21 @@ public GuestOSHypervisorVO findByOsIdAndHypervisor(long guestOsId, String hyperv
         return findOneBy(sc);
     }
 
+    @Override
+    public GuestOSHypervisorVO findByOsIdAndHypervisor(long guestOsId, String hypervisorType, String hypervisorVersion) {
+        GuestOSHypervisorVO mapping = findByOsIdAndHypervisorInternal(guestOsId, hypervisorType, hypervisorVersion);
+        if (mapping != null || !Hypervisor.HypervisorType.VMware.toString().equals(hypervisorType)) {
+            return mapping;
+        }
+        String parentVersion = CloudStackVersion.getVMwareParentVersion(hypervisorVersion);
+        if (parentVersion == null) {
+            return null;

Review Comment:
   Can we have a log message here stating that the parent is not found, so returning null.



##########
engine/schema/src/main/java/com/cloud/storage/dao/GuestOSHypervisorDaoImpl.java:
##########
@@ -138,6 +155,21 @@ public GuestOSHypervisorVO findByOsNameAndHypervisor(String guestOsName, String
         return CollectionUtils.isNotEmpty(results) ? results.get(0) : null;
     }
 
+    @Override
+    public GuestOSHypervisorVO findByOsNameAndHypervisor(String guestOsName, String hypervisorType, String hypervisorVersion) {
+        GuestOSHypervisorVO mapping = findByOsNameAndHypervisorInternal(guestOsName, hypervisorType, hypervisorVersion);
+        if (mapping != null || !Hypervisor.HypervisorType.VMware.toString().equals(hypervisorType)) {
+            return mapping;
+        }
+        String parentVersion = CloudStackVersion.getVMwareParentVersion(hypervisorVersion);
+        if (parentVersion == null) {
+            return null;

Review Comment:
   same here please, some log message



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] engine-schema: fix finding guestos mapping with parent version [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8426:
URL: https://github.com/apache/cloudstack/pull/8426#issuecomment-1880677443

   also , it looks the following code snippet is not required if this PR is merged
   
   https://github.com/apache/cloudstack/blob/3f9dd4dc07ff40a4e0216014715e4fe37fc46d28/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/guru/VmwareVmImplementer.java#L415-L418
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] engine-schema: fix finding guestos mapping with parent version [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8426:
URL: https://github.com/apache/cloudstack/pull/8426#issuecomment-1878399485

   @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] engine-schema: fix finding guestos mapping with parent version [cloudstack]

Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #8426:
URL: https://github.com/apache/cloudstack/pull/8426#issuecomment-1880808383

   > > Tested `Rocky Linux 9` VM import with VMware 8.0.0.2 hypervisor.
   > > ```
   > > (localcloud) 🐱 > list hypervisorcapabilities hypervisor=VMware filter=id,hypervisor,hypervisorversion,
   > > {
   > >   "count": 19,
   > >   "hypervisorCapabilities": [
   > >     {
   > >       "hypervisor": "VMware",
   > >       "hypervisorversion": "default",
   > >       "id": "8"
   > >     },
   > >     {
   > >       "hypervisor": "VMware",
   > >       "hypervisorversion": "4.0",
   > >       "id": "9"
   > >     },
   > >     {
   > >       "hypervisor": "VMware",
   > >       "hypervisorversion": "4.1",
   > >       "id": "10"
   > >     },
   > >     {
   > >       "hypervisor": "VMware",
   > >       "hypervisorversion": "5.0",
   > >       "id": "11"
   > >     },
   > >     {
   > >       "hypervisor": "VMware",
   > >       "hypervisorversion": "5.1",
   > >       "id": "12"
   > >     },
   > >     {
   > >       "hypervisor": "VMware",
   > >       "hypervisorversion": "5.5",
   > >       "id": "c57558bf-abc1-11ee-8957-1e00da000152"
   > >     },
   > >     {
   > >       "hypervisor": "VMware",
   > >       "hypervisorversion": "6.0",
   > >       "id": "cbaae7e7-abc1-11ee-8957-1e00da000152"
   > >     },
   > >     {
   > >       "hypervisor": "VMware",
   > >       "hypervisorversion": "6.5",
   > >       "id": "cd741f46-abc1-11ee-8957-1e00da000152"
   > >     },
   > >     {
   > >       "hypervisor": "VMware",
   > >       "hypervisorversion": "6.7",
   > >       "id": "cf92dd65-abc1-11ee-8957-1e00da000152"
   > >     },
   > >     {
   > >       "hypervisor": "VMware",
   > >       "hypervisorversion": "6.7.1",
   > >       "id": "cf92e9d9-abc1-11ee-8957-1e00da000152"
   > >     },
   > >     {
   > >       "hypervisor": "VMware",
   > >       "hypervisorversion": "6.7.2",
   > >       "id": "cf92f45c-abc1-11ee-8957-1e00da000152"
   > >     },
   > >     {
   > >       "hypervisor": "VMware",
   > >       "hypervisorversion": "6.7.3",
   > >       "id": "cf92fed5-abc1-11ee-8957-1e00da000152"
   > >     },
   > >     {
   > >       "hypervisor": "VMware",
   > >       "hypervisorversion": "7.0",
   > >       "id": "d14750d0-abc1-11ee-8957-1e00da000152"
   > >     },
   > >     {
   > >       "hypervisor": "VMware",
   > >       "hypervisorversion": "7.0.1.0",
   > >       "id": "d1487eae-abc1-11ee-8957-1e00da000152"
   > >     },
   > >     {
   > >       "hypervisor": "VMware",
   > >       "hypervisorversion": "7.0.2.0",
   > >       "id": "d2c839eb-abc1-11ee-8957-1e00da000152"
   > >     },
   > >     {
   > >       "hypervisor": "VMware",
   > >       "hypervisorversion": "7.0.3.0",
   > >       "id": "d2c96de9-abc1-11ee-8957-1e00da000152"
   > >     },
   > >     {
   > >       "hypervisor": "VMware",
   > >       "hypervisorversion": "8.0",
   > >       "id": "d414b048-abc1-11ee-8957-1e00da000152"
   > >     },
   > >     {
   > >       "hypervisor": "VMware",
   > >       "hypervisorversion": "8.0.0.1",
   > >       "id": "d414bc3b-abc1-11ee-8957-1e00da000152"
   > >     },
   > >     {
   > >       "hypervisor": "VMware",
   > >       "hypervisorversion": "8.0.1",
   > >       "id": "d67c19b1-abc1-11ee-8957-1e00da000152"
   > >     }
   > >   ]
   > > }
   > > ```
   > > 
   > > 
   > >     
   > >       
   > >     
   > > 
   > >       
   > >     
   > > 
   > >     
   > >   
   > > Import in UI,
   > > import-vmw-8002.mp4
   > > In Logs,
   > > ```
   > > 2024-01-08 09:23:51,845 DEBUG [c.c.a.t.Request] (API-Job-Executor-31:ctx-dfff55c7 job-38 ctx-4a1de5f8) (logid:7f598e47) Seq 1-5056135006653522013: Received:  { Ans: , MgmtId: 167780543, via: 1(10.0.35.115), Ver: v1, Flags: 10, { GetUnmanagedInstancesAnswer } }
   > > 2024-01-08 09:23:51,845 DEBUG [c.c.a.m.AgentManagerImpl] (API-Job-Executor-31:ctx-dfff55c7 job-38 ctx-4a1de5f8) (logid:7f598e47) Details from executing class com.cloud.agent.api.GetUnmanagedInstancesCommand: 
   > > 2024-01-08 09:23:51,854 DEBUG [c.c.s.d.GuestOSHypervisorDaoImpl] (API-Job-Executor-31:ctx-dfff55c7 job-38 ctx-4a1de5f8) (logid:7f598e47) Mapping for guest OS ID: rockylinux_64Guest for hypervisor: VMware with version: 8.0.0.2 can not be found. Trying to find one for the parent version: 8.0
   > > 2024-01-08 09:23:51,862 DEBUG [c.c.u.AccountManagerImpl] (API-Job-Executor-31:ctx-dfff55c7 job-38 ctx-4a1de5f8) (logid:7f598e47) Access granted to Account [{"accountName":"admin","id":2,"uuid":"e06f184a-abc1-11ee-8957-1e00da000152"}] to Service offering {"id":1,"name":"Small Instance","uuid":"5aebc1b7-5e3a-405f-98cf-dec841af8453"}. by AffinityGroupAccessChecker
   > > ```
   > 
   > thanks @shwstppr
   > 
   > it seems it worked, even without the hypervisor capabilities for 8.0.0.2
   > 
   > I checked the latest code of main branch, it does have the following code
   > 
   > https://github.com/apache/cloudstack/blob/3f9dd4dc07ff40a4e0216014715e4fe37fc46d28/engine/schema/src/main/java/com/cloud/hypervisor/dao/HypervisorCapabilitiesDaoImpl.java#L77-L83
   > 
   > Now I am wondering if #8444 is required.
   
   @weizhouapache we can discuss #8444 separately.
   In the original issue, @andrijapanicsb objected to retrieving hypervisor capabilities from the parent version. Also, currently, there is no way to update the minor/patch version capabilities without updating them for the parent version. Therefore, it was discussed to add the contentious versions explicitly for now.
   Maybe we can introduce something like https://github.com/apache/cloudstack/compare/main...shapeblue:cloudstack:add-updhycapapi-param?expand=1
   I'm happy to close #8444 (or keep just the logs part) if we have a consensus we don't need that
   
   Regarding VMwareVmImplementer change, can we have it in a separate PR? I don't think even with having that we have issues right now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] engine-schema: fix finding guestos mapping with parent version [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8426:
URL: https://github.com/apache/cloudstack/pull/8426#issuecomment-1876070687

   <b>[SF] Trillian test result (tid-8709)</b>
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
   Total time taken: 52704 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8426-t8709-vmware-67u3.zip
   Smoke tests completed. 117 look OK, 4 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestAddVmToSubDomain>:setup | `Error` | 13.50 | test_accounts.py
   test_DeleteDomain | `Error` | 13.50 | test_accounts.py
   test_forceDeleteDomain | `Failure` | 13.53 | test_accounts.py
   test_01_user_remove_VM_running | `Error` | 2.30 | test_accounts.py
   test_03_network_operations_on_created_vm_of_otheruser | `Error` | 2.54 | test_network_permissions.py
   test_03_network_operations_on_created_vm_of_otheruser | `Error` | 2.54 | test_network_permissions.py
   test_04_deploy_vm_for_other_user_and_test_vm_operations | `Failure` | 1.44 | test_network_permissions.py
   ContextSuite context=TestNetworkPermissions>:teardown | `Error` | 1.44 | test_network_permissions.py
   test_02_balanced_drs_algorithm | `Error` | 424.30 | test_cluster_drs.py
   test_02_upgrade_kubernetes_cluster | `Failure` | 490.30 | test_kubernetes_clusters.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] engine-schema: fix finding guestos mapping with parent version [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8426:
URL: https://github.com/apache/cloudstack/pull/8426#issuecomment-1874840497

   @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] engine-schema: fix finding guestos mapping with parent version [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8426:
URL: https://github.com/apache/cloudstack/pull/8426#issuecomment-1879372441

   <b>[SF] Trillian test result (tid-8735)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 40698 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8426-t8735-kvm-centos7.zip
   Smoke tests completed. 109 look OK, 0 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] engine-schema: fix finding guestos mapping with parent version [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8426:
URL: https://github.com/apache/cloudstack/pull/8426#issuecomment-1877813089

   <b>[SF] Trillian test result (tid-8721)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 55240 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8426-t8721-kvm-centos7.zip
   Smoke tests completed. 118 look OK, 3 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_08_upgrade_kubernetes_ha_cluster | `Failure` | 919.94 | test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 3616.66 | test_kubernetes_clusters.py
   test_10_vpc_tier_kubernetes_cluster | `Failure` | 56.46 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 117.89 | test_kubernetes_clusters.py
   test_08_migrate_vm | `Error` | 44.96 | test_vm_life_cycle.py
   test_hostha_kvm_host_degraded | `Error` | 700.11 | test_hostha_kvm.py
   test_hostha_kvm_host_fencing | `Error` | 671.32 | test_hostha_kvm.py
   test_hostha_kvm_host_recovering | `Error` | 725.54 | test_hostha_kvm.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] engine-schema: fix finding guestos mapping with parent version [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8426:
URL: https://github.com/apache/cloudstack/pull/8426#issuecomment-1877678316

   <b>[SF] Trillian test result (tid-8720)</b>
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
   Total time taken: 48289 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8426-t8720-vmware-67u3.zip
   Smoke tests completed. 119 look OK, 2 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_list_sec_storage_vm | `Failure` | 0.06 | test_ssvm.py
   test_03_ssvm_internals | `Failure` | 0.06 | test_ssvm.py
   test_05_stop_ssvm | `Failure` | 0.05 | test_ssvm.py
   test_12_destroy_cpvm | `Error` | 7.46 | test_ssvm.py
   test_02_balanced_drs_algorithm | `Error` | 430.00 | test_cluster_drs.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] engine-schema: fix finding guestos mapping with parent version [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8426:
URL: https://github.com/apache/cloudstack/pull/8426#issuecomment-1875999358

   <b>[SF] Trillian test result (tid-8710)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 48372 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8426-t8710-kvm-centos7.zip
   Smoke tests completed. 119 look OK, 2 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_list_cpvm_vm | `Failure` | 0.03 | test_ssvm.py
   test_04_cpvm_internals | `Failure` | 0.04 | test_ssvm.py
   test_02_upgrade_kubernetes_cluster | `Failure` | 451.07 | test_kubernetes_clusters.py
   test_07_deploy_kubernetes_ha_cluster | `Failure` | 3623.08 | test_kubernetes_clusters.py
   test_08_upgrade_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 0.03 | test_kubernetes_clusters.py
   test_10_vpc_tier_kubernetes_cluster | `Failure` | 46.77 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 117.58 | test_kubernetes_clusters.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] engine-schema: fix finding guestos mapping with parent version [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8426:
URL: https://github.com/apache/cloudstack/pull/8426#issuecomment-1876422094

   @shwstppr a [SL] Trillian-Jenkins test job (rocky8 mgmt + vmware-67u3) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] engine-schema: fix finding guestos mapping with parent version [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8426:
URL: https://github.com/apache/cloudstack/pull/8426#issuecomment-1877811637

   @shwstppr 
   Should it be re-targeted to 4.18? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] engine-schema: fix finding guestos mapping with parent version [cloudstack]

Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr merged PR #8426:
URL: https://github.com/apache/cloudstack/pull/8426


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] engine-schema: fix finding guestos mapping with parent version [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8426:
URL: https://github.com/apache/cloudstack/pull/8426#issuecomment-1876430324

   @shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] engine-schema: fix finding guestos mapping with parent version [cloudstack]

Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #8426:
URL: https://github.com/apache/cloudstack/pull/8426#issuecomment-1876418785

   @blueorangutan test rocky8 vmware-67u3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] engine-schema: fix finding guestos mapping with parent version [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8426:
URL: https://github.com/apache/cloudstack/pull/8426#issuecomment-1878523656

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8215


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] engine-schema: fix finding guestos mapping with parent version [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8426:
URL: https://github.com/apache/cloudstack/pull/8426#issuecomment-1874957880

   @DaanHoogland a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] engine-schema: fix finding guestos mapping with parent version [cloudstack]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #8426:
URL: https://github.com/apache/cloudstack/pull/8426#issuecomment-1873782175

   ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8426?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Comparison is base [(`9d4f071`)](https://app.codecov.io/gh/apache/cloudstack/commit/9d4f0715d434c8ee1e064f8681093133241e34e2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 30.80% compared to head [(`b85cdef`)](https://app.codecov.io/gh/apache/cloudstack/pull/8426?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 4.39%.
   
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@             Coverage Diff              @@
   ##               main   #8426       +/-   ##
   ============================================
   - Coverage     30.80%   4.39%   -26.42%     
   ============================================
     Files          5341     361     -4980     
     Lines        374864   28622   -346242     
     Branches      54518    4992    -49526     
   ============================================
   - Hits         115485    1258   -114227     
   + Misses       244114   27225   -216889     
   + Partials      15265     139    -15126     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8426/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [simulator-marvin-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8426/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8426/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.39% <ø> (ø)` | |
   | [unit-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8426/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8426?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] engine-schema: fix finding guestos mapping with parent version [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8426:
URL: https://github.com/apache/cloudstack/pull/8426#issuecomment-1875901501

   <b>[SF] Trillian test result (tid-8708)</b>
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 43119 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8426-t8708-xenserver-71.zip
   Smoke tests completed. 121 look OK, 0 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] engine-schema: fix finding guestos mapping with parent version [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8426:
URL: https://github.com/apache/cloudstack/pull/8426#issuecomment-1873912848

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8176


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] engine-schema: fix finding guestos mapping with parent version [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8426:
URL: https://github.com/apache/cloudstack/pull/8426#issuecomment-1873823805

   @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] engine-schema: fix finding guestos mapping with parent version [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8426:
URL: https://github.com/apache/cloudstack/pull/8426#issuecomment-1879376392

   <b>[SF] Trillian test result (tid-8733)</b>
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 41237 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8426-t8733-xenserver-71.zip
   Smoke tests completed. 109 look OK, 0 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] engine-schema: fix finding guestos mapping with parent version [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8426:
URL: https://github.com/apache/cloudstack/pull/8426#issuecomment-1878530263

   @shwstppr a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] engine-schema: fix finding guestos mapping with parent version [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8426:
URL: https://github.com/apache/cloudstack/pull/8426#issuecomment-1880668425

   > Tested `Rocky Linux 9` VM import with VMware 8.0.0.2 hypervisor.
   > 
   > ```
   > (localcloud) 🐱 > list hypervisorcapabilities hypervisor=VMware filter=id,hypervisor,hypervisorversion,
   > {
   >   "count": 19,
   >   "hypervisorCapabilities": [
   >     {
   >       "hypervisor": "VMware",
   >       "hypervisorversion": "default",
   >       "id": "8"
   >     },
   >     {
   >       "hypervisor": "VMware",
   >       "hypervisorversion": "4.0",
   >       "id": "9"
   >     },
   >     {
   >       "hypervisor": "VMware",
   >       "hypervisorversion": "4.1",
   >       "id": "10"
   >     },
   >     {
   >       "hypervisor": "VMware",
   >       "hypervisorversion": "5.0",
   >       "id": "11"
   >     },
   >     {
   >       "hypervisor": "VMware",
   >       "hypervisorversion": "5.1",
   >       "id": "12"
   >     },
   >     {
   >       "hypervisor": "VMware",
   >       "hypervisorversion": "5.5",
   >       "id": "c57558bf-abc1-11ee-8957-1e00da000152"
   >     },
   >     {
   >       "hypervisor": "VMware",
   >       "hypervisorversion": "6.0",
   >       "id": "cbaae7e7-abc1-11ee-8957-1e00da000152"
   >     },
   >     {
   >       "hypervisor": "VMware",
   >       "hypervisorversion": "6.5",
   >       "id": "cd741f46-abc1-11ee-8957-1e00da000152"
   >     },
   >     {
   >       "hypervisor": "VMware",
   >       "hypervisorversion": "6.7",
   >       "id": "cf92dd65-abc1-11ee-8957-1e00da000152"
   >     },
   >     {
   >       "hypervisor": "VMware",
   >       "hypervisorversion": "6.7.1",
   >       "id": "cf92e9d9-abc1-11ee-8957-1e00da000152"
   >     },
   >     {
   >       "hypervisor": "VMware",
   >       "hypervisorversion": "6.7.2",
   >       "id": "cf92f45c-abc1-11ee-8957-1e00da000152"
   >     },
   >     {
   >       "hypervisor": "VMware",
   >       "hypervisorversion": "6.7.3",
   >       "id": "cf92fed5-abc1-11ee-8957-1e00da000152"
   >     },
   >     {
   >       "hypervisor": "VMware",
   >       "hypervisorversion": "7.0",
   >       "id": "d14750d0-abc1-11ee-8957-1e00da000152"
   >     },
   >     {
   >       "hypervisor": "VMware",
   >       "hypervisorversion": "7.0.1.0",
   >       "id": "d1487eae-abc1-11ee-8957-1e00da000152"
   >     },
   >     {
   >       "hypervisor": "VMware",
   >       "hypervisorversion": "7.0.2.0",
   >       "id": "d2c839eb-abc1-11ee-8957-1e00da000152"
   >     },
   >     {
   >       "hypervisor": "VMware",
   >       "hypervisorversion": "7.0.3.0",
   >       "id": "d2c96de9-abc1-11ee-8957-1e00da000152"
   >     },
   >     {
   >       "hypervisor": "VMware",
   >       "hypervisorversion": "8.0",
   >       "id": "d414b048-abc1-11ee-8957-1e00da000152"
   >     },
   >     {
   >       "hypervisor": "VMware",
   >       "hypervisorversion": "8.0.0.1",
   >       "id": "d414bc3b-abc1-11ee-8957-1e00da000152"
   >     },
   >     {
   >       "hypervisor": "VMware",
   >       "hypervisorversion": "8.0.1",
   >       "id": "d67c19b1-abc1-11ee-8957-1e00da000152"
   >     }
   >   ]
   > }
   > ```
   > 
   > Import in UI,
   > 
   >  import-vmw-8002.mp4 
   > In Logs,
   > 
   > ```
   > 2024-01-08 09:23:51,845 DEBUG [c.c.a.t.Request] (API-Job-Executor-31:ctx-dfff55c7 job-38 ctx-4a1de5f8) (logid:7f598e47) Seq 1-5056135006653522013: Received:  { Ans: , MgmtId: 167780543, via: 1(10.0.35.115), Ver: v1, Flags: 10, { GetUnmanagedInstancesAnswer } }
   > 2024-01-08 09:23:51,845 DEBUG [c.c.a.m.AgentManagerImpl] (API-Job-Executor-31:ctx-dfff55c7 job-38 ctx-4a1de5f8) (logid:7f598e47) Details from executing class com.cloud.agent.api.GetUnmanagedInstancesCommand: 
   > 2024-01-08 09:23:51,854 DEBUG [c.c.s.d.GuestOSHypervisorDaoImpl] (API-Job-Executor-31:ctx-dfff55c7 job-38 ctx-4a1de5f8) (logid:7f598e47) Mapping for guest OS ID: rockylinux_64Guest for hypervisor: VMware with version: 8.0.0.2 can not be found. Trying to find one for the parent version: 8.0
   > 2024-01-08 09:23:51,862 DEBUG [c.c.u.AccountManagerImpl] (API-Job-Executor-31:ctx-dfff55c7 job-38 ctx-4a1de5f8) (logid:7f598e47) Access granted to Account [{"accountName":"admin","id":2,"uuid":"e06f184a-abc1-11ee-8957-1e00da000152"}] to Service offering {"id":1,"name":"Small Instance","uuid":"5aebc1b7-5e3a-405f-98cf-dec841af8453"}. by AffinityGroupAccessChecker
   > ```
   
   thanks @shwstppr 
   
   have you added the hypervisor capabilities for 8.0.0.2 ?
   If yes, can  you remove it and retry ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org