You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@joshua.apache.org by "Tommaso Teofili (JIRA)" <ji...@apache.org> on 2016/09/26 12:30:20 UTC
[jira] [Commented] (JOSHUA-291) Improve code quality via static
analysis
[ https://issues.apache.org/jira/browse/JOSHUA-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15522917#comment-15522917 ]
Tommaso Teofili commented on JOSHUA-291:
----------------------------------------
I've applied a bunch of improvements to the codebase based on static code analysis, marking as resolved for now.
> Improve code quality via static analysis
> ----------------------------------------
>
> Key: JOSHUA-291
> URL: https://issues.apache.org/jira/browse/JOSHUA-291
> Project: Joshua
> Issue Type: Improvement
> Components: core
> Reporter: Tommaso Teofili
> Assignee: Tommaso Teofili
> Fix For: 6.1
>
>
> We can improve code quality / readability leveraging code analysis from tools like FindBugs and others integrated in IDEs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: [jira] [Commented] (JOSHUA-291) Improve code quality via static
analysis
Posted by Matt Post <po...@cs.jhu.edu>.
Great, thanks for sending the email.
> On Sep 28, 2016, at 5:13 AM, Tommaso Teofili <to...@gmail.com> wrote:
>
> it's fixed now [1].
>
> Regards,
> Tommaso
>
> [1] : https://github.com/apache/incubator-joshua
>
> Il giorno mar 27 set 2016 alle ore 21:15 Tommaso Teofili <
> tommaso.teofili@gmail.com> ha scritto:
>
>> Right, that's weird, it should sync automatically.
>> I've noticed that also other mirrors at apache have the same issue, maybe
>> it's related to a failure on github mirroring from yesterday, as you can
>> see from [1].
>>
>> I'd opt for waiting a few more hours, then I'd ask infra@.
>>
>> Regards,
>> Tommaso
>>
>> [1] : http://status.apache.org/
>>
>>
>> Il giorno mar 27 set 2016 alle ore 20:38 Matt Post <po...@cs.jhu.edu> ha
>> scritto:
>>
>>> Tommaso, this looks great. One problem, though, is that while these are
>>> present on Apache master, they are for some reason not being mirrored to
>>> Github. Anyone have any idea why?
>>>
>>>
>>> https://git-wip-us.apache.org/repos/asf?p=incubator-joshua.git;a=summary
>>>
>>> The last commit to Github is from 12 days ago:
>>>
>>> https://github.com/apache/incubator-joshua/
>>>
>>> This is supposed to be mirrored automatically, I wonder what's up?
>>>
>>> matt
>>>
>>>
>>>
>>>> On Sep 26, 2016, at 8:30 AM, Tommaso Teofili (JIRA) <ji...@apache.org>
>>> wrote:
>>>>
>>>>
>>>> [
>>> https://issues.apache.org/jira/browse/JOSHUA-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15522917#comment-15522917
>>> ]
>>>>
>>>> Tommaso Teofili commented on JOSHUA-291:
>>>> ----------------------------------------
>>>>
>>>> I've applied a bunch of improvements to the codebase based on static
>>> code analysis, marking as resolved for now.
>>>>
>>>>> Improve code quality via static analysis
>>>>> ----------------------------------------
>>>>>
>>>>> Key: JOSHUA-291
>>>>> URL: https://issues.apache.org/jira/browse/JOSHUA-291
>>>>> Project: Joshua
>>>>> Issue Type: Improvement
>>>>> Components: core
>>>>> Reporter: Tommaso Teofili
>>>>> Assignee: Tommaso Teofili
>>>>> Fix For: 6.1
>>>>>
>>>>>
>>>>> We can improve code quality / readability leveraging code analysis
>>> from tools like FindBugs and others integrated in IDEs.
>>>>
>>>>
>>>>
>>>> --
>>>> This message was sent by Atlassian JIRA
>>>> (v6.3.4#6332)
>>>
>>>
Re: [jira] [Commented] (JOSHUA-291) Improve code quality via static analysis
Posted by Tommaso Teofili <to...@gmail.com>.
it's fixed now [1].
Regards,
Tommaso
[1] : https://github.com/apache/incubator-joshua
Il giorno mar 27 set 2016 alle ore 21:15 Tommaso Teofili <
tommaso.teofili@gmail.com> ha scritto:
> Right, that's weird, it should sync automatically.
> I've noticed that also other mirrors at apache have the same issue, maybe
> it's related to a failure on github mirroring from yesterday, as you can
> see from [1].
>
> I'd opt for waiting a few more hours, then I'd ask infra@.
>
> Regards,
> Tommaso
>
> [1] : http://status.apache.org/
>
>
> Il giorno mar 27 set 2016 alle ore 20:38 Matt Post <po...@cs.jhu.edu> ha
> scritto:
>
>> Tommaso, this looks great. One problem, though, is that while these are
>> present on Apache master, they are for some reason not being mirrored to
>> Github. Anyone have any idea why?
>>
>>
>> https://git-wip-us.apache.org/repos/asf?p=incubator-joshua.git;a=summary
>>
>> The last commit to Github is from 12 days ago:
>>
>> https://github.com/apache/incubator-joshua/
>>
>> This is supposed to be mirrored automatically, I wonder what's up?
>>
>> matt
>>
>>
>>
>> > On Sep 26, 2016, at 8:30 AM, Tommaso Teofili (JIRA) <ji...@apache.org>
>> wrote:
>> >
>> >
>> > [
>> https://issues.apache.org/jira/browse/JOSHUA-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15522917#comment-15522917
>> ]
>> >
>> > Tommaso Teofili commented on JOSHUA-291:
>> > ----------------------------------------
>> >
>> > I've applied a bunch of improvements to the codebase based on static
>> code analysis, marking as resolved for now.
>> >
>> >> Improve code quality via static analysis
>> >> ----------------------------------------
>> >>
>> >> Key: JOSHUA-291
>> >> URL: https://issues.apache.org/jira/browse/JOSHUA-291
>> >> Project: Joshua
>> >> Issue Type: Improvement
>> >> Components: core
>> >> Reporter: Tommaso Teofili
>> >> Assignee: Tommaso Teofili
>> >> Fix For: 6.1
>> >>
>> >>
>> >> We can improve code quality / readability leveraging code analysis
>> from tools like FindBugs and others integrated in IDEs.
>> >
>> >
>> >
>> > --
>> > This message was sent by Atlassian JIRA
>> > (v6.3.4#6332)
>>
>>
Re: [jira] [Commented] (JOSHUA-291) Improve code quality via static analysis
Posted by Tommaso Teofili <to...@gmail.com>.
Right, that's weird, it should sync automatically.
I've noticed that also other mirrors at apache have the same issue, maybe
it's related to a failure on github mirroring from yesterday, as you can
see from [1].
I'd opt for waiting a few more hours, then I'd ask infra@.
Regards,
Tommaso
[1] : http://status.apache.org/
Il giorno mar 27 set 2016 alle ore 20:38 Matt Post <po...@cs.jhu.edu> ha
scritto:
> Tommaso, this looks great. One problem, though, is that while these are
> present on Apache master, they are for some reason not being mirrored to
> Github. Anyone have any idea why?
>
>
> https://git-wip-us.apache.org/repos/asf?p=incubator-joshua.git;a=summary
>
> The last commit to Github is from 12 days ago:
>
> https://github.com/apache/incubator-joshua/
>
> This is supposed to be mirrored automatically, I wonder what's up?
>
> matt
>
>
>
> > On Sep 26, 2016, at 8:30 AM, Tommaso Teofili (JIRA) <ji...@apache.org>
> wrote:
> >
> >
> > [
> https://issues.apache.org/jira/browse/JOSHUA-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15522917#comment-15522917
> ]
> >
> > Tommaso Teofili commented on JOSHUA-291:
> > ----------------------------------------
> >
> > I've applied a bunch of improvements to the codebase based on static
> code analysis, marking as resolved for now.
> >
> >> Improve code quality via static analysis
> >> ----------------------------------------
> >>
> >> Key: JOSHUA-291
> >> URL: https://issues.apache.org/jira/browse/JOSHUA-291
> >> Project: Joshua
> >> Issue Type: Improvement
> >> Components: core
> >> Reporter: Tommaso Teofili
> >> Assignee: Tommaso Teofili
> >> Fix For: 6.1
> >>
> >>
> >> We can improve code quality / readability leveraging code analysis from
> tools like FindBugs and others integrated in IDEs.
> >
> >
> >
> > --
> > This message was sent by Atlassian JIRA
> > (v6.3.4#6332)
>
>
Re: [jira] [Commented] (JOSHUA-291) Improve code quality via static
analysis
Posted by Matt Post <po...@cs.jhu.edu>.
Tommaso, this looks great. One problem, though, is that while these are present on Apache master, they are for some reason not being mirrored to Github. Anyone have any idea why?
https://git-wip-us.apache.org/repos/asf?p=incubator-joshua.git;a=summary
The last commit to Github is from 12 days ago:
https://github.com/apache/incubator-joshua/
This is supposed to be mirrored automatically, I wonder what's up?
matt
> On Sep 26, 2016, at 8:30 AM, Tommaso Teofili (JIRA) <ji...@apache.org> wrote:
>
>
> [ https://issues.apache.org/jira/browse/JOSHUA-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15522917#comment-15522917 ]
>
> Tommaso Teofili commented on JOSHUA-291:
> ----------------------------------------
>
> I've applied a bunch of improvements to the codebase based on static code analysis, marking as resolved for now.
>
>> Improve code quality via static analysis
>> ----------------------------------------
>>
>> Key: JOSHUA-291
>> URL: https://issues.apache.org/jira/browse/JOSHUA-291
>> Project: Joshua
>> Issue Type: Improvement
>> Components: core
>> Reporter: Tommaso Teofili
>> Assignee: Tommaso Teofili
>> Fix For: 6.1
>>
>>
>> We can improve code quality / readability leveraging code analysis from tools like FindBugs and others integrated in IDEs.
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)