You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Mathias Herberts <Ma...@gicm.fr> on 2004/10/15 10:28:56 UTC

[PATCH] adds RequestHeader directive and variable expansion to mod_headers in Apache 1.3

Hi,

I've come up with the included patch to add a RequestHeader directive to 
mod_headers in the 1.3 tree.

My patch adds a callback in the 'header parser' phase which takes care 
of the request headers.

My patch also modifies mod_rewrite.c so in case we have EAPI installed 
lookup_variable is registered as a hook 
(ap::mod_headers::lookup_variable) so its variable expansion function 
can be called from mod_headers.

In case EAPI is present, occurences of %{....} in the header text (for 
both request and response headers) will be replaced with the content of 
the named variable.

As I do not have much experience of the Apache source tree I might have 
written code that is incompatible or not conforming to the general 
Apache guidelines. Please feel free to send me any feedback.

Regards,

Mathias.

Re: [PATCH] adds RequestHeader directive and variable expansion to mod_headers in Apache 1.3

Posted by André Malo <nd...@perlig.de>.
* Mathias Herberts <Ma...@gicm.fr> wrote:

> I've come up with the included patch to add a RequestHeader directive to 
> mod_headers in the 1.3 tree.

We're going more and more to not adding new features to 1.3, so it's
unlikely that the patch will go into that branch.
It's considered *stable*, so we should keep it so.

Backporting more and more stuff (except Bugfixes) from 2.x doesn't keep it
stable. Last famous example: 2.0.51, which was broken (more or less by me).

> My patch also modifies mod_rewrite.c so in case we have EAPI installed 

We don't maintain the EAPI.

nd