[PR] [MNG-6568] Fix comparison cycles in version qualifiers [maven]

["goutamadwant (via GitHub)" <gi...@apache.org>]

goutamadwant opened a new pull request, #13102:
URL: https://github.com/apache/maven/pull/13102

   Fixes #8678.
   
   Correct the reported `0-alpha > x > 0 > 0-alpha` cycle by normalizing zero-prefix nesting and comparing qualifier lists with scalar qualifiers by their contents instead of a fixed item-type rank. The resulting order is `0-alpha < 0 < x`.
   
   Keep release-zero comparisons and artifact-version ordering hashes consistent. Preserve numeric-component precedence and cover mixed qualifier layouts that expose additional cycles. Ordering changes for these qualifier layouts are intentional; this does not replace Maven ordering with SemVer.
   
   Validation with JDK 21: regression tests fail against the unmodified implementation and pass with this change. Tests cover transitivity, equality substitution, aliases, numeric boundaries, artifact equality/hash consistency, and version ranges. `mvn -B -ntp verify` and the full `mvn -B -ntp -Prun-its -Dits.forkCount=2 verify` passed. An independent 1,730-version corpus also passed exhaustive transitivity and ordering-hash checks.
   
   <!--
   Please open pull requests against one of the following branches:
   
   - master — default target for all changes (new features + bug fixes).  
     If the change should also go to maven-4.0.x, request a backport in the PR.
   
   - maven-3.10.x — target for 3.x changes (new features + bug fixes).  
     If the change should also go to maven-3.9.x, request a backport in the PR.
     maven-3.9.x should receive only serious bug fixes, as it is approaching EOL.
   
   Backports are typically handled by maintainers; 
   however, after agreement you may open a separate backport PR to the target maintenance branch.
   -->
   
   Following this checklist to help us incorporate your
   contribution quickly and easily:
   
   - [x] Your pull request should address just one issue, without pulling in other changes.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [x] Each commit in the pull request should have a meaningful subject line and body.
     Note that commits might be squashed by a maintainer on merge.
   - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
     This may not always be possible but is a best-practice.
   - [x] Run `mvn verify` to make sure basic checks pass.
     A more thorough check will be performed on your pull request automatically.
   - [x] You have run the [Core IT][core-its] successfully.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
   - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   [core-its]: https://maven.apache.org/core-its/core-it-suite/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [MNG-6568] Fix comparison cycles in version qualifiers [maven]

["gnodet (via GitHub)" <gi...@apache.org>]

gnodet merged PR #13102:
URL: https://github.com/apache/maven/pull/13102


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org