You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/05/22 05:43:05 UTC
[GitHub] jiazhai commented on a change in pull request #1422: [table
service] start table service as an extra component of bookie
jiazhai commented on a change in pull request #1422: [table service] start table service as an extra component of bookie
URL: https://github.com/apache/bookkeeper/pull/1422#discussion_r189782083
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/server/Main.java
##########
@@ -327,13 +328,18 @@ static LifecycleComponentStack buildBookieServer(BookieConfiguration conf) throw
// 5. build extra services
String[] extraComponents = conf.getServerConf().getExtraServerComponents();
if (null != extraComponents) {
- List<ServerLifecycleComponent> components = loadServerComponents(
- extraComponents,
- conf,
- rootStatsLogger);
- for (ServerLifecycleComponent component : components) {
- serverBuilder.addComponent(component);
- log.info("Load lifecycle component : {}", component.getClass().getName());
+ try {
+ List<ServerLifecycleComponent> components = loadServerComponents(
+ extraComponents,
+ conf,
+ rootStatsLogger);
+ for (ServerLifecycleComponent component : components) {
+ serverBuilder.addComponent(component);
+ log.info("Load lifecycle component : {}", component.getClass().getName());
+ }
+ } catch (Exception e) {
+ log.info("Failed to load extra components '{}' - {}. Continuing without those components.",
+ StringUtils.join(extraComponents), e.getMessage());
Review comment:
Seems this is for handling issue of other components, which is not bookie. It is make sure the bookie still get running while other components meet exception.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services