Broken Builds because of gradle-enterprise

[Olivier Lamy <ol...@apache.org>]

Hi
Are we seriously activating this gradle enterprise to every build and
so breaks a few builds without any notice?

https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-parent/job/master/73/execution/node/56/log/
9:38

[WARNING] Files with unapproved licenses:
   .mvn/.gradle-enterprise/gradle-enterprise-workspace-id

this is a file which doesn;t a correct license and so break the build

same for

[INFO] Publishing build scan...
[INFO] https://ge.apache.org/s/mabitou3lbw2y

we (Apache Maven) don’t want to use this especially as this breaks our builds
and nobody has been informed about this

Is it possible to remove this for projects who don't want to use it??
Thanks

Re: Broken Builds because of gradle-enterprise

[Greg Stein <gs...@gmail.com>]

On Fri, Dec 9, 2022 at 9:54 AM Allen Wittenauer <aw...@apache.org> wrote:

> > On Dec 9, 2022, at 7:43 AM, Greg Stein <gs...@gmail.com> wrote:
> >
> > We make changes to the Jenkins environment all the time, to keep it
> > operational, on the latest software, to provide enough CPU and disk space
> > for builds, add requested plugins, and more. We do not advise projects
> > before we make changes because we expect no problems to arise. This fell
> > into that same kind of "routine change", or so we thought.
>
>
> From
> https://plugins.jenkins.io/gradle/#plugin-content-gradle-enterprise-integration
> :
>
>         Note - The configuration applies to all builds on all connected
> agents matching the specified label criteria, or all in case no label
> criteria are defined.
>
> So need custom labels and have builds move to those labels if they want to
> use the feature.


Thanks, Allen!

Yeah, that will be helpful when we enable builds to be selective
(opt-in/out).

Still working through it for now ... We do have Gradle Inc. on a shared
slack channel to help out.

Cheers,
-g

Re: Broken Builds because of gradle-enterprise

[Allen Wittenauer <aw...@apache.org>]

> On Dec 9, 2022, at 7:43 AM, Greg Stein <gs...@gmail.com> wrote:
> 
> We make changes to the Jenkins environment all the time, to keep it
> operational, on the latest software, to provide enough CPU and disk space
> for builds, add requested plugins, and more. We do not advise projects
> before we make changes because we expect no problems to arise. This fell
> into that same kind of "routine change", or so we thought.


From https://plugins.jenkins.io/gradle/#plugin-content-gradle-enterprise-integration:

	Note - The configuration applies to all builds on all connected agents matching the specified label criteria, or all in case no label criteria are defined.

So need custom labels and have builds move to those labels if they want to use the feature.

Re: Broken Builds because of gradle-enterprise

[Greg Stein <gs...@gmail.com>]

On Fri, Dec 9, 2022 at 9:05 AM Slawomir Jaranowski <s....@gmail.com>
wrote:
>...

> There is no discussion on dev@maven, private@maven ... for a simple reason
> - nobody from the Maven team knows that you want to introduce such
> features.
>

Olivier said the Maven PMC didn't want this. He can't take their name like
that.

Please start a topic about it on Maven list with a description of what you
> want to introduce, why, what will be to do before change.
>
> Some of us were surprised due to the failed build.
>

We were just as surprised. It should have made no difference. Clearly: it
did.

We make changes to the Jenkins environment all the time, to keep it
operational, on the latest software, to provide enough CPU and disk space
for builds, add requested plugins, and more. We do not advise projects
before we make changes because we expect no problems to arise. This fell
into that same kind of "routine change", or so we thought. We backed it
out, and will see if a fix is possible without any need for changes in
projects' build processes.

Our goal is "no change in build processes", and/or "small changes for more
build features (eg. analysis)".

We'll reach out when we know more.

Cheers,
Greg
InfraAdmin, ASF

Re: Broken Builds because of gradle-enterprise

[Slawomir Jaranowski <s....@gmail.com>]

pt., 9 gru 2022 o 15:48 Greg Stein <gs...@gmail.com> napisał(a):

> On Fri, Dec 9, 2022 at 5:41 AM Olivier Lamy <ol...@apache.org> wrote:
>
> > Hi
> > Are we seriously activating this gradle enterprise to every build and
> > so breaks a few builds without any notice?
> >
>
> Apologies. We thought it would simply be an additional output, and would
> not affect any builds. Gaven has turned it off, and we'll do some more
> testing to find out why this happened.
>
> >...
>
> > [INFO] Publishing build scan...
> > [INFO] https://ge.apache.org/s/mabitou3lbw2y
> >
> > we (Apache Maven) don’t want to use this
>
>
> I see no discussion on dev@maven or private@maven to suggest the PMC does
> not want this tool, once we get it debugged.
>
>
There is no discussion on dev@maven, private@maven ... for a simple reason
- nobody from the Maven team knows that you want to introduce such features.

Please start a topic about it on Maven list with a description of what you
want to introduce, why, what will be to do before change.

Some of us were surprised due to the failed build.

Regards,
> Greg Stein
> Infrastructure Administrator, ASF
>


-- 
Sławomir Jaranowski

Re: Broken Builds because of gradle-enterprise

[Greg Stein <gs...@gmail.com>]

On Fri, Dec 9, 2022 at 7:41 PM Olivier Lamy <ol...@apache.org> wrote:

> On Sat, 10 Dec 2022 at 00:48, Greg Stein <gs...@gmail.com> wrote:
> >> On Fri, Dec 9, 2022 at 5:41 AM Olivier Lamy <ol...@apache.org> wrote:
> >>
> >> Hi
> >> Are we seriously activating this gradle enterprise to every build and
> >> so breaks a few builds without any notice?
> >
> > Apologies. We thought it would simply be an additional output, and would
> not affect any builds. Gaven has turned it off, and we'll do some more
> testing to find out why this happened.
>
> No worries. issues can happen but when something is touching builds,
> it's probably better to announce it.
>

Understood, and normally we would. We honestly thought this was a "side
effect" process that would operate while builds were processed. Gradle,Inc
thought the same, too, and are now evaluating options. Again: goal is
"nobody should have to change their build process, and we will get some
build analysis features"


> I don't understand why you guys INFRA do not talk first to the
> opensource communities of Maven and/or Jenkins if you need data on
> what is happening?
>

Again: we did not expect a problem. The expectation was that we'd get some
data about builds, which we did not have before. That we could do some
introspection. ... but primarily: we thought it would be *transparent* ...
That didn't happen.

But really. We do this all the time. We replace build nodes. Do we talk to
the communities? Nah. Cuz upgrading a build node from 50G of disk to 400G
of disk should not be a problem. And it never is. We upgrade our Jenkins
controllers to new versions. Does that cause problems? Nope. We upgrade
build agents from Ubuntu 18.04 to 22.04. No problem. We add latest Maven to
the build nodes. Latest JDK. etc etc etc

I am not going to fault anybody on the Infrastructure Team for not
foreseeing this would break builds. Again: apologies that it did. Mistakes
happen.

>...

Cheers,
Greg
InfraAdmin, ASF

Re: Broken Builds because of gradle-enterprise

[Olivier Lamy <ol...@apache.org>]

On Sat, 10 Dec 2022 at 00:48, Greg Stein <gs...@gmail.com> wrote:
>
> On Fri, Dec 9, 2022 at 5:41 AM Olivier Lamy <ol...@apache.org> wrote:
>>
>> Hi
>> Are we seriously activating this gradle enterprise to every build and
>> so breaks a few builds without any notice?
>
>
> Apologies. We thought it would simply be an additional output, and would not affect any builds. Gaven has turned it off, and we'll do some more testing to find out why this happened.

No worries. issues can happen but when something is touching builds,
it's probably better to announce it.
I don't understand why you guys INFRA do not talk first to the
opensource communities of Maven and/or Jenkins if you need data on
what is happening?
Maybe those opensource communities can help you rather than talking to
a commercial entity.

>
> >...
>>
>> [INFO] Publishing build scan...
>> [INFO] https://ge.apache.org/s/mabitou3lbw2y
>>
>> we (Apache Maven) don’t want to use this
>
>
> I see no discussion on dev@maven or private@maven to suggest the PMC does not want this tool, once we get it debugged.

Ah yes sorry for using this `we` whereas I just discussed it with
folks on slack and didn’t have time to start some discussion on any
@maven as this was breaking all our builds.
so let's say we (some members of Apache Maven).
Sorry for the emotional reaction!
But imagine if infra was pushing some git toolinh behind the back of
subversion guys and it even broke their build because of those git
tooling (I'm sure you can understand such a reaction ;)).





>
> Regards,
> Greg Stein
> Infrastructure Administrator, ASF
>

Re: Broken Builds because of gradle-enterprise

[Greg Stein <gs...@gmail.com>]

On Fri, Dec 9, 2022 at 5:41 AM Olivier Lamy <ol...@apache.org> wrote:

> Hi
> Are we seriously activating this gradle enterprise to every build and
> so breaks a few builds without any notice?
>

Apologies. We thought it would simply be an additional output, and would
not affect any builds. Gaven has turned it off, and we'll do some more
testing to find out why this happened.

>...

> [INFO] Publishing build scan...
> [INFO] https://ge.apache.org/s/mabitou3lbw2y
>
> we (Apache Maven) don’t want to use this


I see no discussion on dev@maven or private@maven to suggest the PMC does
not want this tool, once we get it debugged.

Regards,
Greg Stein
Infrastructure Administrator, ASF

Re: Broken Builds because of gradle-enterprise

[Gary Gregory <ga...@gmail.com>]

You can ask on the ML, I said "my POV".

Gary

On Fri, Dec 9, 2022, 07:29 Gavin McDonald <gm...@apache.org> wrote:

> Hi,
>
> On Fri, Dec 9, 2022 at 12:59 PM Gary Gregory <ga...@gmail.com>
> wrote:
>
> > I never want to use Gradle, so certainly a no for Conmons from my POV.
> >
>
> Does the entire Commons PMC concur?
>
> Gav...
>
>
> >
> > Gary
> >
> > On Fri, Dec 9, 2022, 06:41 Olivier Lamy <ol...@apache.org> wrote:
> >
> > > Hi
> > > Are we seriously activating this gradle enterprise to every build and
> > > so breaks a few builds without any notice?
> > >
> > >
> > >
> >
> https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-parent/job/master/73/execution/node/56/log/
> > > 9:38
> > >
> > > [WARNING] Files with unapproved licenses:
> > >    .mvn/.gradle-enterprise/gradle-enterprise-workspace-id
> > >
> > > this is a file which doesn;t a correct license and so break the build
> > >
> > > same for
> > >
> > > [INFO] Publishing build scan...
> > > [INFO] https://ge.apache.org/s/mabitou3lbw2y
> > >
> > > we (Apache Maven) don’t want to use this especially as this breaks our
> > > builds
> > > and nobody has been informed about this
> > >
> > > Is it possible to remove this for projects who don't want to use it??
> > > Thanks
> > >
> >
>
>
> --
>
> *Gavin McDonald*
> Systems Administrator
> ASF Infrastructure Team
>

Re: Broken Builds because of gradle-enterprise

[Gavin McDonald <gm...@apache.org>]

Hi,

On Fri, Dec 9, 2022 at 12:59 PM Gary Gregory <ga...@gmail.com> wrote:

> I never want to use Gradle, so certainly a no for Conmons from my POV.
>

Does the entire Commons PMC concur?

Gav...


>
> Gary
>
> On Fri, Dec 9, 2022, 06:41 Olivier Lamy <ol...@apache.org> wrote:
>
> > Hi
> > Are we seriously activating this gradle enterprise to every build and
> > so breaks a few builds without any notice?
> >
> >
> >
> https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-parent/job/master/73/execution/node/56/log/
> > 9:38
> >
> > [WARNING] Files with unapproved licenses:
> >    .mvn/.gradle-enterprise/gradle-enterprise-workspace-id
> >
> > this is a file which doesn;t a correct license and so break the build
> >
> > same for
> >
> > [INFO] Publishing build scan...
> > [INFO] https://ge.apache.org/s/mabitou3lbw2y
> >
> > we (Apache Maven) don’t want to use this especially as this breaks our
> > builds
> > and nobody has been informed about this
> >
> > Is it possible to remove this for projects who don't want to use it??
> > Thanks
> >
>


-- 

*Gavin McDonald*
Systems Administrator
ASF Infrastructure Team

Re: Broken Builds because of gradle-enterprise

[Gary Gregory <ga...@gmail.com>]

I never want to use Gradle, so certainly a no for Conmons from my POV.

Gary

On Fri, Dec 9, 2022, 06:41 Olivier Lamy <ol...@apache.org> wrote:

> Hi
> Are we seriously activating this gradle enterprise to every build and
> so breaks a few builds without any notice?
>
>
> https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-parent/job/master/73/execution/node/56/log/
> 9:38
>
> [WARNING] Files with unapproved licenses:
>    .mvn/.gradle-enterprise/gradle-enterprise-workspace-id
>
> this is a file which doesn;t a correct license and so break the build
>
> same for
>
> [INFO] Publishing build scan...
> [INFO] https://ge.apache.org/s/mabitou3lbw2y
>
> we (Apache Maven) don’t want to use this especially as this breaks our
> builds
> and nobody has been informed about this
>
> Is it possible to remove this for projects who don't want to use it??
> Thanks
>

Re: Broken Builds because of gradle-enterprise

[Gavin McDonald <gm...@apache.org>]

Hi,

On Fri, Dec 9, 2022 at 12:41 PM Olivier Lamy <ol...@apache.org> wrote:

> Hi
> Are we seriously activating this gradle enterprise to every build and
> so breaks a few builds without any notice?
>
>
> https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-parent/job/master/73/execution/node/56/log/
> 9:38
>
> [WARNING] Files with unapproved licenses:
>    .mvn/.gradle-enterprise/gradle-enterprise-workspace-id
>
> this is a file which doesn;t a correct license and so break the build
>
> same for
>
> [INFO] Publishing build scan...
> [INFO] https://ge.apache.org/s/mabitou3lbw2y
>
> we (Apache Maven) don’t want to use this especially as this breaks our
> builds
> and nobody has been informed about this
>
> Is it possible to remove this for projects who don't want to use it??
> Thanks
>

I have turned if off for ci-maven.a.o




-- 

*Gavin McDonald*
Systems Administrator
ASF Infrastructure Team