You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "abs007 (via GitHub)" <gi...@apache.org> on 2023/03/30 14:08:20 UTC
[GitHub] [apisix] abs007 opened a new pull request, #9209: Fixed doc wording
abs007 opened a new pull request, #9209:
URL: https://github.com/apache/apisix/pull/9209
### Description
Corrected doc grammar by changing: "With the Route has created" to "With the Route being created"
### Checklist
- [ ] I have explained the need for this PR and the problem it solves
- [ ] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] leslie-tsang commented on pull request #9209: docs: Fixed doc wording
Posted by "leslie-tsang (via GitHub)" <gi...@apache.org>.
leslie-tsang commented on PR #9209:
URL: https://github.com/apache/apisix/pull/9209#issuecomment-1493179163
> @leslie-tsang The link for semantic.yml is broken here: https://github.com/apache/apisix/blob/master/CONTRIBUTING.md#how-to-add-a-new-feature-or-change-an-existing-one
>
> You could provide me the correct link and I can include the fix in this pr
Sorry for the late reply, it looks like it might be better to do this in another PR, after all, it belongs to the link is not working, the new link is [semantic.yml](https://github.com/apache/apisix/blob/master/.github/workflows/semantic.yml)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] abs007 commented on pull request #9209: docs: Fixed doc wording
Posted by "abs007 (via GitHub)" <gi...@apache.org>.
abs007 commented on PR #9209:
URL: https://github.com/apache/apisix/pull/9209#issuecomment-1491399527
@leslie-tsang The link for semantic.yml is broken here: https://github.com/apache/apisix/blob/master/CONTRIBUTING.md#how-to-add-a-new-feature-or-change-an-existing-one
You could provide me the correct link and I can include the fix in this pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] abs007 commented on pull request #9209: docs: Fixed doc wording
Posted by "abs007 (via GitHub)" <gi...@apache.org>.
abs007 commented on PR #9209:
URL: https://github.com/apache/apisix/pull/9209#issuecomment-1493221646
@leslie-tsang No worries. I'll create a new draft pr with this fix and other errors that I may find.
> the new link is [semantic.yml](https://github.com/apache/apisix/blob/master/.github/workflows/semantic.yml)
Should the fix for this be pushed against the master/next branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] abs007 commented on pull request #9209: docs: Fixed doc wording
Posted by "abs007 (via GitHub)" <gi...@apache.org>.
abs007 commented on PR #9209:
URL: https://github.com/apache/apisix/pull/9209#issuecomment-1491348440
Sure @leslie-tsang, I can take a look at the docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] navendu-pottekkat merged pull request #9209: docs: Fixed doc wording
Posted by "navendu-pottekkat (via GitHub)" <gi...@apache.org>.
navendu-pottekkat merged PR #9209:
URL: https://github.com/apache/apisix/pull/9209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] leslie-tsang commented on pull request #9209: docs: Fixed doc wording
Posted by "leslie-tsang (via GitHub)" <gi...@apache.org>.
leslie-tsang commented on PR #9209:
URL: https://github.com/apache/apisix/pull/9209#issuecomment-1491314016
Could you help to check if there are similar syntax problems in other files?
Would be too appreciated to do it in one PR with same problems. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org