You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@airflow.apache.org by Daniel Standish <da...@astronomer.io.INVALID> on 2022/09/21 17:03:19 UTC
[LAZY CONSENSUS] enable string normalization on black
Proposal: remove param --skip-string-normalization on black pre-commit hook
Discussion thread:
https://lists.apache.org/thread/0g887n3gyr611k908zsz27ccshb85z2n
After 72 hours, unless there is an objection, this proposal will be adopted.
What is lazy consensus? Read here
<https://community.apache.org/committers/lazyConsensus.html>.
Re: [LAZY CONSENSUS] enable string normalization on black
Posted by Pankaj Koti <pa...@astronomer.io.INVALID>.
+1 non-binding
Regards,
Pankaj Koti
*Senior Software Engineer, *OSS Engineering Team.
Location: Pune, India
Timezone: Indian Standard Time (IST)
Email: pankaj.koti@astronomer.io
Mobile: +91 9730079985
On Thu, Sep 22, 2022 at 2:06 AM Ferruzzi, Dennis
<fe...@amazon.com.invalid> wrote:
> +1 non-binding
>
>
> ------------------------------
> *From:* Felix Uellendall <fe...@pm.me.INVALID>
> *Sent:* Wednesday, September 21, 2022 10:35 AM
> *To:* dev@airflow.apache.org
> *Subject:* RE: [EXTERNAL][LAZY CONSENSUS] enable string normalization on
> black
>
>
> *CAUTION*: This email originated from outside of the organization. Do not
> click links or open attachments unless you can confirm the sender and know
> the content is safe.
>
> +1 (binding)
>
> Best,
> Felix
>
>
>
> Sent from Proton Mail for iOS
>
>
> On Wed, Sep 21, 2022 at 19:10, Ash Berlin-Taylor <as...@apache.org> wrote:
>
> For clarity for those who didn't read the thread:
>
> This change will be applied just before 2.5 is going to be released (to
> avoid making cherry picks difficult)
>
> -a
>
> On 21 September 2022 18:03:19 BST, Daniel Standish
> <da...@astronomer.io.INVALID> wrote:
>>
>> Proposal: remove param --skip-string-normalization on black pre-commit
>> hook
>>
>> Discussion thread:
>> https://lists.apache.org/thread/0g887n3gyr611k908zsz27ccshb85z2n
>>
>> After 72 hours, unless there is an objection, this proposal will be
>> adopted.
>>
>> What is lazy consensus? Read here
>> <https://community.apache.org/committers/lazyConsensus.html>.
>>
>>
>>
Re: [LAZY CONSENSUS] enable string normalization on black
Posted by "Ferruzzi, Dennis" <fe...@amazon.com.INVALID>.
+1 non-binding
________________________________
From: Felix Uellendall <fe...@pm.me.INVALID>
Sent: Wednesday, September 21, 2022 10:35 AM
To: dev@airflow.apache.org
Subject: RE: [EXTERNAL][LAZY CONSENSUS] enable string normalization on black
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
+1 (binding)
Best,
Felix
Sent from Proton Mail for iOS
On Wed, Sep 21, 2022 at 19:10, Ash Berlin-Taylor <as...@apache.org>> wrote:
For clarity for those who didn't read the thread:
This change will be applied just before 2.5 is going to be released (to avoid making cherry picks difficult)
-a
On 21 September 2022 18:03:19 BST, Daniel Standish <da...@astronomer.io.INVALID> wrote:
Proposal: remove param --skip-string-normalization on black pre-commit hook
Discussion thread: https://lists.apache.org/thread/0g887n3gyr611k908zsz27ccshb85z2n
After 72 hours, unless there is an objection, this proposal will be adopted.
What is lazy consensus? Read here<https://community.apache.org/committers/lazyConsensus.html>.
Re: [LAZY CONSENSUS] enable string normalization on black
Posted by Felix Uellendall <fe...@pm.me.INVALID>.
+1 (binding)
Best,
Felix
Sent from Proton Mail for iOS
On Wed, Sep 21, 2022 at 19:10, Ash Berlin-Taylor <as...@apache.org> wrote:
> For clarity for those who didn't read the thread:
>
> This change will be applied just before 2.5 is going to be released (to avoid making cherry picks difficult)
>
> -a
>
> On 21 September 2022 18:03:19 BST, Daniel Standish <da...@astronomer.io.INVALID> wrote:
>
>> Proposal: remove param --skip-string-normalization on black pre-commit hook
>>
>> Discussion thread: https://lists.apache.org/thread/0g887n3gyr611k908zsz27ccshb85z2n
>>
>> After 72 hours, unless there is an objection, this proposal will be adopted.
>>
>> What is lazy consensus? Read [here](https://community.apache.org/committers/lazyConsensus.html).
Re: [LAZY CONSENSUS] enable string normalization on black
Posted by Ash Berlin-Taylor <as...@apache.org>.
For clarity for those who didn't read the thread:
This change will be applied just before 2.5 is going to be released (to avoid making cherry picks difficult)
-a
On 21 September 2022 18:03:19 BST, Daniel Standish <da...@astronomer.io.INVALID> wrote:
>Proposal: remove param --skip-string-normalization on black pre-commit hook
>
>Discussion thread:
>https://lists.apache.org/thread/0g887n3gyr611k908zsz27ccshb85z2n
>
>After 72 hours, unless there is an objection, this proposal will be adopted.
>
>What is lazy consensus? Read here
><https://community.apache.org/committers/lazyConsensus.html>.
Re: [LAZY CONSENSUS] enable string normalization on black
Posted by Josh Fell <jo...@astronomer.io.INVALID>.
+1 (binding)
As a double-quote guy I'm in favor, but having consistency is more
important than my style preferences. Love it.
On Wed, Sep 21, 2022 at 2:50 PM Drew Hubl <dr...@astronomer.io.invalid>
wrote:
> +1 (non-binding)
>
> On Sep 21, 2022, at 10:03 AM, Daniel Standish <
> daniel.standish@astronomer.io.INVALID> wrote:
>
> Proposal: remove param --skip-string-normalization on black pre-commit hook
>
> Discussion thread:
> https://lists.apache.org/thread/0g887n3gyr611k908zsz27ccshb85z2n
>
> After 72 hours, unless there is an objection, this proposal will be
> adopted.
>
> What is lazy consensus? Read here
> <https://community.apache.org/committers/lazyConsensus.html>.
>
>
>
>
Re: [LAZY CONSENSUS] enable string normalization on black
Posted by Drew Hubl <dr...@astronomer.io.INVALID>.
+1 (non-binding)
> On Sep 21, 2022, at 10:03 AM, Daniel Standish <da...@astronomer.io.INVALID> wrote:
>
> Proposal: remove param --skip-string-normalization on black pre-commit hook
>
> Discussion thread: https://lists.apache.org/thread/0g887n3gyr611k908zsz27ccshb85z2n <https://lists.apache.org/thread/0g887n3gyr611k908zsz27ccshb85z2n>
>
> After 72 hours, unless there is an objection, this proposal will be adopted.
>
> What is lazy consensus? Read here <https://community.apache.org/committers/lazyConsensus.html>.
>
>