[GitHub] [flink] klion26 edited a comment on issue #10344: [FLINK-14264][StateBackend][Rest] Expose state backend in checkpoint rest api

[GitBox <gi...@apache.org>]

klion26 edited a comment on issue #10344: [FLINK-14264][StateBackend][Rest] Expose state backend in checkpoint rest api
URL: https://github.com/apache/flink/pull/10344#issuecomment-562401091
 
 
   > Which part would be failing right now?
   
   Currently, not part will fail right now. I said that it will always fail is that `if we do not create CC after disabled checkpoint, then the rest for checkpoint config will always fail`
   
   Before I find that the rest will [throw exception](https://github.com/apache/flink/blob/5973508e6cb00f7e9b04325207bfa6b46f51606a/flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/checkpoints/CheckpointConfigHandler.java#L92) with reason `RestHandlerException(
   			"Checkpointing is not enabled for this job (" + executionGraph.getJobID() + ").", HttpResponseStatus.NOT_FOUND)`,  so I thought the rest will always "fail" if checkpoint has been disabled, but it did not.  even checkpoint has been disabled, we can get a result from rest with the interval of `Long.MAX`, so I set the default value of `stateBackendName` to `disabled`, but seems the default value will never be used :(, if we create CC, then rest will always return the truly `backendName`, if we do not create cc, then rest will fail, and will not  read the `backendName`. So maybe we can still set the default value to `null` for `stateBackendName` here. what do you think? @zentol 
   
   Apart from the default value of `stateBackendName` the PR is ready for review now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services