[GitHub] [kafka] rajinisivaram commented on a change in pull request #8705: KAFKA-10029; Don't update completedReceives when channels are closed to avoid ConcurrentModificationException

[GitBox <gi...@apache.org>]

rajinisivaram commented on a change in pull request #8705:
URL: https://github.com/apache/kafka/pull/8705#discussion_r430299529



##########
File path: core/src/test/scala/unit/kafka/network/SocketServerTest.scala
##########
@@ -1742,6 +1746,12 @@ class SocketServerTest {
            selector = Some(testableSelector)
            testableSelector
         }
+
+        override private[network] def processException(errorMessage: String, throwable: Throwable, isUncaught: Boolean): Unit = {

Review comment:
       Funny you should say that, I was initially checking the error message and then felt that the test wouldn't fail if the error message was changed. But since then I had also updated the test which triggers the uncaught exception code path, so it is actually safe now to check the error message. Have updated the code.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org