[GitHub] [hudi] danny0405 commented on a diff in pull request #8606: [MINOR] Check the return value from delete during rollback and finalize to ensure the files actually got deleted.

["danny0405 (via GitHub)" <gi...@apache.org>]

danny0405 commented on code in PR #8606:
URL: https://github.com/apache/hudi/pull/8606#discussion_r1181157467


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/BaseRollbackHelper.java:
##########
@@ -197,14 +197,21 @@ protected List<HoodieRollbackStat> deleteFiles(HoodieTableMetaClient metaClient,
             // if first rollback attempt failed and retried again, chances that some files are already deleted.
             isDeleted = true;
           }
+
+          if (!isDeleted) {

Review Comment:
   In which case the `metaClient.getFs().delete()` can return false if the file actually exists there?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org