You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by si...@apache.org on 2018/06/04 21:01:31 UTC
[bookkeeper] 10/10: Fix checkstyle warnings
This is an automated email from the ASF dual-hosted git repository.
sijie pushed a commit to branch branch-4.7
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git
commit 3c5d0960fbec42690932a07aa3df62f13d374f9d
Author: Sijie Guo <si...@apache.org>
AuthorDate: Fri May 25 10:49:57 2018 -0700
Fix checkstyle warnings
Descriptions of the changes in this PR:
*Motivation*
There were two concurrent PRs merged at the same time.
apache/bookkeeper#1435 (checkstyle changes) was merged before apache/bookkeeper#1430. so checkstyle warnings
introduced by apache/bookkeeper#1430 were not caught by any CI jobs.
*Solution*
Address the checkstyle warnings introduced by apache/bookkeeper#1430
Author: Sijie Guo <si...@apache.org>
Reviewers: Enrico Olivelli <eo...@gmail.com>
This closes #1444 from sijie/fix_checkstyle_issue
---
.../common/grpc/proxy/ProxyServerCallHandler.java | 2 +-
.../apache/bookkeeper/tests/rpc/package-info.java | 23 ++++++++++++++++++++++
2 files changed, 24 insertions(+), 1 deletion(-)
diff --git a/stream/common/src/main/java/org/apache/bookkeeper/common/grpc/proxy/ProxyServerCallHandler.java b/stream/common/src/main/java/org/apache/bookkeeper/common/grpc/proxy/ProxyServerCallHandler.java
index a691497..2cc6652 100644
--- a/stream/common/src/main/java/org/apache/bookkeeper/common/grpc/proxy/ProxyServerCallHandler.java
+++ b/stream/common/src/main/java/org/apache/bookkeeper/common/grpc/proxy/ProxyServerCallHandler.java
@@ -27,7 +27,7 @@ import io.grpc.ServerCall.Listener;
import io.grpc.ServerCallHandler;
/**
- * Abstract server call handler
+ * Abstract server call handler.
*/
class ProxyServerCallHandler<ReqT, RespT> implements ServerCallHandler<ReqT, RespT> {
diff --git a/stream/tests-common/src/main/java/org/apache/bookkeeper/tests/rpc/package-info.java b/stream/tests-common/src/main/java/org/apache/bookkeeper/tests/rpc/package-info.java
new file mode 100644
index 0000000..96cf1c1
--- /dev/null
+++ b/stream/tests-common/src/main/java/org/apache/bookkeeper/tests/rpc/package-info.java
@@ -0,0 +1,23 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/**
+ * Common rpc classes used for testing.
+ */
+package org.apache.bookkeeper.tests.rpc;
\ No newline at end of file
--
To stop receiving notification emails like this one, please contact
sijie@apache.org.