You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@accumulo.apache.org by Sean Busbey <se...@manvsbeard.com> on 2014/04/24 00:34:31 UTC

Review Request 20636: ACCUMULO-2726 restore binary compatibility 1.5 -> 1.6

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20636/
-----------------------------------------------------------

Review request for accumulo.


Bugs: ACCUMULO-2726
    https://issues.apache.org/jira/browse/ACCUMULO-2726


Repository: accumulo


Description
-------

restores things found missing by japi compliance checker


Diffs
-----

  core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java f80eee5 
  core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsHelper.java b9a7791 
  core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java 569a3b6 
  core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperationsImpl.java 9d662f4 
  core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsHelper.java 843f572 
  core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 3d69cc1 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperations.java 15379af 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockNamespaceOperations.java 9f0594a 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperations.java 16a8e02 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockShell.java 2bc9436 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java d3b1571 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockTabletLocator.java 6bd01a9 
  core/src/main/java/org/apache/accumulo/core/security/Credentials.java 5afc6e8 
  core/src/test/java/org/apache/accumulo/core/security/CredentialsTest.java 4f8079e 

Diff: https://reviews.apache.org/r/20636/diff/


Testing
-------

unit tests pass. waiting on ITs.


Thanks,

Sean Busbey

Re: Review Request 20636: ACCUMULO-2726 restore binary compatibility 1.5 -> 1.6

Posted by Sean Busbey <se...@manvsbeard.com>.


> On April 23, 2014, 11:24 p.m., kturner wrote:
> > core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java, line 62
> > <https://reviews.apache.org/r/20636/diff/1/?file=566298#file566298line62>
> >
> >     this class is completely new in 1.6.0... if this were to make it into RC4, then this class could just start off in an impl package
> 
> Sean Busbey wrote:
>     Couldn't move it out of the package because it needs to access package-private parts of TableOperationsImpl. Couldn't make it package-private because impl/ConnectorImpl needs to access it.
>     
>     So ATM, still marked as deprecated in the version it was introduced. Should I add a javadoc (or non-javadoc comment) that explains this?
> 
> kturner wrote:
>     What about doing the following?
>     
>      1 Move *Impl classes to impl package
>      2 Create *Impl classes that extent impl.*Impl classes and expose whatever is public
>     
>     This way internal code does not need to instantiate deprecated code AND NamespaceOperationsImpl can be deleted.   
>     
>     Christopher did something similar when deprecating the mapreduce util package.
> 
> Christopher Tubbs wrote:
>     I used delegation, not extension, but yeah, similar.
> 
> kturner wrote:
>     there is an advantage to delegation over extension.   Delegation makes its easy to freeze the deprecated API.  W/ extension adding a public method in a impl.*Impl class will add it to the *Impl class that extends it.

I'm already mostly done with the extension version. Does anyone feel strongly about using delegation?


- Sean


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20636/#review41240
-----------------------------------------------------------


On April 24, 2014, 7:34 a.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20636/
> -----------------------------------------------------------
> 
> (Updated April 24, 2014, 7:34 a.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2726
>     https://issues.apache.org/jira/browse/ACCUMULO-2726
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> restores things found missing by japi compliance checker
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java f80eee5 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsHelper.java b9a7791 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java 569a3b6 
>   core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperationsImpl.java 9d662f4 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsHelper.java 843f572 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 3d69cc1 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ConnectorImpl.java 7d9d3ab 
>   core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsHelper.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/impl/InputConfigurator.java cfd9aa2 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockConnector.java 996198c 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperations.java 15379af 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockNamespaceOperations.java 9f0594a 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperations.java 16a8e02 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockShell.java 2bc9436 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java d3b1571 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTabletLocator.java 6bd01a9 
>   core/src/main/java/org/apache/accumulo/core/security/Credentials.java 5afc6e8 
>   core/src/test/java/org/apache/accumulo/core/security/CredentialsTest.java 4f8079e 
>   test/compat/japi-compliance/japi-accumulo-1.5.xml 9e6f47f 
>   test/compat/japi-compliance/japi-accumulo-1.6.xml 36553b8 
> 
> Diff: https://reviews.apache.org/r/20636/diff/
> 
> 
> Testing
> -------
> 
> unit tests pass. ITs passed.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>

Re: Review Request 20636: ACCUMULO-2726 restore binary compatibility 1.5 -> 1.6

Posted by Sean Busbey <se...@manvsbeard.com>.


> On April 23, 2014, 11:24 p.m., kturner wrote:
> > core/src/main/java/org/apache/accumulo/core/client/mock/MockNamespaceOperations.java, line 36
> > <https://reviews.apache.org/r/20636/diff/1/?file=566303#file566303line36>
> >
> >     I assume this class is also completely new in 1.6.0

Couldn't move it out of the package because it needs to access package-private parts of MockAccumulo. So I left it in place and made the class package-private, removing it from the public api.


> On April 23, 2014, 11:24 p.m., kturner wrote:
> > core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java, line 62
> > <https://reviews.apache.org/r/20636/diff/1/?file=566298#file566298line62>
> >
> >     this class is completely new in 1.6.0... if this were to make it into RC4, then this class could just start off in an impl package

Couldn't move it out of the package because it needs to access package-private parts of TableOperationsImpl. Couldn't make it package-private because impl/ConnectorImpl needs to access it.

So ATM, still marked as deprecated in the version it was introduced. Should I add a javadoc (or non-javadoc comment) that explains this?


- Sean


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20636/#review41240
-----------------------------------------------------------


On April 23, 2014, 10:34 p.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20636/
> -----------------------------------------------------------
> 
> (Updated April 23, 2014, 10:34 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2726
>     https://issues.apache.org/jira/browse/ACCUMULO-2726
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> restores things found missing by japi compliance checker
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java f80eee5 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsHelper.java b9a7791 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java 569a3b6 
>   core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperationsImpl.java 9d662f4 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsHelper.java 843f572 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 3d69cc1 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperations.java 15379af 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockNamespaceOperations.java 9f0594a 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperations.java 16a8e02 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockShell.java 2bc9436 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java d3b1571 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTabletLocator.java 6bd01a9 
>   core/src/main/java/org/apache/accumulo/core/security/Credentials.java 5afc6e8 
>   core/src/test/java/org/apache/accumulo/core/security/CredentialsTest.java 4f8079e 
> 
> Diff: https://reviews.apache.org/r/20636/diff/
> 
> 
> Testing
> -------
> 
> unit tests pass. waiting on ITs.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>

Re: Review Request 20636: ACCUMULO-2726 restore binary compatibility 1.5 -> 1.6

Posted by ke...@deenlo.com.


> On April 23, 2014, 11:24 p.m., kturner wrote:
> > core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java, line 62
> > <https://reviews.apache.org/r/20636/diff/1/?file=566298#file566298line62>
> >
> >     this class is completely new in 1.6.0... if this were to make it into RC4, then this class could just start off in an impl package
> 
> Sean Busbey wrote:
>     Couldn't move it out of the package because it needs to access package-private parts of TableOperationsImpl. Couldn't make it package-private because impl/ConnectorImpl needs to access it.
>     
>     So ATM, still marked as deprecated in the version it was introduced. Should I add a javadoc (or non-javadoc comment) that explains this?
> 
> kturner wrote:
>     What about doing the following?
>     
>      1 Move *Impl classes to impl package
>      2 Create *Impl classes that extent impl.*Impl classes and expose whatever is public
>     
>     This way internal code does not need to instantiate deprecated code AND NamespaceOperationsImpl can be deleted.   
>     
>     Christopher did something similar when deprecating the mapreduce util package.
> 
> Christopher Tubbs wrote:
>     I used delegation, not extension, but yeah, similar.

there is an advantage to delegation over extension.   Delegation makes its easy to freeze the deprecated API.  W/ extension adding a public method in a impl.*Impl class will add it to the *Impl class that extends it.


- kturner


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20636/#review41240
-----------------------------------------------------------


On April 24, 2014, 7:34 a.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20636/
> -----------------------------------------------------------
> 
> (Updated April 24, 2014, 7:34 a.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2726
>     https://issues.apache.org/jira/browse/ACCUMULO-2726
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> restores things found missing by japi compliance checker
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java f80eee5 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsHelper.java b9a7791 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java 569a3b6 
>   core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperationsImpl.java 9d662f4 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsHelper.java 843f572 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 3d69cc1 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ConnectorImpl.java 7d9d3ab 
>   core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsHelper.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/impl/InputConfigurator.java cfd9aa2 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockConnector.java 996198c 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperations.java 15379af 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockNamespaceOperations.java 9f0594a 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperations.java 16a8e02 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockShell.java 2bc9436 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java d3b1571 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTabletLocator.java 6bd01a9 
>   core/src/main/java/org/apache/accumulo/core/security/Credentials.java 5afc6e8 
>   core/src/test/java/org/apache/accumulo/core/security/CredentialsTest.java 4f8079e 
>   test/compat/japi-compliance/japi-accumulo-1.5.xml 9e6f47f 
>   test/compat/japi-compliance/japi-accumulo-1.6.xml 36553b8 
> 
> Diff: https://reviews.apache.org/r/20636/diff/
> 
> 
> Testing
> -------
> 
> unit tests pass. ITs passed.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>

Re: Review Request 20636: ACCUMULO-2726 restore binary compatibility 1.5 -> 1.6

Posted by Sean Busbey <se...@manvsbeard.com>.


> On April 23, 2014, 11:24 p.m., kturner wrote:
> > core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java, line 81
> > <https://reviews.apache.org/r/20636/diff/1/?file=566296#file566296line81>
> >
> >     why deprecate this method when the entire class is deperecated?

As a marker to remove it after we move the class out of the public API (in the event that there is another release prior to completely changing the client API)


- Sean


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20636/#review41240
-----------------------------------------------------------


On April 23, 2014, 10:34 p.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20636/
> -----------------------------------------------------------
> 
> (Updated April 23, 2014, 10:34 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2726
>     https://issues.apache.org/jira/browse/ACCUMULO-2726
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> restores things found missing by japi compliance checker
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java f80eee5 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsHelper.java b9a7791 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java 569a3b6 
>   core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperationsImpl.java 9d662f4 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsHelper.java 843f572 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 3d69cc1 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperations.java 15379af 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockNamespaceOperations.java 9f0594a 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperations.java 16a8e02 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockShell.java 2bc9436 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java d3b1571 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTabletLocator.java 6bd01a9 
>   core/src/main/java/org/apache/accumulo/core/security/Credentials.java 5afc6e8 
>   core/src/test/java/org/apache/accumulo/core/security/CredentialsTest.java 4f8079e 
> 
> Diff: https://reviews.apache.org/r/20636/diff/
> 
> 
> Testing
> -------
> 
> unit tests pass. waiting on ITs.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>

Re: Review Request 20636: ACCUMULO-2726 restore binary compatibility 1.5 -> 1.6

Posted by ke...@deenlo.com.


> On April 23, 2014, 11:24 p.m., kturner wrote:
> > core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java, line 62
> > <https://reviews.apache.org/r/20636/diff/1/?file=566298#file566298line62>
> >
> >     this class is completely new in 1.6.0... if this were to make it into RC4, then this class could just start off in an impl package
> 
> Sean Busbey wrote:
>     Couldn't move it out of the package because it needs to access package-private parts of TableOperationsImpl. Couldn't make it package-private because impl/ConnectorImpl needs to access it.
>     
>     So ATM, still marked as deprecated in the version it was introduced. Should I add a javadoc (or non-javadoc comment) that explains this?
> 
> kturner wrote:
>     What about doing the following?
>     
>      1 Move *Impl classes to impl package
>      2 Create *Impl classes that extent impl.*Impl classes and expose whatever is public
>     
>     This way internal code does not need to instantiate deprecated code AND NamespaceOperationsImpl can be deleted.   
>     
>     Christopher did something similar when deprecating the mapreduce util package.
> 
> Christopher Tubbs wrote:
>     I used delegation, not extension, but yeah, similar.
> 
> kturner wrote:
>     there is an advantage to delegation over extension.   Delegation makes its easy to freeze the deprecated API.  W/ extension adding a public method in a impl.*Impl class will add it to the *Impl class that extends it.
> 
> Sean Busbey wrote:
>     I'm already mostly done with the extension version. Does anyone feel strongly about using delegation?

I slightly prefer delegation.  But the entire class is deperecated, so even if new methods come into existance it probably does not matter too much (its just kinda screwy).


- kturner


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20636/#review41240
-----------------------------------------------------------


On April 24, 2014, 7:34 a.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20636/
> -----------------------------------------------------------
> 
> (Updated April 24, 2014, 7:34 a.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2726
>     https://issues.apache.org/jira/browse/ACCUMULO-2726
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> restores things found missing by japi compliance checker
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java f80eee5 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsHelper.java b9a7791 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java 569a3b6 
>   core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperationsImpl.java 9d662f4 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsHelper.java 843f572 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 3d69cc1 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ConnectorImpl.java 7d9d3ab 
>   core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsHelper.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/impl/InputConfigurator.java cfd9aa2 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockConnector.java 996198c 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperations.java 15379af 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockNamespaceOperations.java 9f0594a 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperations.java 16a8e02 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockShell.java 2bc9436 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java d3b1571 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTabletLocator.java 6bd01a9 
>   core/src/main/java/org/apache/accumulo/core/security/Credentials.java 5afc6e8 
>   core/src/test/java/org/apache/accumulo/core/security/CredentialsTest.java 4f8079e 
>   test/compat/japi-compliance/japi-accumulo-1.5.xml 9e6f47f 
>   test/compat/japi-compliance/japi-accumulo-1.6.xml 36553b8 
> 
> Diff: https://reviews.apache.org/r/20636/diff/
> 
> 
> Testing
> -------
> 
> unit tests pass. ITs passed.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>

Re: Review Request 20636: ACCUMULO-2726 restore binary compatibility 1.5 -> 1.6

Posted by Christopher Tubbs <ct...@apache.org>.


> On April 23, 2014, 7:24 p.m., kturner wrote:
> > core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java, line 62
> > <https://reviews.apache.org/r/20636/diff/1/?file=566298#file566298line62>
> >
> >     this class is completely new in 1.6.0... if this were to make it into RC4, then this class could just start off in an impl package
> 
> Sean Busbey wrote:
>     Couldn't move it out of the package because it needs to access package-private parts of TableOperationsImpl. Couldn't make it package-private because impl/ConnectorImpl needs to access it.
>     
>     So ATM, still marked as deprecated in the version it was introduced. Should I add a javadoc (or non-javadoc comment) that explains this?
> 
> kturner wrote:
>     What about doing the following?
>     
>      1 Move *Impl classes to impl package
>      2 Create *Impl classes that extent impl.*Impl classes and expose whatever is public
>     
>     This way internal code does not need to instantiate deprecated code AND NamespaceOperationsImpl can be deleted.   
>     
>     Christopher did something similar when deprecating the mapreduce util package.

I used delegation, not extension, but yeah, similar.


- Christopher


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20636/#review41240
-----------------------------------------------------------


On April 24, 2014, 3:34 a.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20636/
> -----------------------------------------------------------
> 
> (Updated April 24, 2014, 3:34 a.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2726
>     https://issues.apache.org/jira/browse/ACCUMULO-2726
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> restores things found missing by japi compliance checker
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java f80eee5 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsHelper.java b9a7791 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java 569a3b6 
>   core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperationsImpl.java 9d662f4 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsHelper.java 843f572 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 3d69cc1 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ConnectorImpl.java 7d9d3ab 
>   core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsHelper.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/impl/InputConfigurator.java cfd9aa2 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockConnector.java 996198c 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperations.java 15379af 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockNamespaceOperations.java 9f0594a 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperations.java 16a8e02 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockShell.java 2bc9436 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java d3b1571 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTabletLocator.java 6bd01a9 
>   core/src/main/java/org/apache/accumulo/core/security/Credentials.java 5afc6e8 
>   core/src/test/java/org/apache/accumulo/core/security/CredentialsTest.java 4f8079e 
>   test/compat/japi-compliance/japi-accumulo-1.5.xml 9e6f47f 
>   test/compat/japi-compliance/japi-accumulo-1.6.xml 36553b8 
> 
> Diff: https://reviews.apache.org/r/20636/diff/
> 
> 
> Testing
> -------
> 
> unit tests pass. ITs passed.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>

Re: Review Request 20636: ACCUMULO-2726 restore binary compatibility 1.5 -> 1.6

Posted by ke...@deenlo.com.


> On April 23, 2014, 11:24 p.m., kturner wrote:
> > core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java, line 62
> > <https://reviews.apache.org/r/20636/diff/1/?file=566298#file566298line62>
> >
> >     this class is completely new in 1.6.0... if this were to make it into RC4, then this class could just start off in an impl package
> 
> Sean Busbey wrote:
>     Couldn't move it out of the package because it needs to access package-private parts of TableOperationsImpl. Couldn't make it package-private because impl/ConnectorImpl needs to access it.
>     
>     So ATM, still marked as deprecated in the version it was introduced. Should I add a javadoc (or non-javadoc comment) that explains this?

What about doing the following?

 1 Move *Impl classes to impl package
 2 Create *Impl classes that extent impl.*Impl classes and expose whatever is public

This way internal code does not need to instantiate deprecated code AND NamespaceOperationsImpl can be deleted.   

Christopher did something similar when deprecating the mapreduce util package.   


- kturner


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20636/#review41240
-----------------------------------------------------------


On April 24, 2014, 7:34 a.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20636/
> -----------------------------------------------------------
> 
> (Updated April 24, 2014, 7:34 a.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2726
>     https://issues.apache.org/jira/browse/ACCUMULO-2726
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> restores things found missing by japi compliance checker
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java f80eee5 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsHelper.java b9a7791 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java 569a3b6 
>   core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperationsImpl.java 9d662f4 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsHelper.java 843f572 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 3d69cc1 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ConnectorImpl.java 7d9d3ab 
>   core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsHelper.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/impl/InputConfigurator.java cfd9aa2 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockConnector.java 996198c 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperations.java 15379af 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockNamespaceOperations.java 9f0594a 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperations.java 16a8e02 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockShell.java 2bc9436 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java d3b1571 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTabletLocator.java 6bd01a9 
>   core/src/main/java/org/apache/accumulo/core/security/Credentials.java 5afc6e8 
>   core/src/test/java/org/apache/accumulo/core/security/CredentialsTest.java 4f8079e 
>   test/compat/japi-compliance/japi-accumulo-1.5.xml 9e6f47f 
>   test/compat/japi-compliance/japi-accumulo-1.6.xml 36553b8 
> 
> Diff: https://reviews.apache.org/r/20636/diff/
> 
> 
> Testing
> -------
> 
> unit tests pass. ITs passed.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>

Re: Review Request 20636: ACCUMULO-2726 restore binary compatibility 1.5 -> 1.6

Posted by ke...@deenlo.com.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20636/#review41240
-----------------------------------------------------------



core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java
<https://reviews.apache.org/r/20636/#comment74679>

    why deprecate this method when the entire class is deperecated?



core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java
<https://reviews.apache.org/r/20636/#comment74677>

    this class is completely new in 1.6.0... if this were to make it into RC4, then this class could just start off in an impl package



core/src/main/java/org/apache/accumulo/core/client/mock/MockNamespaceOperations.java
<https://reviews.apache.org/r/20636/#comment74680>

    I assume this class is also completely new in 1.6.0


- kturner


On April 23, 2014, 10:34 p.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20636/
> -----------------------------------------------------------
> 
> (Updated April 23, 2014, 10:34 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2726
>     https://issues.apache.org/jira/browse/ACCUMULO-2726
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> restores things found missing by japi compliance checker
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java f80eee5 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsHelper.java b9a7791 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java 569a3b6 
>   core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperationsImpl.java 9d662f4 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsHelper.java 843f572 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 3d69cc1 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperations.java 15379af 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockNamespaceOperations.java 9f0594a 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperations.java 16a8e02 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockShell.java 2bc9436 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java d3b1571 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTabletLocator.java 6bd01a9 
>   core/src/main/java/org/apache/accumulo/core/security/Credentials.java 5afc6e8 
>   core/src/test/java/org/apache/accumulo/core/security/CredentialsTest.java 4f8079e 
> 
> Diff: https://reviews.apache.org/r/20636/diff/
> 
> 
> Testing
> -------
> 
> unit tests pass. waiting on ITs.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>

Re: Review Request 20636: ACCUMULO-2726 restore binary compatibility 1.5 -> 1.6

Posted by Sean Busbey <se...@manvsbeard.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20636/#review41396
-----------------------------------------------------------



core/src/main/java/org/apache/accumulo/core/client/admin/ActiveCompaction.java
<https://reviews.apache.org/r/20636/#comment74834>

    For completeness, this does add a default constructor to the API. that means users will be able to instantiate subclasses of ActiveCompaction where before they could not.



core/src/main/java/org/apache/accumulo/core/client/admin/ActiveScan.java
<https://reviews.apache.org/r/20636/#comment74835>

    For completeness, this does add a default constructor to the API. that means users will be able to instantiate subclasses of ActiveScan where before they could not.


- Sean Busbey


On April 24, 2014, 8:54 p.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20636/
> -----------------------------------------------------------
> 
> (Updated April 24, 2014, 8:54 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2726
>     https://issues.apache.org/jira/browse/ACCUMULO-2726
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> restores things found missing by japi compliance checker
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/client/admin/ActiveCompaction.java 9c39ea6 
>   core/src/main/java/org/apache/accumulo/core/client/admin/ActiveScan.java 30e47af 
>   core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java f80eee5 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsHelper.java b9a7791 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java 569a3b6 
>   core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperationsImpl.java 9d662f4 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsHelper.java 843f572 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 3d69cc1 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ActiveCompactionImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ActiveScanImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ConnectorImpl.java 7d9d3ab 
>   core/src/main/java/org/apache/accumulo/core/client/impl/InstanceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsHelper.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/SecurityOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsHelper.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockConnector.java 996198c 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperations.java 15379af 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockNamespaceOperations.java 9f0594a 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperations.java 16a8e02 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockShell.java 2bc9436 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java d3b1571 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTabletLocator.java 6bd01a9 
>   core/src/main/java/org/apache/accumulo/core/security/Credentials.java 5afc6e8 
>   core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java 32136a8 
>   core/src/test/java/org/apache/accumulo/core/client/impl/TableOperationsHelperTest.java PRE-CREATION 
>   core/src/test/java/org/apache/accumulo/core/security/CredentialsTest.java 4f8079e 
>   server/base/src/main/java/org/apache/accumulo/server/security/SecurityOperation.java c2a7001 
>   server/master/src/main/java/org/apache/accumulo/master/FateServiceHandler.java d63a63e 
>   server/master/src/main/java/org/apache/accumulo/master/tableOps/ImportTable.java cd59b78 
>   test/compat/japi-compliance/japi-accumulo-1.5.xml 9e6f47f 
>   test/compat/japi-compliance/japi-accumulo-1.6.xml 36553b8 
> 
> Diff: https://reviews.apache.org/r/20636/diff/
> 
> 
> Testing
> -------
> 
> unit tests pass. ITs passed.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>

Re: Review Request 20636: ACCUMULO-2726 restore binary compatibility 1.5 -> 1.6

Posted by ke...@deenlo.com.


> On April 24, 2014, 9:16 p.m., Mike Drob wrote:
> > core/src/main/java/org/apache/accumulo/core/client/admin/ActiveScan.java, line 34
> > <https://reviews.apache.org/r/20636/diff/5/?file=568052#file568052line34>
> >
> >     Add @since 1.5.0 (?)
> >     
> >     Might be older, actually.
> 
> Sean Busbey wrote:
>     Can someone tell me which version this is actually @since?
> 
> Mike Drob wrote:
>     Initial import. Might not be worth annotating, at this point. Or call it @since 1.3.5, I guess.
> 
> Christopher Tubbs wrote:
>     Not worth annotating. We started doing this in 1.5.0 and we're not going to go back and update all the older stuff. If it didn't already have it, don't bother.

if pre 1.5.0 APIs were to be annotated w/ since tags that should probably be done in a seperate ticket... instead of doing one here


- kturner


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20636/#review41385
-----------------------------------------------------------


On April 24, 2014, 8:54 p.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20636/
> -----------------------------------------------------------
> 
> (Updated April 24, 2014, 8:54 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2726
>     https://issues.apache.org/jira/browse/ACCUMULO-2726
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> restores things found missing by japi compliance checker
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/client/admin/ActiveCompaction.java 9c39ea6 
>   core/src/main/java/org/apache/accumulo/core/client/admin/ActiveScan.java 30e47af 
>   core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java f80eee5 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsHelper.java b9a7791 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java 569a3b6 
>   core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperationsImpl.java 9d662f4 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsHelper.java 843f572 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 3d69cc1 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ActiveCompactionImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ActiveScanImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ConnectorImpl.java 7d9d3ab 
>   core/src/main/java/org/apache/accumulo/core/client/impl/InstanceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsHelper.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/SecurityOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsHelper.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockConnector.java 996198c 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperations.java 15379af 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockNamespaceOperations.java 9f0594a 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperations.java 16a8e02 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockShell.java 2bc9436 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java d3b1571 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTabletLocator.java 6bd01a9 
>   core/src/main/java/org/apache/accumulo/core/security/Credentials.java 5afc6e8 
>   core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java 32136a8 
>   core/src/test/java/org/apache/accumulo/core/client/impl/TableOperationsHelperTest.java PRE-CREATION 
>   core/src/test/java/org/apache/accumulo/core/security/CredentialsTest.java 4f8079e 
>   server/base/src/main/java/org/apache/accumulo/server/security/SecurityOperation.java c2a7001 
>   server/master/src/main/java/org/apache/accumulo/master/FateServiceHandler.java d63a63e 
>   server/master/src/main/java/org/apache/accumulo/master/tableOps/ImportTable.java cd59b78 
>   test/compat/japi-compliance/japi-accumulo-1.5.xml 9e6f47f 
>   test/compat/japi-compliance/japi-accumulo-1.6.xml 36553b8 
> 
> Diff: https://reviews.apache.org/r/20636/diff/
> 
> 
> Testing
> -------
> 
> unit tests pass. ITs passed.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>

Re: Review Request 20636: ACCUMULO-2726 restore binary compatibility 1.5 -> 1.6

Posted by Sean Busbey <se...@manvsbeard.com>.


> On April 24, 2014, 9:16 p.m., Mike Drob wrote:
> > core/src/main/java/org/apache/accumulo/core/client/admin/ActiveScan.java, line 34
> > <https://reviews.apache.org/r/20636/diff/5/?file=568052#file568052line34>
> >
> >     Add @since 1.5.0 (?)
> >     
> >     Might be older, actually.

Can someone tell me which version this is actually @since?


- Sean


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20636/#review41385
-----------------------------------------------------------


On April 24, 2014, 8:54 p.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20636/
> -----------------------------------------------------------
> 
> (Updated April 24, 2014, 8:54 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2726
>     https://issues.apache.org/jira/browse/ACCUMULO-2726
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> restores things found missing by japi compliance checker
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/client/admin/ActiveCompaction.java 9c39ea6 
>   core/src/main/java/org/apache/accumulo/core/client/admin/ActiveScan.java 30e47af 
>   core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java f80eee5 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsHelper.java b9a7791 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java 569a3b6 
>   core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperationsImpl.java 9d662f4 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsHelper.java 843f572 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 3d69cc1 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ActiveCompactionImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ActiveScanImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ConnectorImpl.java 7d9d3ab 
>   core/src/main/java/org/apache/accumulo/core/client/impl/InstanceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsHelper.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/SecurityOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsHelper.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockConnector.java 996198c 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperations.java 15379af 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockNamespaceOperations.java 9f0594a 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperations.java 16a8e02 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockShell.java 2bc9436 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java d3b1571 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTabletLocator.java 6bd01a9 
>   core/src/main/java/org/apache/accumulo/core/security/Credentials.java 5afc6e8 
>   core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java 32136a8 
>   core/src/test/java/org/apache/accumulo/core/client/impl/TableOperationsHelperTest.java PRE-CREATION 
>   core/src/test/java/org/apache/accumulo/core/security/CredentialsTest.java 4f8079e 
>   server/base/src/main/java/org/apache/accumulo/server/security/SecurityOperation.java c2a7001 
>   server/master/src/main/java/org/apache/accumulo/master/FateServiceHandler.java d63a63e 
>   server/master/src/main/java/org/apache/accumulo/master/tableOps/ImportTable.java cd59b78 
>   test/compat/japi-compliance/japi-accumulo-1.5.xml 9e6f47f 
>   test/compat/japi-compliance/japi-accumulo-1.6.xml 36553b8 
> 
> Diff: https://reviews.apache.org/r/20636/diff/
> 
> 
> Testing
> -------
> 
> unit tests pass. ITs passed.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>

Re: Review Request 20636: ACCUMULO-2726 restore binary compatibility 1.5 -> 1.6

Posted by Mike Drob <md...@mdrob.com>.


> On April 24, 2014, 9:16 p.m., Mike Drob wrote:
> > core/src/main/java/org/apache/accumulo/core/client/admin/ActiveScan.java, line 34
> > <https://reviews.apache.org/r/20636/diff/5/?file=568052#file568052line34>
> >
> >     Add @since 1.5.0 (?)
> >     
> >     Might be older, actually.
> 
> Sean Busbey wrote:
>     Can someone tell me which version this is actually @since?

Initial import. Might not be worth annotating, at this point. Or call it @since 1.3.5, I guess.


- Mike


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20636/#review41385
-----------------------------------------------------------


On April 24, 2014, 8:54 p.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20636/
> -----------------------------------------------------------
> 
> (Updated April 24, 2014, 8:54 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2726
>     https://issues.apache.org/jira/browse/ACCUMULO-2726
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> restores things found missing by japi compliance checker
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/client/admin/ActiveCompaction.java 9c39ea6 
>   core/src/main/java/org/apache/accumulo/core/client/admin/ActiveScan.java 30e47af 
>   core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java f80eee5 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsHelper.java b9a7791 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java 569a3b6 
>   core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperationsImpl.java 9d662f4 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsHelper.java 843f572 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 3d69cc1 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ActiveCompactionImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ActiveScanImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ConnectorImpl.java 7d9d3ab 
>   core/src/main/java/org/apache/accumulo/core/client/impl/InstanceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsHelper.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/SecurityOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsHelper.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockConnector.java 996198c 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperations.java 15379af 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockNamespaceOperations.java 9f0594a 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperations.java 16a8e02 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockShell.java 2bc9436 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java d3b1571 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTabletLocator.java 6bd01a9 
>   core/src/main/java/org/apache/accumulo/core/security/Credentials.java 5afc6e8 
>   core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java 32136a8 
>   core/src/test/java/org/apache/accumulo/core/client/impl/TableOperationsHelperTest.java PRE-CREATION 
>   core/src/test/java/org/apache/accumulo/core/security/CredentialsTest.java 4f8079e 
>   server/base/src/main/java/org/apache/accumulo/server/security/SecurityOperation.java c2a7001 
>   server/master/src/main/java/org/apache/accumulo/master/FateServiceHandler.java d63a63e 
>   server/master/src/main/java/org/apache/accumulo/master/tableOps/ImportTable.java cd59b78 
>   test/compat/japi-compliance/japi-accumulo-1.5.xml 9e6f47f 
>   test/compat/japi-compliance/japi-accumulo-1.6.xml 36553b8 
> 
> Diff: https://reviews.apache.org/r/20636/diff/
> 
> 
> Testing
> -------
> 
> unit tests pass. ITs passed.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>

Re: Review Request 20636: ACCUMULO-2726 restore binary compatibility 1.5 -> 1.6

Posted by Christopher Tubbs <ct...@apache.org>.


> On April 24, 2014, 5:16 p.m., Mike Drob wrote:
> > core/src/main/java/org/apache/accumulo/core/client/admin/ActiveScan.java, line 34
> > <https://reviews.apache.org/r/20636/diff/5/?file=568052#file568052line34>
> >
> >     Add @since 1.5.0 (?)
> >     
> >     Might be older, actually.
> 
> Sean Busbey wrote:
>     Can someone tell me which version this is actually @since?
> 
> Mike Drob wrote:
>     Initial import. Might not be worth annotating, at this point. Or call it @since 1.3.5, I guess.

Not worth annotating. We started doing this in 1.5.0 and we're not going to go back and update all the older stuff. If it didn't already have it, don't bother.


- Christopher


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20636/#review41385
-----------------------------------------------------------


On April 24, 2014, 4:54 p.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20636/
> -----------------------------------------------------------
> 
> (Updated April 24, 2014, 4:54 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2726
>     https://issues.apache.org/jira/browse/ACCUMULO-2726
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> restores things found missing by japi compliance checker
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/client/admin/ActiveCompaction.java 9c39ea6 
>   core/src/main/java/org/apache/accumulo/core/client/admin/ActiveScan.java 30e47af 
>   core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java f80eee5 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsHelper.java b9a7791 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java 569a3b6 
>   core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperationsImpl.java 9d662f4 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsHelper.java 843f572 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 3d69cc1 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ActiveCompactionImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ActiveScanImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ConnectorImpl.java 7d9d3ab 
>   core/src/main/java/org/apache/accumulo/core/client/impl/InstanceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsHelper.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/SecurityOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsHelper.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockConnector.java 996198c 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperations.java 15379af 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockNamespaceOperations.java 9f0594a 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperations.java 16a8e02 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockShell.java 2bc9436 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java d3b1571 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTabletLocator.java 6bd01a9 
>   core/src/main/java/org/apache/accumulo/core/security/Credentials.java 5afc6e8 
>   core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java 32136a8 
>   core/src/test/java/org/apache/accumulo/core/client/impl/TableOperationsHelperTest.java PRE-CREATION 
>   core/src/test/java/org/apache/accumulo/core/security/CredentialsTest.java 4f8079e 
>   server/base/src/main/java/org/apache/accumulo/server/security/SecurityOperation.java c2a7001 
>   server/master/src/main/java/org/apache/accumulo/master/FateServiceHandler.java d63a63e 
>   server/master/src/main/java/org/apache/accumulo/master/tableOps/ImportTable.java cd59b78 
>   test/compat/japi-compliance/japi-accumulo-1.5.xml 9e6f47f 
>   test/compat/japi-compliance/japi-accumulo-1.6.xml 36553b8 
> 
> Diff: https://reviews.apache.org/r/20636/diff/
> 
> 
> Testing
> -------
> 
> unit tests pass. ITs passed.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>

Re: Review Request 20636: ACCUMULO-2726 restore binary compatibility 1.5 -> 1.6

Posted by Mike Drob <md...@mdrob.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20636/#review41385
-----------------------------------------------------------



core/src/main/java/org/apache/accumulo/core/client/admin/ActiveScan.java
<https://reviews.apache.org/r/20636/#comment74819>

    Add @since 1.5.0 (?)
    
    Might be older, actually.



core/src/main/java/org/apache/accumulo/core/client/impl/ActiveCompactionImpl.java
<https://reviews.apache.org/r/20636/#comment74817>

    nit: whitespace. (and the rest of the file).



core/src/main/java/org/apache/accumulo/core/client/impl/ActiveCompactionImpl.java
<https://reviews.apache.org/r/20636/#comment74816>

    since 1.6



core/src/main/java/org/apache/accumulo/core/client/impl/ActiveScanImpl.java
<https://reviews.apache.org/r/20636/#comment74820>

    Add @since



core/src/main/java/org/apache/accumulo/core/client/impl/ActiveScanImpl.java
<https://reviews.apache.org/r/20636/#comment74821>

    nit: whitespace


- Mike Drob


On April 24, 2014, 8:54 p.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20636/
> -----------------------------------------------------------
> 
> (Updated April 24, 2014, 8:54 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2726
>     https://issues.apache.org/jira/browse/ACCUMULO-2726
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> restores things found missing by japi compliance checker
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/client/admin/ActiveCompaction.java 9c39ea6 
>   core/src/main/java/org/apache/accumulo/core/client/admin/ActiveScan.java 30e47af 
>   core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java f80eee5 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsHelper.java b9a7791 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java 569a3b6 
>   core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperationsImpl.java 9d662f4 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsHelper.java 843f572 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 3d69cc1 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ActiveCompactionImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ActiveScanImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ConnectorImpl.java 7d9d3ab 
>   core/src/main/java/org/apache/accumulo/core/client/impl/InstanceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsHelper.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/SecurityOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsHelper.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockConnector.java 996198c 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperations.java 15379af 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockNamespaceOperations.java 9f0594a 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperations.java 16a8e02 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockShell.java 2bc9436 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java d3b1571 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTabletLocator.java 6bd01a9 
>   core/src/main/java/org/apache/accumulo/core/security/Credentials.java 5afc6e8 
>   core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java 32136a8 
>   core/src/test/java/org/apache/accumulo/core/client/impl/TableOperationsHelperTest.java PRE-CREATION 
>   core/src/test/java/org/apache/accumulo/core/security/CredentialsTest.java 4f8079e 
>   server/base/src/main/java/org/apache/accumulo/server/security/SecurityOperation.java c2a7001 
>   server/master/src/main/java/org/apache/accumulo/master/FateServiceHandler.java d63a63e 
>   server/master/src/main/java/org/apache/accumulo/master/tableOps/ImportTable.java cd59b78 
>   test/compat/japi-compliance/japi-accumulo-1.5.xml 9e6f47f 
>   test/compat/japi-compliance/japi-accumulo-1.6.xml 36553b8 
> 
> Diff: https://reviews.apache.org/r/20636/diff/
> 
> 
> Testing
> -------
> 
> unit tests pass. ITs passed.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>

Re: Review Request 20636: ACCUMULO-2726 restore binary compatibility 1.5 -> 1.6

Posted by Christopher Tubbs <ct...@apache.org>.


> On April 24, 2014, 5:18 p.m., Christopher Tubbs wrote:
> > core/src/main/java/org/apache/accumulo/core/security/Credentials.java, lines 94-100
> > <https://reviews.apache.org/r/20636/diff/4/?file=568016#file568016line94>
> >
> >     I'm not a fan of baking in more thrift/RPC stuff into the rest of the code.
> >     
> >     This isn't serious, because Credentials is not public API (yet), but I'm opposed to it. I'd rather just inline these than modify Credentials.
> 
> Sean Busbey wrote:
>     are you -1 or -0?
> 
> Christopher Tubbs wrote:
>     -1, especially because the other issue, with the use Credentials version. It makes no sense to switch from TCredentials to Credentials if Credentials just has TCredentials in its API.
> 
> Sean Busbey wrote:
>     I've fixed the other issue with the reference to "use the Credentials version". It no longer says that.
>     
>     Fixing the coupling of Credentials to TCredentials will touch 60+ files. Could we do it in a follow on?

How would inlining this brand new method, affect 60+ classes?


- Christopher


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20636/#review41382
-----------------------------------------------------------


On April 24, 2014, 4:54 p.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20636/
> -----------------------------------------------------------
> 
> (Updated April 24, 2014, 4:54 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2726
>     https://issues.apache.org/jira/browse/ACCUMULO-2726
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> restores things found missing by japi compliance checker
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/client/admin/ActiveCompaction.java 9c39ea6 
>   core/src/main/java/org/apache/accumulo/core/client/admin/ActiveScan.java 30e47af 
>   core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java f80eee5 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsHelper.java b9a7791 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java 569a3b6 
>   core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperationsImpl.java 9d662f4 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsHelper.java 843f572 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 3d69cc1 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ActiveCompactionImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ActiveScanImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ConnectorImpl.java 7d9d3ab 
>   core/src/main/java/org/apache/accumulo/core/client/impl/InstanceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsHelper.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/SecurityOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsHelper.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockConnector.java 996198c 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperations.java 15379af 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockNamespaceOperations.java 9f0594a 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperations.java 16a8e02 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockShell.java 2bc9436 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java d3b1571 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTabletLocator.java 6bd01a9 
>   core/src/main/java/org/apache/accumulo/core/security/Credentials.java 5afc6e8 
>   core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java 32136a8 
>   core/src/test/java/org/apache/accumulo/core/client/impl/TableOperationsHelperTest.java PRE-CREATION 
>   core/src/test/java/org/apache/accumulo/core/security/CredentialsTest.java 4f8079e 
>   server/base/src/main/java/org/apache/accumulo/server/security/SecurityOperation.java c2a7001 
>   server/master/src/main/java/org/apache/accumulo/master/FateServiceHandler.java d63a63e 
>   server/master/src/main/java/org/apache/accumulo/master/tableOps/ImportTable.java cd59b78 
>   test/compat/japi-compliance/japi-accumulo-1.5.xml 9e6f47f 
>   test/compat/japi-compliance/japi-accumulo-1.6.xml 36553b8 
> 
> Diff: https://reviews.apache.org/r/20636/diff/
> 
> 
> Testing
> -------
> 
> unit tests pass. ITs passed.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>

Re: Review Request 20636: ACCUMULO-2726 restore binary compatibility 1.5 -> 1.6

Posted by Sean Busbey <se...@manvsbeard.com>.


> On April 24, 2014, 9:18 p.m., Christopher Tubbs wrote:
> > core/src/main/java/org/apache/accumulo/core/security/Credentials.java, lines 94-100
> > <https://reviews.apache.org/r/20636/diff/4/?file=568016#file568016line94>
> >
> >     I'm not a fan of baking in more thrift/RPC stuff into the rest of the code.
> >     
> >     This isn't serious, because Credentials is not public API (yet), but I'm opposed to it. I'd rather just inline these than modify Credentials.
> 
> Sean Busbey wrote:
>     are you -1 or -0?
> 
> Christopher Tubbs wrote:
>     -1, especially because the other issue, with the use Credentials version. It makes no sense to switch from TCredentials to Credentials if Credentials just has TCredentials in its API.
> 
> Sean Busbey wrote:
>     I've fixed the other issue with the reference to "use the Credentials version". It no longer says that.
>     
>     Fixing the coupling of Credentials to TCredentials will touch 60+ files. Could we do it in a follow on?
> 
> Christopher Tubbs wrote:
>     How would inlining this brand new method, affect 60+ classes?
> 
> Sean Busbey wrote:
>     I am -1 to inlining. We should have paired serialization methods. toThrift will have to go somewhere that fromThrift can also go. ATM I have a partial implementation that moves them out of Credentials to a helper class.
> 
> Christopher Tubbs wrote:
>     Actually, nevermind... I see now. The toThrift method already exists. That's what you mean. I wasn't thinking that much... I just didn't want to add any *new* couplings here. Decoupling it entirely (Dropping toThrift) is something that I plan to address in the future.
> 
> Christopher Tubbs wrote:
>     I concede. I'll change my objection to -0. This new method's introduction, it's utilization, and its new tests could easily have been done in a follow-on issue, as I consider it out of scope for the API issue, but I will not block the RC4 with my objection.

ACCUMULO-2733 consolidates manual deserializations into a fromThrift call per discussion on IRC. If that ticket gets +1ed before this one does, I'll refactor this patch to be based on that one.


- Sean


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20636/#review41382
-----------------------------------------------------------


On April 24, 2014, 8:54 p.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20636/
> -----------------------------------------------------------
> 
> (Updated April 24, 2014, 8:54 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2726
>     https://issues.apache.org/jira/browse/ACCUMULO-2726
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> restores things found missing by japi compliance checker
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/client/admin/ActiveCompaction.java 9c39ea6 
>   core/src/main/java/org/apache/accumulo/core/client/admin/ActiveScan.java 30e47af 
>   core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java f80eee5 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsHelper.java b9a7791 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java 569a3b6 
>   core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperationsImpl.java 9d662f4 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsHelper.java 843f572 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 3d69cc1 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ActiveCompactionImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ActiveScanImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ConnectorImpl.java 7d9d3ab 
>   core/src/main/java/org/apache/accumulo/core/client/impl/InstanceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsHelper.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/SecurityOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsHelper.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockConnector.java 996198c 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperations.java 15379af 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockNamespaceOperations.java 9f0594a 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperations.java 16a8e02 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockShell.java 2bc9436 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java d3b1571 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTabletLocator.java 6bd01a9 
>   core/src/main/java/org/apache/accumulo/core/security/Credentials.java 5afc6e8 
>   core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java 32136a8 
>   core/src/test/java/org/apache/accumulo/core/client/impl/TableOperationsHelperTest.java PRE-CREATION 
>   core/src/test/java/org/apache/accumulo/core/security/CredentialsTest.java 4f8079e 
>   server/base/src/main/java/org/apache/accumulo/server/security/SecurityOperation.java c2a7001 
>   server/master/src/main/java/org/apache/accumulo/master/FateServiceHandler.java d63a63e 
>   server/master/src/main/java/org/apache/accumulo/master/tableOps/ImportTable.java cd59b78 
>   test/compat/japi-compliance/japi-accumulo-1.5.xml 9e6f47f 
>   test/compat/japi-compliance/japi-accumulo-1.6.xml 36553b8 
> 
> Diff: https://reviews.apache.org/r/20636/diff/
> 
> 
> Testing
> -------
> 
> unit tests pass. ITs passed.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>

Re: Review Request 20636: ACCUMULO-2726 restore binary compatibility 1.5 -> 1.6

Posted by Christopher Tubbs <ct...@apache.org>.


> On April 24, 2014, 5:18 p.m., Christopher Tubbs wrote:
> > core/src/main/java/org/apache/accumulo/core/security/Credentials.java, lines 94-100
> > <https://reviews.apache.org/r/20636/diff/4/?file=568016#file568016line94>
> >
> >     I'm not a fan of baking in more thrift/RPC stuff into the rest of the code.
> >     
> >     This isn't serious, because Credentials is not public API (yet), but I'm opposed to it. I'd rather just inline these than modify Credentials.
> 
> Sean Busbey wrote:
>     are you -1 or -0?
> 
> Christopher Tubbs wrote:
>     -1, especially because the other issue, with the use Credentials version. It makes no sense to switch from TCredentials to Credentials if Credentials just has TCredentials in its API.
> 
> Sean Busbey wrote:
>     I've fixed the other issue with the reference to "use the Credentials version". It no longer says that.
>     
>     Fixing the coupling of Credentials to TCredentials will touch 60+ files. Could we do it in a follow on?
> 
> Christopher Tubbs wrote:
>     How would inlining this brand new method, affect 60+ classes?
> 
> Sean Busbey wrote:
>     I am -1 to inlining. We should have paired serialization methods. toThrift will have to go somewhere that fromThrift can also go. ATM I have a partial implementation that moves them out of Credentials to a helper class.
> 
> Christopher Tubbs wrote:
>     Actually, nevermind... I see now. The toThrift method already exists. That's what you mean. I wasn't thinking that much... I just didn't want to add any *new* couplings here. Decoupling it entirely (Dropping toThrift) is something that I plan to address in the future.

I concede. I'll change my objection to -0. This new method's introduction, it's utilization, and its new tests could easily have been done in a follow-on issue, as I consider it out of scope for the API issue, but I will not block the RC4 with my objection.


- Christopher


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20636/#review41382
-----------------------------------------------------------


On April 24, 2014, 4:54 p.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20636/
> -----------------------------------------------------------
> 
> (Updated April 24, 2014, 4:54 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2726
>     https://issues.apache.org/jira/browse/ACCUMULO-2726
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> restores things found missing by japi compliance checker
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/client/admin/ActiveCompaction.java 9c39ea6 
>   core/src/main/java/org/apache/accumulo/core/client/admin/ActiveScan.java 30e47af 
>   core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java f80eee5 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsHelper.java b9a7791 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java 569a3b6 
>   core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperationsImpl.java 9d662f4 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsHelper.java 843f572 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 3d69cc1 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ActiveCompactionImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ActiveScanImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ConnectorImpl.java 7d9d3ab 
>   core/src/main/java/org/apache/accumulo/core/client/impl/InstanceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsHelper.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/SecurityOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsHelper.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockConnector.java 996198c 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperations.java 15379af 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockNamespaceOperations.java 9f0594a 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperations.java 16a8e02 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockShell.java 2bc9436 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java d3b1571 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTabletLocator.java 6bd01a9 
>   core/src/main/java/org/apache/accumulo/core/security/Credentials.java 5afc6e8 
>   core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java 32136a8 
>   core/src/test/java/org/apache/accumulo/core/client/impl/TableOperationsHelperTest.java PRE-CREATION 
>   core/src/test/java/org/apache/accumulo/core/security/CredentialsTest.java 4f8079e 
>   server/base/src/main/java/org/apache/accumulo/server/security/SecurityOperation.java c2a7001 
>   server/master/src/main/java/org/apache/accumulo/master/FateServiceHandler.java d63a63e 
>   server/master/src/main/java/org/apache/accumulo/master/tableOps/ImportTable.java cd59b78 
>   test/compat/japi-compliance/japi-accumulo-1.5.xml 9e6f47f 
>   test/compat/japi-compliance/japi-accumulo-1.6.xml 36553b8 
> 
> Diff: https://reviews.apache.org/r/20636/diff/
> 
> 
> Testing
> -------
> 
> unit tests pass. ITs passed.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>

Re: Review Request 20636: ACCUMULO-2726 restore binary compatibility 1.5 -> 1.6

Posted by Christopher Tubbs <ct...@apache.org>.


> On April 24, 2014, 5:18 p.m., Christopher Tubbs wrote:
> > core/src/main/java/org/apache/accumulo/core/security/Credentials.java, lines 94-100
> > <https://reviews.apache.org/r/20636/diff/4/?file=568016#file568016line94>
> >
> >     I'm not a fan of baking in more thrift/RPC stuff into the rest of the code.
> >     
> >     This isn't serious, because Credentials is not public API (yet), but I'm opposed to it. I'd rather just inline these than modify Credentials.
> 
> Sean Busbey wrote:
>     are you -1 or -0?

-1, especially because the other issue, with the use Credentials version. It makes no sense to switch from TCredentials to Credentials if Credentials just has TCredentials in its API.


- Christopher


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20636/#review41382
-----------------------------------------------------------


On April 24, 2014, 4:54 p.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20636/
> -----------------------------------------------------------
> 
> (Updated April 24, 2014, 4:54 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2726
>     https://issues.apache.org/jira/browse/ACCUMULO-2726
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> restores things found missing by japi compliance checker
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/client/admin/ActiveCompaction.java 9c39ea6 
>   core/src/main/java/org/apache/accumulo/core/client/admin/ActiveScan.java 30e47af 
>   core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java f80eee5 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsHelper.java b9a7791 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java 569a3b6 
>   core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperationsImpl.java 9d662f4 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsHelper.java 843f572 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 3d69cc1 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ActiveCompactionImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ActiveScanImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ConnectorImpl.java 7d9d3ab 
>   core/src/main/java/org/apache/accumulo/core/client/impl/InstanceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsHelper.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/SecurityOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsHelper.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockConnector.java 996198c 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperations.java 15379af 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockNamespaceOperations.java 9f0594a 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperations.java 16a8e02 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockShell.java 2bc9436 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java d3b1571 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTabletLocator.java 6bd01a9 
>   core/src/main/java/org/apache/accumulo/core/security/Credentials.java 5afc6e8 
>   core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java 32136a8 
>   core/src/test/java/org/apache/accumulo/core/client/impl/TableOperationsHelperTest.java PRE-CREATION 
>   core/src/test/java/org/apache/accumulo/core/security/CredentialsTest.java 4f8079e 
>   server/base/src/main/java/org/apache/accumulo/server/security/SecurityOperation.java c2a7001 
>   server/master/src/main/java/org/apache/accumulo/master/FateServiceHandler.java d63a63e 
>   server/master/src/main/java/org/apache/accumulo/master/tableOps/ImportTable.java cd59b78 
>   test/compat/japi-compliance/japi-accumulo-1.5.xml 9e6f47f 
>   test/compat/japi-compliance/japi-accumulo-1.6.xml 36553b8 
> 
> Diff: https://reviews.apache.org/r/20636/diff/
> 
> 
> Testing
> -------
> 
> unit tests pass. ITs passed.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>

Re: Review Request 20636: ACCUMULO-2726 restore binary compatibility 1.5 -> 1.6

Posted by Sean Busbey <se...@manvsbeard.com>.


> On April 24, 2014, 9:18 p.m., Christopher Tubbs wrote:
> > core/src/main/java/org/apache/accumulo/core/security/Credentials.java, lines 94-100
> > <https://reviews.apache.org/r/20636/diff/4/?file=568016#file568016line94>
> >
> >     I'm not a fan of baking in more thrift/RPC stuff into the rest of the code.
> >     
> >     This isn't serious, because Credentials is not public API (yet), but I'm opposed to it. I'd rather just inline these than modify Credentials.
> 
> Sean Busbey wrote:
>     are you -1 or -0?
> 
> Christopher Tubbs wrote:
>     -1, especially because the other issue, with the use Credentials version. It makes no sense to switch from TCredentials to Credentials if Credentials just has TCredentials in its API.

I've fixed the other issue with the reference to "use the Credentials version". It no longer says that.

Fixing the coupling of Credentials to TCredentials will touch 60+ files. Could we do it in a follow on?


- Sean


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20636/#review41382
-----------------------------------------------------------


On April 24, 2014, 8:54 p.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20636/
> -----------------------------------------------------------
> 
> (Updated April 24, 2014, 8:54 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2726
>     https://issues.apache.org/jira/browse/ACCUMULO-2726
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> restores things found missing by japi compliance checker
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/client/admin/ActiveCompaction.java 9c39ea6 
>   core/src/main/java/org/apache/accumulo/core/client/admin/ActiveScan.java 30e47af 
>   core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java f80eee5 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsHelper.java b9a7791 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java 569a3b6 
>   core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperationsImpl.java 9d662f4 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsHelper.java 843f572 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 3d69cc1 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ActiveCompactionImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ActiveScanImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ConnectorImpl.java 7d9d3ab 
>   core/src/main/java/org/apache/accumulo/core/client/impl/InstanceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsHelper.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/SecurityOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsHelper.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockConnector.java 996198c 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperations.java 15379af 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockNamespaceOperations.java 9f0594a 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperations.java 16a8e02 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockShell.java 2bc9436 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java d3b1571 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTabletLocator.java 6bd01a9 
>   core/src/main/java/org/apache/accumulo/core/security/Credentials.java 5afc6e8 
>   core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java 32136a8 
>   core/src/test/java/org/apache/accumulo/core/client/impl/TableOperationsHelperTest.java PRE-CREATION 
>   core/src/test/java/org/apache/accumulo/core/security/CredentialsTest.java 4f8079e 
>   server/base/src/main/java/org/apache/accumulo/server/security/SecurityOperation.java c2a7001 
>   server/master/src/main/java/org/apache/accumulo/master/FateServiceHandler.java d63a63e 
>   server/master/src/main/java/org/apache/accumulo/master/tableOps/ImportTable.java cd59b78 
>   test/compat/japi-compliance/japi-accumulo-1.5.xml 9e6f47f 
>   test/compat/japi-compliance/japi-accumulo-1.6.xml 36553b8 
> 
> Diff: https://reviews.apache.org/r/20636/diff/
> 
> 
> Testing
> -------
> 
> unit tests pass. ITs passed.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>

Re: Review Request 20636: ACCUMULO-2726 restore binary compatibility 1.5 -> 1.6

Posted by Sean Busbey <se...@manvsbeard.com>.


> On April 24, 2014, 9:18 p.m., Christopher Tubbs wrote:
> > core/src/main/java/org/apache/accumulo/core/security/Credentials.java, lines 94-100
> > <https://reviews.apache.org/r/20636/diff/4/?file=568016#file568016line94>
> >
> >     I'm not a fan of baking in more thrift/RPC stuff into the rest of the code.
> >     
> >     This isn't serious, because Credentials is not public API (yet), but I'm opposed to it. I'd rather just inline these than modify Credentials.
> 
> Sean Busbey wrote:
>     are you -1 or -0?
> 
> Christopher Tubbs wrote:
>     -1, especially because the other issue, with the use Credentials version. It makes no sense to switch from TCredentials to Credentials if Credentials just has TCredentials in its API.
> 
> Sean Busbey wrote:
>     I've fixed the other issue with the reference to "use the Credentials version". It no longer says that.
>     
>     Fixing the coupling of Credentials to TCredentials will touch 60+ files. Could we do it in a follow on?
> 
> Christopher Tubbs wrote:
>     How would inlining this brand new method, affect 60+ classes?

I am -1 to inlining. We should have paired serialization methods. toThrift will have to go somewhere that fromThrift can also go. ATM I have a partial implementation that moves them out of Credentials to a helper class.


- Sean


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20636/#review41382
-----------------------------------------------------------


On April 24, 2014, 8:54 p.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20636/
> -----------------------------------------------------------
> 
> (Updated April 24, 2014, 8:54 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2726
>     https://issues.apache.org/jira/browse/ACCUMULO-2726
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> restores things found missing by japi compliance checker
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/client/admin/ActiveCompaction.java 9c39ea6 
>   core/src/main/java/org/apache/accumulo/core/client/admin/ActiveScan.java 30e47af 
>   core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java f80eee5 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsHelper.java b9a7791 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java 569a3b6 
>   core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperationsImpl.java 9d662f4 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsHelper.java 843f572 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 3d69cc1 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ActiveCompactionImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ActiveScanImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ConnectorImpl.java 7d9d3ab 
>   core/src/main/java/org/apache/accumulo/core/client/impl/InstanceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsHelper.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/SecurityOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsHelper.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockConnector.java 996198c 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperations.java 15379af 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockNamespaceOperations.java 9f0594a 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperations.java 16a8e02 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockShell.java 2bc9436 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java d3b1571 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTabletLocator.java 6bd01a9 
>   core/src/main/java/org/apache/accumulo/core/security/Credentials.java 5afc6e8 
>   core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java 32136a8 
>   core/src/test/java/org/apache/accumulo/core/client/impl/TableOperationsHelperTest.java PRE-CREATION 
>   core/src/test/java/org/apache/accumulo/core/security/CredentialsTest.java 4f8079e 
>   server/base/src/main/java/org/apache/accumulo/server/security/SecurityOperation.java c2a7001 
>   server/master/src/main/java/org/apache/accumulo/master/FateServiceHandler.java d63a63e 
>   server/master/src/main/java/org/apache/accumulo/master/tableOps/ImportTable.java cd59b78 
>   test/compat/japi-compliance/japi-accumulo-1.5.xml 9e6f47f 
>   test/compat/japi-compliance/japi-accumulo-1.6.xml 36553b8 
> 
> Diff: https://reviews.apache.org/r/20636/diff/
> 
> 
> Testing
> -------
> 
> unit tests pass. ITs passed.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>

Re: Review Request 20636: ACCUMULO-2726 restore binary compatibility 1.5 -> 1.6

Posted by Christopher Tubbs <ct...@apache.org>.


> On April 24, 2014, 5:18 p.m., Christopher Tubbs wrote:
> > core/src/main/java/org/apache/accumulo/core/security/Credentials.java, lines 94-100
> > <https://reviews.apache.org/r/20636/diff/4/?file=568016#file568016line94>
> >
> >     I'm not a fan of baking in more thrift/RPC stuff into the rest of the code.
> >     
> >     This isn't serious, because Credentials is not public API (yet), but I'm opposed to it. I'd rather just inline these than modify Credentials.
> 
> Sean Busbey wrote:
>     are you -1 or -0?
> 
> Christopher Tubbs wrote:
>     -1, especially because the other issue, with the use Credentials version. It makes no sense to switch from TCredentials to Credentials if Credentials just has TCredentials in its API.
> 
> Sean Busbey wrote:
>     I've fixed the other issue with the reference to "use the Credentials version". It no longer says that.
>     
>     Fixing the coupling of Credentials to TCredentials will touch 60+ files. Could we do it in a follow on?
> 
> Christopher Tubbs wrote:
>     How would inlining this brand new method, affect 60+ classes?
> 
> Sean Busbey wrote:
>     I am -1 to inlining. We should have paired serialization methods. toThrift will have to go somewhere that fromThrift can also go. ATM I have a partial implementation that moves them out of Credentials to a helper class.

Actually, nevermind... I see now. The toThrift method already exists. That's what you mean. I wasn't thinking that much... I just didn't want to add any *new* couplings here. Decoupling it entirely (Dropping toThrift) is something that I plan to address in the future.


- Christopher


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20636/#review41382
-----------------------------------------------------------


On April 24, 2014, 4:54 p.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20636/
> -----------------------------------------------------------
> 
> (Updated April 24, 2014, 4:54 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2726
>     https://issues.apache.org/jira/browse/ACCUMULO-2726
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> restores things found missing by japi compliance checker
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/client/admin/ActiveCompaction.java 9c39ea6 
>   core/src/main/java/org/apache/accumulo/core/client/admin/ActiveScan.java 30e47af 
>   core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java f80eee5 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsHelper.java b9a7791 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java 569a3b6 
>   core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperationsImpl.java 9d662f4 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsHelper.java 843f572 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 3d69cc1 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ActiveCompactionImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ActiveScanImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ConnectorImpl.java 7d9d3ab 
>   core/src/main/java/org/apache/accumulo/core/client/impl/InstanceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsHelper.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/SecurityOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsHelper.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockConnector.java 996198c 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperations.java 15379af 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockNamespaceOperations.java 9f0594a 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperations.java 16a8e02 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockShell.java 2bc9436 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java d3b1571 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTabletLocator.java 6bd01a9 
>   core/src/main/java/org/apache/accumulo/core/security/Credentials.java 5afc6e8 
>   core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java 32136a8 
>   core/src/test/java/org/apache/accumulo/core/client/impl/TableOperationsHelperTest.java PRE-CREATION 
>   core/src/test/java/org/apache/accumulo/core/security/CredentialsTest.java 4f8079e 
>   server/base/src/main/java/org/apache/accumulo/server/security/SecurityOperation.java c2a7001 
>   server/master/src/main/java/org/apache/accumulo/master/FateServiceHandler.java d63a63e 
>   server/master/src/main/java/org/apache/accumulo/master/tableOps/ImportTable.java cd59b78 
>   test/compat/japi-compliance/japi-accumulo-1.5.xml 9e6f47f 
>   test/compat/japi-compliance/japi-accumulo-1.6.xml 36553b8 
> 
> Diff: https://reviews.apache.org/r/20636/diff/
> 
> 
> Testing
> -------
> 
> unit tests pass. ITs passed.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>

Re: Review Request 20636: ACCUMULO-2726 restore binary compatibility 1.5 -> 1.6

Posted by Sean Busbey <se...@manvsbeard.com>.


> On April 24, 2014, 9:18 p.m., Christopher Tubbs wrote:
> > core/src/main/java/org/apache/accumulo/core/security/Credentials.java, lines 94-100
> > <https://reviews.apache.org/r/20636/diff/4/?file=568016#file568016line94>
> >
> >     I'm not a fan of baking in more thrift/RPC stuff into the rest of the code.
> >     
> >     This isn't serious, because Credentials is not public API (yet), but I'm opposed to it. I'd rather just inline these than modify Credentials.

are you -1 or -0?


- Sean


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20636/#review41382
-----------------------------------------------------------


On April 24, 2014, 8:54 p.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20636/
> -----------------------------------------------------------
> 
> (Updated April 24, 2014, 8:54 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2726
>     https://issues.apache.org/jira/browse/ACCUMULO-2726
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> restores things found missing by japi compliance checker
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/client/admin/ActiveCompaction.java 9c39ea6 
>   core/src/main/java/org/apache/accumulo/core/client/admin/ActiveScan.java 30e47af 
>   core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java f80eee5 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsHelper.java b9a7791 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java 569a3b6 
>   core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperationsImpl.java 9d662f4 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsHelper.java 843f572 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 3d69cc1 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ActiveCompactionImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ActiveScanImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ConnectorImpl.java 7d9d3ab 
>   core/src/main/java/org/apache/accumulo/core/client/impl/InstanceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsHelper.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/SecurityOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsHelper.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockConnector.java 996198c 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperations.java 15379af 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockNamespaceOperations.java 9f0594a 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperations.java 16a8e02 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockShell.java 2bc9436 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java d3b1571 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTabletLocator.java 6bd01a9 
>   core/src/main/java/org/apache/accumulo/core/security/Credentials.java 5afc6e8 
>   core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java 32136a8 
>   core/src/test/java/org/apache/accumulo/core/client/impl/TableOperationsHelperTest.java PRE-CREATION 
>   core/src/test/java/org/apache/accumulo/core/security/CredentialsTest.java 4f8079e 
>   server/base/src/main/java/org/apache/accumulo/server/security/SecurityOperation.java c2a7001 
>   server/master/src/main/java/org/apache/accumulo/master/FateServiceHandler.java d63a63e 
>   server/master/src/main/java/org/apache/accumulo/master/tableOps/ImportTable.java cd59b78 
>   test/compat/japi-compliance/japi-accumulo-1.5.xml 9e6f47f 
>   test/compat/japi-compliance/japi-accumulo-1.6.xml 36553b8 
> 
> Diff: https://reviews.apache.org/r/20636/diff/
> 
> 
> Testing
> -------
> 
> unit tests pass. ITs passed.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>

Re: Review Request 20636: ACCUMULO-2726 restore binary compatibility 1.5 -> 1.6

Posted by Christopher Tubbs <ct...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20636/#review41382
-----------------------------------------------------------



core/src/main/java/org/apache/accumulo/core/client/admin/ActiveCompaction.java
<https://reviews.apache.org/r/20636/#comment74801>

    Unused import



core/src/main/java/org/apache/accumulo/core/client/admin/ActiveScan.java
<https://reviews.apache.org/r/20636/#comment74802>

    Unused import



core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java
<https://reviews.apache.org/r/20636/#comment74803>

    Unused imports



core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperationsImpl.java
<https://reviews.apache.org/r/20636/#comment74805>

    Unused imports



core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsHelper.java
<https://reviews.apache.org/r/20636/#comment74822>

    For all these places, it seems like a stronger statement can be made. Such as "Do Not Use". Stating intent is one thing. Actually advising against using it is better.



core/src/main/java/org/apache/accumulo/core/client/impl/InstanceOperationsImpl.java
<https://reviews.apache.org/r/20636/#comment74807>

    Unused import



core/src/main/java/org/apache/accumulo/core/client/impl/InstanceOperationsImpl.java
<https://reviews.apache.org/r/20636/#comment74808>

    Unused import
    



core/src/main/java/org/apache/accumulo/core/client/impl/SecurityOperationsImpl.java
<https://reviews.apache.org/r/20636/#comment74809>

    Unused import



core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java
<https://reviews.apache.org/r/20636/#comment74810>

    Unused imports



core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java
<https://reviews.apache.org/r/20636/#comment74811>

    Unused Import



core/src/main/java/org/apache/accumulo/core/client/mock/MockTabletLocator.java
<https://reviews.apache.org/r/20636/#comment74823>

    Credentials isn't public API. We should not advise people use that. This whole class should be deprecated. Nobody should be using it.



core/src/main/java/org/apache/accumulo/core/security/Credentials.java
<https://reviews.apache.org/r/20636/#comment74818>

    I'm not a fan of baking in more thrift/RPC stuff into the rest of the code.
    
    This isn't serious, because Credentials is not public API (yet), but I'm opposed to it. I'd rather just inline these than modify Credentials.



core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java
<https://reviews.apache.org/r/20636/#comment74812>

    Unused import



core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java
<https://reviews.apache.org/r/20636/#comment74813>

    Unused import



core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java
<https://reviews.apache.org/r/20636/#comment74814>

    Unused imports



core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java
<https://reviews.apache.org/r/20636/#comment74815>

    missing @Override


- Christopher Tubbs


On April 24, 2014, 4:54 p.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20636/
> -----------------------------------------------------------
> 
> (Updated April 24, 2014, 4:54 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2726
>     https://issues.apache.org/jira/browse/ACCUMULO-2726
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> restores things found missing by japi compliance checker
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/client/admin/ActiveCompaction.java 9c39ea6 
>   core/src/main/java/org/apache/accumulo/core/client/admin/ActiveScan.java 30e47af 
>   core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java f80eee5 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsHelper.java b9a7791 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java 569a3b6 
>   core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperationsImpl.java 9d662f4 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsHelper.java 843f572 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 3d69cc1 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ActiveCompactionImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ActiveScanImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ConnectorImpl.java 7d9d3ab 
>   core/src/main/java/org/apache/accumulo/core/client/impl/InstanceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsHelper.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/SecurityOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsHelper.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockConnector.java 996198c 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperations.java 15379af 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockNamespaceOperations.java 9f0594a 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperations.java 16a8e02 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockShell.java 2bc9436 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java d3b1571 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTabletLocator.java 6bd01a9 
>   core/src/main/java/org/apache/accumulo/core/security/Credentials.java 5afc6e8 
>   core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java 32136a8 
>   core/src/test/java/org/apache/accumulo/core/client/impl/TableOperationsHelperTest.java PRE-CREATION 
>   core/src/test/java/org/apache/accumulo/core/security/CredentialsTest.java 4f8079e 
>   server/base/src/main/java/org/apache/accumulo/server/security/SecurityOperation.java c2a7001 
>   server/master/src/main/java/org/apache/accumulo/master/FateServiceHandler.java d63a63e 
>   server/master/src/main/java/org/apache/accumulo/master/tableOps/ImportTable.java cd59b78 
>   test/compat/japi-compliance/japi-accumulo-1.5.xml 9e6f47f 
>   test/compat/japi-compliance/japi-accumulo-1.6.xml 36553b8 
> 
> Diff: https://reviews.apache.org/r/20636/diff/
> 
> 
> Testing
> -------
> 
> unit tests pass. ITs passed.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>

Re: Review Request 20636: ACCUMULO-2726 restore binary compatibility 1.5 -> 1.6

Posted by ke...@deenlo.com.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20636/#review41480
-----------------------------------------------------------

Ship it!


Ship It!

- kturner


On April 25, 2014, 4:28 p.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20636/
> -----------------------------------------------------------
> 
> (Updated April 25, 2014, 4:28 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2726
>     https://issues.apache.org/jira/browse/ACCUMULO-2726
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> restores things found missing by japi compliance checker
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/client/admin/ActiveCompaction.java 9c39ea6 
>   core/src/main/java/org/apache/accumulo/core/client/admin/ActiveScan.java 30e47af 
>   core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java f80eee5 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsHelper.java b9a7791 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java 569a3b6 
>   core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperationsImpl.java 9d662f4 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsHelper.java 843f572 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 3d69cc1 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ActiveCompactionImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ActiveScanImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ConnectorImpl.java 7d9d3ab 
>   core/src/main/java/org/apache/accumulo/core/client/impl/InstanceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsHelper.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/SecurityOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsHelper.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/impl/InputConfigurator.java cfd9aa2 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockConnector.java 996198c 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperations.java 15379af 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockNamespaceOperations.java 9f0594a 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperations.java 16a8e02 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockShell.java 2bc9436 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java d3b1571 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTabletLocator.java 6bd01a9 
>   core/src/main/java/org/apache/accumulo/core/client/mock/impl/MockTabletLocator.java PRE-CREATION 
>   core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java 32136a8 
>   core/src/test/java/org/apache/accumulo/core/client/impl/TableOperationsHelperTest.java PRE-CREATION 
>   server/base/src/main/java/org/apache/accumulo/server/security/SecurityOperation.java c2a7001 
>   server/master/src/main/java/org/apache/accumulo/master/FateServiceHandler.java d63a63e 
>   server/master/src/main/java/org/apache/accumulo/master/tableOps/ImportTable.java cd59b78 
>   test/compat/japi-compliance/japi-accumulo-1.5.xml 9e6f47f 
>   test/compat/japi-compliance/japi-accumulo-1.6.xml 36553b8 
> 
> Diff: https://reviews.apache.org/r/20636/diff/
> 
> 
> Testing
> -------
> 
> unit tests pass. ITs passed.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>

Re: Review Request 20636: ACCUMULO-2726 restore binary compatibility 1.5 -> 1.6

Posted by Sean Busbey <se...@manvsbeard.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20636/
-----------------------------------------------------------

(Updated April 25, 2014, 4:28 p.m.)


Review request for accumulo.


Changes
-------

incorporate more feedback from kturner and ctubbsii via IRC


Bugs: ACCUMULO-2726
    https://issues.apache.org/jira/browse/ACCUMULO-2726


Repository: accumulo


Description
-------

restores things found missing by japi compliance checker


Diffs (updated)
-----

  core/src/main/java/org/apache/accumulo/core/client/admin/ActiveCompaction.java 9c39ea6 
  core/src/main/java/org/apache/accumulo/core/client/admin/ActiveScan.java 30e47af 
  core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java f80eee5 
  core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsHelper.java b9a7791 
  core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java 569a3b6 
  core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperationsImpl.java 9d662f4 
  core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsHelper.java 843f572 
  core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 3d69cc1 
  core/src/main/java/org/apache/accumulo/core/client/impl/ActiveCompactionImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/impl/ActiveScanImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/impl/ConnectorImpl.java 7d9d3ab 
  core/src/main/java/org/apache/accumulo/core/client/impl/InstanceOperationsImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsHelper.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/impl/SecurityOperationsImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsHelper.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/impl/InputConfigurator.java cfd9aa2 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockConnector.java 996198c 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperations.java 15379af 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperationsImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockNamespaceOperations.java 9f0594a 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperations.java 16a8e02 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperationsImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockShell.java 2bc9436 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java d3b1571 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperationsImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockTabletLocator.java 6bd01a9 
  core/src/main/java/org/apache/accumulo/core/client/mock/impl/MockTabletLocator.java PRE-CREATION 
  core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java 32136a8 
  core/src/test/java/org/apache/accumulo/core/client/impl/TableOperationsHelperTest.java PRE-CREATION 
  server/base/src/main/java/org/apache/accumulo/server/security/SecurityOperation.java c2a7001 
  server/master/src/main/java/org/apache/accumulo/master/FateServiceHandler.java d63a63e 
  server/master/src/main/java/org/apache/accumulo/master/tableOps/ImportTable.java cd59b78 
  test/compat/japi-compliance/japi-accumulo-1.5.xml 9e6f47f 
  test/compat/japi-compliance/japi-accumulo-1.6.xml 36553b8 

Diff: https://reviews.apache.org/r/20636/diff/


Testing
-------

unit tests pass. ITs passed.


Thanks,

Sean Busbey

Re: Review Request 20636: ACCUMULO-2726 restore binary compatibility 1.5 -> 1.6

Posted by Sean Busbey <se...@manvsbeard.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20636/
-----------------------------------------------------------

(Updated April 25, 2014, 3:48 p.m.)


Review request for accumulo.


Changes
-------

rebased onto latest 1.6.0-SNAPSHOT.

(looks like "compare revisions" for 6 and 7 doesn't work correctly, shows the changes from ACCUMULO-2733.)


Bugs: ACCUMULO-2726
    https://issues.apache.org/jira/browse/ACCUMULO-2726


Repository: accumulo


Description
-------

restores things found missing by japi compliance checker


Diffs (updated)
-----

  core/src/main/java/org/apache/accumulo/core/client/admin/ActiveCompaction.java 9c39ea6 
  core/src/main/java/org/apache/accumulo/core/client/admin/ActiveScan.java 30e47af 
  core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java f80eee5 
  core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsHelper.java b9a7791 
  core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java 569a3b6 
  core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperationsImpl.java 9d662f4 
  core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsHelper.java 843f572 
  core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 3d69cc1 
  core/src/main/java/org/apache/accumulo/core/client/impl/ActiveCompactionImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/impl/ActiveScanImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/impl/ConnectorImpl.java 7d9d3ab 
  core/src/main/java/org/apache/accumulo/core/client/impl/InstanceOperationsImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsHelper.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/impl/SecurityOperationsImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsHelper.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/impl/InputConfigurator.java cfd9aa2 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockConnector.java 996198c 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperations.java 15379af 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperationsImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockNamespaceOperations.java 9f0594a 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperations.java 16a8e02 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperationsImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockShell.java 2bc9436 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java d3b1571 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperationsImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockTabletLocator.java 6bd01a9 
  core/src/main/java/org/apache/accumulo/core/client/mock/impl/MockTabletLocator.java PRE-CREATION 
  core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java 32136a8 
  core/src/test/java/org/apache/accumulo/core/client/impl/TableOperationsHelperTest.java PRE-CREATION 
  server/base/src/main/java/org/apache/accumulo/server/security/SecurityOperation.java c2a7001 
  server/master/src/main/java/org/apache/accumulo/master/FateServiceHandler.java d63a63e 
  server/master/src/main/java/org/apache/accumulo/master/tableOps/ImportTable.java cd59b78 
  test/compat/japi-compliance/japi-accumulo-1.5.xml 9e6f47f 
  test/compat/japi-compliance/japi-accumulo-1.6.xml 36553b8 

Diff: https://reviews.apache.org/r/20636/diff/


Testing
-------

unit tests pass. ITs passed.


Thanks,

Sean Busbey

Re: Review Request 20636: ACCUMULO-2726 restore binary compatibility 1.5 -> 1.6

Posted by Sean Busbey <se...@manvsbeard.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20636/
-----------------------------------------------------------

(Updated April 25, 2014, 7:19 a.m.)


Review request for accumulo.


Changes
-------

cleaned up whitespace, unused imports, annotations, and tags. made warnings around things that weren't supposed to be public api stronger. moved more out of public api.

ACCUMULO-2733 consolidates manual deserializations into a fromThrift call per discussion on IRC. If that ticket gets +1ed before this one does, I'll refactor this patch to be based on that one.


Bugs: ACCUMULO-2726
    https://issues.apache.org/jira/browse/ACCUMULO-2726


Repository: accumulo


Description
-------

restores things found missing by japi compliance checker


Diffs (updated)
-----

  core/src/main/java/org/apache/accumulo/core/client/admin/ActiveCompaction.java 9c39ea6 
  core/src/main/java/org/apache/accumulo/core/client/admin/ActiveScan.java 30e47af 
  core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java f80eee5 
  core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsHelper.java b9a7791 
  core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java 569a3b6 
  core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperationsImpl.java 9d662f4 
  core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsHelper.java 843f572 
  core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 3d69cc1 
  core/src/main/java/org/apache/accumulo/core/client/impl/ActiveCompactionImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/impl/ActiveScanImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/impl/ConnectorImpl.java 7d9d3ab 
  core/src/main/java/org/apache/accumulo/core/client/impl/InstanceOperationsImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsHelper.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/impl/SecurityOperationsImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsHelper.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/impl/InputConfigurator.java cfd9aa2 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockConnector.java 996198c 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperations.java 15379af 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperationsImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockNamespaceOperations.java 9f0594a 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperations.java 16a8e02 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperationsImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockShell.java 2bc9436 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java d3b1571 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperationsImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockTabletLocator.java 6bd01a9 
  core/src/main/java/org/apache/accumulo/core/client/mock/impl/MockTabletLocator.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/security/Credentials.java 5afc6e8 
  core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java 32136a8 
  core/src/test/java/org/apache/accumulo/core/client/impl/TableOperationsHelperTest.java PRE-CREATION 
  core/src/test/java/org/apache/accumulo/core/security/CredentialsTest.java 4f8079e 
  server/base/src/main/java/org/apache/accumulo/server/security/SecurityOperation.java c2a7001 
  server/master/src/main/java/org/apache/accumulo/master/FateServiceHandler.java d63a63e 
  server/master/src/main/java/org/apache/accumulo/master/tableOps/ImportTable.java cd59b78 
  test/compat/japi-compliance/japi-accumulo-1.5.xml 9e6f47f 
  test/compat/japi-compliance/japi-accumulo-1.6.xml 36553b8 

Diff: https://reviews.apache.org/r/20636/diff/


Testing
-------

unit tests pass. ITs passed.


Thanks,

Sean Busbey

Re: Review Request 20636: ACCUMULO-2726 restore binary compatibility 1.5 -> 1.6

Posted by Sean Busbey <se...@manvsbeard.com>.


> On April 24, 2014, 10:14 p.m., Christopher Tubbs wrote:
> > core/src/main/java/org/apache/accumulo/core/client/mock/MockShell.java, line 62
> > <https://reviews.apache.org/r/20636/diff/5/?file=568074#file568074line62>
> >
> >     This should use Constants.UTF8.name() (StandardCharsets.UTF_8.name() for merge to master)

missed specifying a charset at all on the setWriter method!


- Sean


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20636/#review41403
-----------------------------------------------------------


On April 24, 2014, 8:54 p.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20636/
> -----------------------------------------------------------
> 
> (Updated April 24, 2014, 8:54 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2726
>     https://issues.apache.org/jira/browse/ACCUMULO-2726
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> restores things found missing by japi compliance checker
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/client/admin/ActiveCompaction.java 9c39ea6 
>   core/src/main/java/org/apache/accumulo/core/client/admin/ActiveScan.java 30e47af 
>   core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java f80eee5 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsHelper.java b9a7791 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java 569a3b6 
>   core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperationsImpl.java 9d662f4 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsHelper.java 843f572 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 3d69cc1 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ActiveCompactionImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ActiveScanImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ConnectorImpl.java 7d9d3ab 
>   core/src/main/java/org/apache/accumulo/core/client/impl/InstanceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsHelper.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/SecurityOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsHelper.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockConnector.java 996198c 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperations.java 15379af 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockNamespaceOperations.java 9f0594a 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperations.java 16a8e02 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockShell.java 2bc9436 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java d3b1571 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTabletLocator.java 6bd01a9 
>   core/src/main/java/org/apache/accumulo/core/security/Credentials.java 5afc6e8 
>   core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java 32136a8 
>   core/src/test/java/org/apache/accumulo/core/client/impl/TableOperationsHelperTest.java PRE-CREATION 
>   core/src/test/java/org/apache/accumulo/core/security/CredentialsTest.java 4f8079e 
>   server/base/src/main/java/org/apache/accumulo/server/security/SecurityOperation.java c2a7001 
>   server/master/src/main/java/org/apache/accumulo/master/FateServiceHandler.java d63a63e 
>   server/master/src/main/java/org/apache/accumulo/master/tableOps/ImportTable.java cd59b78 
>   test/compat/japi-compliance/japi-accumulo-1.5.xml 9e6f47f 
>   test/compat/japi-compliance/japi-accumulo-1.6.xml 36553b8 
> 
> Diff: https://reviews.apache.org/r/20636/diff/
> 
> 
> Testing
> -------
> 
> unit tests pass. ITs passed.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>

Re: Review Request 20636: ACCUMULO-2726 restore binary compatibility 1.5 -> 1.6

Posted by Christopher Tubbs <ct...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20636/#review41403
-----------------------------------------------------------



core/src/main/java/org/apache/accumulo/core/client/mock/MockShell.java
<https://reviews.apache.org/r/20636/#comment74838>

    This should use Constants.UTF8.name() (StandardCharsets.UTF_8.name() for merge to master)


- Christopher Tubbs


On April 24, 2014, 4:54 p.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20636/
> -----------------------------------------------------------
> 
> (Updated April 24, 2014, 4:54 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2726
>     https://issues.apache.org/jira/browse/ACCUMULO-2726
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> restores things found missing by japi compliance checker
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/client/admin/ActiveCompaction.java 9c39ea6 
>   core/src/main/java/org/apache/accumulo/core/client/admin/ActiveScan.java 30e47af 
>   core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java f80eee5 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsHelper.java b9a7791 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java 569a3b6 
>   core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperationsImpl.java 9d662f4 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsHelper.java 843f572 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 3d69cc1 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ActiveCompactionImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ActiveScanImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ConnectorImpl.java 7d9d3ab 
>   core/src/main/java/org/apache/accumulo/core/client/impl/InstanceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsHelper.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/SecurityOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsHelper.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockConnector.java 996198c 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperations.java 15379af 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockNamespaceOperations.java 9f0594a 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperations.java 16a8e02 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockShell.java 2bc9436 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java d3b1571 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperationsImpl.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTabletLocator.java 6bd01a9 
>   core/src/main/java/org/apache/accumulo/core/security/Credentials.java 5afc6e8 
>   core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java 32136a8 
>   core/src/test/java/org/apache/accumulo/core/client/impl/TableOperationsHelperTest.java PRE-CREATION 
>   core/src/test/java/org/apache/accumulo/core/security/CredentialsTest.java 4f8079e 
>   server/base/src/main/java/org/apache/accumulo/server/security/SecurityOperation.java c2a7001 
>   server/master/src/main/java/org/apache/accumulo/master/FateServiceHandler.java d63a63e 
>   server/master/src/main/java/org/apache/accumulo/master/tableOps/ImportTable.java cd59b78 
>   test/compat/japi-compliance/japi-accumulo-1.5.xml 9e6f47f 
>   test/compat/japi-compliance/japi-accumulo-1.6.xml 36553b8 
> 
> Diff: https://reviews.apache.org/r/20636/diff/
> 
> 
> Testing
> -------
> 
> unit tests pass. ITs passed.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>

Re: Review Request 20636: ACCUMULO-2726 restore binary compatibility 1.5 -> 1.6

Posted by Sean Busbey <se...@manvsbeard.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20636/
-----------------------------------------------------------

(Updated April 24, 2014, 8:54 p.m.)


Review request for accumulo.


Bugs: ACCUMULO-2726
    https://issues.apache.org/jira/browse/ACCUMULO-2726


Repository: accumulo


Description
-------

restores things found missing by japi compliance checker


Diffs
-----

  core/src/main/java/org/apache/accumulo/core/client/admin/ActiveCompaction.java 9c39ea6 
  core/src/main/java/org/apache/accumulo/core/client/admin/ActiveScan.java 30e47af 
  core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java f80eee5 
  core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsHelper.java b9a7791 
  core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java 569a3b6 
  core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperationsImpl.java 9d662f4 
  core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsHelper.java 843f572 
  core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 3d69cc1 
  core/src/main/java/org/apache/accumulo/core/client/impl/ActiveCompactionImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/impl/ActiveScanImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/impl/ConnectorImpl.java 7d9d3ab 
  core/src/main/java/org/apache/accumulo/core/client/impl/InstanceOperationsImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsHelper.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/impl/SecurityOperationsImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsHelper.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockConnector.java 996198c 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperations.java 15379af 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperationsImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockNamespaceOperations.java 9f0594a 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperations.java 16a8e02 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperationsImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockShell.java 2bc9436 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java d3b1571 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperationsImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockTabletLocator.java 6bd01a9 
  core/src/main/java/org/apache/accumulo/core/security/Credentials.java 5afc6e8 
  core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java 32136a8 
  core/src/test/java/org/apache/accumulo/core/client/impl/TableOperationsHelperTest.java PRE-CREATION 
  core/src/test/java/org/apache/accumulo/core/security/CredentialsTest.java 4f8079e 
  server/base/src/main/java/org/apache/accumulo/server/security/SecurityOperation.java c2a7001 
  server/master/src/main/java/org/apache/accumulo/master/FateServiceHandler.java d63a63e 
  server/master/src/main/java/org/apache/accumulo/master/tableOps/ImportTable.java cd59b78 
  test/compat/japi-compliance/japi-accumulo-1.5.xml 9e6f47f 
  test/compat/japi-compliance/japi-accumulo-1.6.xml 36553b8 

Diff: https://reviews.apache.org/r/20636/diff/


Testing
-------

unit tests pass. ITs passed.


Thanks,

Sean Busbey

Re: Review Request 20636: ACCUMULO-2726 restore binary compatibility 1.5 -> 1.6

Posted by Sean Busbey <se...@manvsbeard.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20636/
-----------------------------------------------------------

(Updated April 24, 2014, 8:54 p.m.)


Review request for accumulo.


Changes
-------

missed making one of the mock Impls package-private


Bugs: ACCUMULO-2726
    https://issues.apache.org/jira/browse/ACCUMULO-2726


Repository: accumulo


Description
-------

restores things found missing by japi compliance checker


Diffs (updated)
-----

  core/src/main/java/org/apache/accumulo/core/client/admin/ActiveCompaction.java 9c39ea6 
  core/src/main/java/org/apache/accumulo/core/client/admin/ActiveScan.java 30e47af 
  core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java f80eee5 
  core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsHelper.java b9a7791 
  core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java 569a3b6 
  core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperationsImpl.java 9d662f4 
  core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsHelper.java 843f572 
  core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 3d69cc1 
  core/src/main/java/org/apache/accumulo/core/client/impl/ActiveCompactionImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/impl/ActiveScanImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/impl/ConnectorImpl.java 7d9d3ab 
  core/src/main/java/org/apache/accumulo/core/client/impl/InstanceOperationsImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsHelper.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/impl/SecurityOperationsImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsHelper.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockConnector.java 996198c 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperations.java 15379af 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperationsImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockNamespaceOperations.java 9f0594a 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperations.java 16a8e02 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperationsImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockShell.java 2bc9436 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java d3b1571 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperationsImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockTabletLocator.java 6bd01a9 
  core/src/main/java/org/apache/accumulo/core/security/Credentials.java 5afc6e8 
  core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java 32136a8 
  core/src/test/java/org/apache/accumulo/core/client/impl/TableOperationsHelperTest.java PRE-CREATION 
  core/src/test/java/org/apache/accumulo/core/security/CredentialsTest.java 4f8079e 
  server/base/src/main/java/org/apache/accumulo/server/security/SecurityOperation.java c2a7001 
  server/master/src/main/java/org/apache/accumulo/master/FateServiceHandler.java d63a63e 
  server/master/src/main/java/org/apache/accumulo/master/tableOps/ImportTable.java cd59b78 
  test/compat/japi-compliance/japi-accumulo-1.5.xml 9e6f47f 
  test/compat/japi-compliance/japi-accumulo-1.6.xml 36553b8 

Diff: https://reviews.apache.org/r/20636/diff/


Testing
-------

unit tests pass. ITs passed.


Thanks,

Sean Busbey

Re: Review Request 20636: ACCUMULO-2726 restore binary compatibility 1.5 -> 1.6

Posted by Sean Busbey <se...@manvsbeard.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20636/
-----------------------------------------------------------

(Updated April 24, 2014, 7:59 p.m.)


Review request for accumulo.


Changes
-------

refactored to make sure things we use internally can be used without suppressing deprecation warnings.

there's still one deprecation warning on the test for one of the deprecated classes. the suppress warnings annotation doesn't appear to be working.


Bugs: ACCUMULO-2726
    https://issues.apache.org/jira/browse/ACCUMULO-2726


Repository: accumulo


Description
-------

restores things found missing by japi compliance checker


Diffs (updated)
-----

  core/src/main/java/org/apache/accumulo/core/client/admin/ActiveCompaction.java 9c39ea6 
  core/src/main/java/org/apache/accumulo/core/client/admin/ActiveScan.java 30e47af 
  core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java f80eee5 
  core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsHelper.java b9a7791 
  core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java 569a3b6 
  core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperationsImpl.java 9d662f4 
  core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsHelper.java 843f572 
  core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 3d69cc1 
  core/src/main/java/org/apache/accumulo/core/client/impl/ActiveCompactionImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/impl/ActiveScanImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/impl/ConnectorImpl.java 7d9d3ab 
  core/src/main/java/org/apache/accumulo/core/client/impl/InstanceOperationsImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsHelper.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/impl/SecurityOperationsImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsHelper.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockConnector.java 996198c 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperations.java 15379af 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperationsImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockNamespaceOperations.java 9f0594a 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperations.java 16a8e02 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperationsImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockShell.java 2bc9436 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java d3b1571 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperationsImpl.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockTabletLocator.java 6bd01a9 
  core/src/main/java/org/apache/accumulo/core/security/Credentials.java 5afc6e8 
  core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java 32136a8 
  core/src/test/java/org/apache/accumulo/core/client/impl/TableOperationsHelperTest.java PRE-CREATION 
  core/src/test/java/org/apache/accumulo/core/security/CredentialsTest.java 4f8079e 
  server/base/src/main/java/org/apache/accumulo/server/security/SecurityOperation.java c2a7001 
  server/master/src/main/java/org/apache/accumulo/master/FateServiceHandler.java d63a63e 
  server/master/src/main/java/org/apache/accumulo/master/tableOps/ImportTable.java cd59b78 
  test/compat/japi-compliance/japi-accumulo-1.5.xml 9e6f47f 
  test/compat/japi-compliance/japi-accumulo-1.6.xml 36553b8 

Diff: https://reviews.apache.org/r/20636/diff/


Testing
-------

unit tests pass. ITs passed.


Thanks,

Sean Busbey

Re: Review Request 20636: ACCUMULO-2726 restore binary compatibility 1.5 -> 1.6

Posted by Sean Busbey <se...@manvsbeard.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20636/
-----------------------------------------------------------

(Updated April 24, 2014, 7:34 a.m.)


Review request for accumulo.


Changes
-------

cleaned up compiler warnings.


Bugs: ACCUMULO-2726
    https://issues.apache.org/jira/browse/ACCUMULO-2726


Repository: accumulo


Description
-------

restores things found missing by japi compliance checker


Diffs (updated)
-----

  core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java f80eee5 
  core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsHelper.java b9a7791 
  core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java 569a3b6 
  core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperationsImpl.java 9d662f4 
  core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsHelper.java 843f572 
  core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 3d69cc1 
  core/src/main/java/org/apache/accumulo/core/client/impl/ConnectorImpl.java 7d9d3ab 
  core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsHelper.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/impl/InputConfigurator.java cfd9aa2 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockConnector.java 996198c 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperations.java 15379af 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockNamespaceOperations.java 9f0594a 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperations.java 16a8e02 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockShell.java 2bc9436 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java d3b1571 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockTabletLocator.java 6bd01a9 
  core/src/main/java/org/apache/accumulo/core/security/Credentials.java 5afc6e8 
  core/src/test/java/org/apache/accumulo/core/security/CredentialsTest.java 4f8079e 
  test/compat/japi-compliance/japi-accumulo-1.5.xml 9e6f47f 
  test/compat/japi-compliance/japi-accumulo-1.6.xml 36553b8 

Diff: https://reviews.apache.org/r/20636/diff/


Testing (updated)
-------

unit tests pass. ITs passed.


Thanks,

Sean Busbey

Re: Review Request 20636: ACCUMULO-2726 restore binary compatibility 1.5 -> 1.6

Posted by Sean Busbey <se...@manvsbeard.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20636/
-----------------------------------------------------------

(Updated April 24, 2014, 4:21 a.m.)


Review request for accumulo.


Changes
-------

moved a few would-be-new-and-deprecated classes out of the public api. updated the japi compliance config to ignore additional impl packages and not mock.


Bugs: ACCUMULO-2726
    https://issues.apache.org/jira/browse/ACCUMULO-2726


Repository: accumulo


Description
-------

restores things found missing by japi compliance checker


Diffs (updated)
-----

  core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java f80eee5 
  core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsHelper.java b9a7791 
  core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java 569a3b6 
  core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperationsImpl.java 9d662f4 
  core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsHelper.java 843f572 
  core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 3d69cc1 
  core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsHelper.java PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperations.java 15379af 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockNamespaceOperations.java 9f0594a 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperations.java 16a8e02 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockShell.java 2bc9436 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java d3b1571 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockTabletLocator.java 6bd01a9 
  core/src/main/java/org/apache/accumulo/core/security/Credentials.java 5afc6e8 
  core/src/test/java/org/apache/accumulo/core/security/CredentialsTest.java 4f8079e 
  test/compat/japi-compliance/japi-accumulo-1.5.xml 9e6f47f 
  test/compat/japi-compliance/japi-accumulo-1.6.xml 36553b8 

Diff: https://reviews.apache.org/r/20636/diff/


Testing (updated)
-------

unit tests pass. ITs passed. (checking style warnings now)


Thanks,

Sean Busbey