You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/09/03 16:18:16 UTC
[GitHub] [maven-shade-plugin] tisonkun opened a new pull request, #150: [MSHADE-425] Relocate services name before add to serviceEntries
tisonkun opened a new pull request, #150:
URL: https://github.com/apache/maven-shade-plugin/pull/150
Signed-off-by: tison <wa...@gmail.com>
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MSHADE) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[MSHADE-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MSHADE-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shade-plugin] slawekjaranowski commented on pull request #150: [MSHADE-425] Relocate services name before add to serviceEntries
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #150:
URL: https://github.com/apache/maven-shade-plugin/pull/150#issuecomment-1236609841
I don't investigate deeper - only mention about missing test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shade-plugin] tisonkun commented on pull request #150: [MSHADE-425] Relocate services name before add to serviceEntries
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #150:
URL: https://github.com/apache/maven-shade-plugin/pull/150#issuecomment-1236968426
@rmannibucau @slawekjaranowski I may a bit in a hurry but I'd like to know whether/when we can have a release for this fix. It resolves one or several downstream use case and I'm willing to upgrade for this fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shade-plugin] rmannibucau commented on pull request #150: [MSHADE-425] Relocate services name before add to serviceEntries
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on PR #150:
URL: https://github.com/apache/maven-shade-plugin/pull/150#issuecomment-1237057442
@slawekjaranowski nop, only a PMC can achieve it (for goods) so if a commiter can start it he can't end it so always better to ensure some PMC is there to handle all the needed steps before starting by XP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shade-plugin] slawekjaranowski commented on a diff in pull request #150: [MSHADE-425] Relocate services name before add to serviceEntries
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #150:
URL: https://github.com/apache/maven-shade-plugin/pull/150#discussion_r962576368
##########
src/test/java/org/apache/maven/plugins/shade/resource/ServiceResourceTransformerTest.java:
##########
@@ -85,6 +85,49 @@ public void relocatedClasses() throws Exception {
tempJar.delete();
}
}
+
+ @Test
+ public void mergeRelocatedFiles() throws Exception {
+ SimpleRelocator relocator =
+ new SimpleRelocator( "org.foo", "borg.foo", null, Arrays.asList( "org.foo.exclude.*" ) );
+ relocators.add( relocator );
+
+ String content = "org.foo.Service\norg.foo.exclude.OtherService\n";
Review Comment:
Why not use constant `NEWLINE` as is used later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shade-plugin] tisonkun commented on pull request #150: [MSHADE-425] Relocate services name before add to serviceEntries
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #150:
URL: https://github.com/apache/maven-shade-plugin/pull/150#issuecomment-1236162650
cc @khmarbaise @rmannibucau
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shade-plugin] tisonkun commented on pull request #150: [MSHADE-425] Relocate services name before add to serviceEntries
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #150:
URL: https://github.com/apache/maven-shade-plugin/pull/150#issuecomment-1236725899
@rmannibucau @slawekjaranowski do we still wait for other conditions to merge this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shade-plugin] slawekjaranowski merged pull request #150: [MSHADE-425] Relocate services name before add to serviceEntries
Posted by GitBox <gi...@apache.org>.
slawekjaranowski merged PR #150:
URL: https://github.com/apache/maven-shade-plugin/pull/150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shade-plugin] slawekjaranowski commented on pull request #150: [MSHADE-425] Relocate services name before add to serviceEntries
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #150:
URL: https://github.com/apache/maven-shade-plugin/pull/150#issuecomment-1237182567
m-pmd-p -> maven-pmd-plugin 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shade-plugin] tisonkun commented on a diff in pull request #150: [MSHADE-425] Relocate services name before add to serviceEntries
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #150:
URL: https://github.com/apache/maven-shade-plugin/pull/150#discussion_r962580071
##########
src/test/java/org/apache/maven/plugins/shade/resource/ServiceResourceTransformerTest.java:
##########
@@ -85,6 +85,49 @@ public void relocatedClasses() throws Exception {
tempJar.delete();
}
}
+
+ @Test
+ public void mergeRelocatedFiles() throws Exception {
+ SimpleRelocator relocator =
+ new SimpleRelocator( "org.foo", "borg.foo", null, Arrays.asList( "org.foo.exclude.*" ) );
+ relocators.add( relocator );
+
+ String content = "org.foo.Service\norg.foo.exclude.OtherService\n";
Review Comment:
Resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shade-plugin] slawekjaranowski commented on pull request #150: [MSHADE-425] Relocate services name before add to serviceEntries
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #150:
URL: https://github.com/apache/maven-shade-plugin/pull/150#issuecomment-1237031901
drop a line on dev list is good idea
@rmannibucau each committer has enough karma/privileges for releases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shade-plugin] slawekjaranowski commented on pull request #150: [MSHADE-425] Relocate services name before add to serviceEntries
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #150:
URL: https://github.com/apache/maven-shade-plugin/pull/150#issuecomment-1236607084
@tisonkun Thanks for your PR.
We need a unit test to be sure that next change don't break it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shade-plugin] rmannibucau commented on pull request #150: [MSHADE-425] Relocate services name before add to serviceEntries
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on PR #150:
URL: https://github.com/apache/maven-shade-plugin/pull/150#issuecomment-1237021750
@tisonkun guess a mail on the mailing list can make people more aware of it (at least the ones with the full karma to do it ;))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shade-plugin] rmannibucau commented on pull request #150: [MSHADE-425] Relocate services name before add to serviceEntries
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on PR #150:
URL: https://github.com/apache/maven-shade-plugin/pull/150#issuecomment-1236740264
@tisonkun on my side I was just waiting for @slawekjaranowski to ack (or merge, no issue) but otherwise no blocker for this pr for me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shade-plugin] tisonkun commented on pull request #150: [MSHADE-425] Relocate services name before add to serviceEntries
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #150:
URL: https://github.com/apache/maven-shade-plugin/pull/150#issuecomment-1236608636
@slawekjaranowski Yes. I ever thought of this. Let me try to dig out how to add one. Or could you show me some related tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shade-plugin] tisonkun commented on pull request #150: [MSHADE-425] Relocate services name before add to serviceEntries
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #150:
URL: https://github.com/apache/maven-shade-plugin/pull/150#issuecomment-1237143519
Thanks! I'm subscribing dev@maven.apache.org mailing list now.
> m-pmd-p
Out of curiosity, what does this stand for?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shade-plugin] tisonkun commented on a diff in pull request #150: [MSHADE-425] Relocate services name before add to serviceEntries
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #150:
URL: https://github.com/apache/maven-shade-plugin/pull/150#discussion_r962577433
##########
src/test/java/org/apache/maven/plugins/shade/resource/ServiceResourceTransformerTest.java:
##########
@@ -85,6 +85,49 @@ public void relocatedClasses() throws Exception {
tempJar.delete();
}
}
+
+ @Test
+ public void mergeRelocatedFiles() throws Exception {
+ SimpleRelocator relocator =
+ new SimpleRelocator( "org.foo", "borg.foo", null, Arrays.asList( "org.foo.exclude.*" ) );
+ relocators.add( relocator );
+
+ String content = "org.foo.Service\norg.foo.exclude.OtherService\n";
Review Comment:
Make sense. I just copy from the test above. Code refactoring can be another topic that I don't mess up one PR. But it's fair enough for new code :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shade-plugin] slawekjaranowski commented on pull request #150: [MSHADE-425] Relocate services name before add to serviceEntries
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #150:
URL: https://github.com/apache/maven-shade-plugin/pull/150#issuecomment-1237138580
if you wish we can discuss on dev list
look last pending release of m-pmd-p
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shade-plugin] tisonkun commented on pull request #150: [MSHADE-425] Relocate services name before add to serviceEntries
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #150:
URL: https://github.com/apache/maven-shade-plugin/pull/150#issuecomment-1236749411
Squashed.
Though, you can use GitHub "Squash and Commit" button to perform the squash, so that we don't need one more CI turn.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shade-plugin] slawekjaranowski commented on pull request #150: [MSHADE-425] Relocate services name before add to serviceEntries
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #150:
URL: https://github.com/apache/maven-shade-plugin/pull/150#issuecomment-1236745915
you can squash to one final commit and will be ok for me also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shade-plugin] slawekjaranowski commented on pull request #150: [MSHADE-425] Relocate services name before add to serviceEntries
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #150:
URL: https://github.com/apache/maven-shade-plugin/pull/150#issuecomment-1236612996
There is a https://github.com/apache/maven-shade-plugin/blob/master/src/test/java/org/apache/maven/plugins/shade/resource/ServiceResourceTransformerTest.java
maybe tests don't cover all path - you change something in class but tests still works without change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shade-plugin] tisonkun commented on pull request #150: [MSHADE-425] Relocate services name before add to serviceEntries
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #150:
URL: https://github.com/apache/maven-shade-plugin/pull/150#issuecomment-1236617125
@slawekjaranowski Yes. I would say this patch is simple enough to be correct. But I'm glad to add some tests to prevent regressions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shade-plugin] tisonkun commented on pull request #150: [MSHADE-425] Relocate services name before add to serviceEntries
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #150:
URL: https://github.com/apache/maven-shade-plugin/pull/150#issuecomment-1236624546
@slawekjaranowski Added at d29c633cea770ef59464e0b523a938bcd7590c50. Also verify locally that without this patch the test failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org