[GitHub] [hadoop] tomscut commented on a change in pull request #3629: HDFS-16305.Record the remote NameNode address when the rolling log is triggered.

[GitBox <gi...@apache.org>]

tomscut commented on a change in pull request #3629:
URL: https://github.com/apache/hadoop/pull/3629#discussion_r746167436



##########
File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/EditLogTailer.java
##########
@@ -413,6 +413,8 @@ private boolean tooLongSinceLastLoad() {
     return new MultipleNameNodeProxy<Void>() {
       @Override
       protected Void doWork() throws IOException {
+        LOG.info("Triggering log scrolling to the remote NameNode, " +

Review comment:
       The log already exists on line `427`: `LOG.info("Triggering log roll on remote NameNode");`. 
   Should we remove the original log?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org