[jira] [Commented] (OFBIZ-7754) The big problem when load seed.

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15423885#comment-15423885 ] 

Jacques Le Roux commented on OFBIZ-7754:
----------------------------------------

I thought about it and after a face to face discussion with Taher, Nicolas and Gil in Paris 10 days ago, I see the problems otherwise and believe Hans has somehow a point here.

Actually we have to think otherwise. Taher suggested that in properties there is actually 2 types: data and properties. I'd suggest that we can identify what Taher called data by asking ourselves if a property is specific to a tenant or is generic and should stay either in a property file or on the master DB.

Since the master DB makes only sense when using tenants, I believe we should 1st separate properties, keep generic ones in properties files and put others in DB.

For instance in general properties file we have both types so it does not make sense to address the issue by looking at it as a lot. Let's check it. Which general properties not are tenant specific?
{code}
# -- unique instance id (20 char max)
unique.instanceId=ofbiz1

# -- Y if you want to display the multi-tenant textbox in the login page and install specify components which related to each tenant
multitenant=N
{code}

See, things are already clearer. Only those properties should stay in general properties. The nice thing with this way of separating things is it's really easy. You dont' have to blow your mind, just ask yourself if it's specific to a tenant or not. So in this case, the others "properties" should be only in DB (being master, of tenants if needed)

What do you think? Should we tackle it this way using this issue or should we for now simply apply Pierre's last patch and create a new Jira issue for the long term solution I propose?

> The big problem when load seed.
> -------------------------------
>
>                 Key: OFBIZ-7754
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7754
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Kongrath Suankaewmanee
>            Assignee: Pierre Smits
>         Attachments: OFBIZ-7754-SystemProperties.patch, OFBIZ-7754.patch
>
>
> Hi All,
> Regarding, [OFBIZ-7112|https://issues.apache.org/jira/browse/OFBIZ-7112]
> That's good for who start on use the ofbiz with initial setup, but not for the site that already online and has to update the OFBiz core. Because when has update OFBiz core they will use command load-seed for update.
> The problem is if we use load-seed mean the configuration data that's already exists will be replaced by the data from this file,
> *CommonSystemPropertyData.xml*
> So, for my suggestion should change the reader from *seed* to *seed-initial*  or remove systemPropertyValue from the data file.
> Thank you,
> Kongrath



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)