You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "PasunuriSrinidhi (via GitHub)" <gi...@apache.org> on 2023/04/12 17:40:26 UTC
[GitHub] [superset] PasunuriSrinidhi opened a new pull request, #23665: Update python_tests.sh
PasunuriSrinidhi opened a new pull request, #23665:
URL: https://github.com/apache/superset/pull/23665
Added --cov-report=html flag to generate an HTML report of code coverage. and --numprocesses=auto flag to run tests in parallel, using all available CPU cores. and --random-order flag to randomize the order of tests.
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] Update python_tests.sh [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed pull request #23665: Update python_tests.sh
URL: https://github.com/apache/superset/pull/23665
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: Update python_tests.sh to generate an HTML report of code coverage [superset]
Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley commented on code in PR #23665:
URL: https://github.com/apache/superset/pull/23665#discussion_r1488291297
##########
scripts/python_tests.sh:
##########
@@ -31,5 +31,4 @@ superset db upgrade
superset init
echo "Running tests"
-
-pytest --durations-min=2 --maxfail=1 --cov-report= --cov=superset ./tests/integration_tests "$@"
+pytest --durations-min=2 --maxfail=1 --cov-report=html --cov=superset --numprocesses=auto --random-order ./tests/integration_tests "$@"
Review Comment:
Having the tests run in a deterministic order is a requirement given these terminate (for right or wrong) after the first failure and thus when debugging tests you need to ensure that the order is preserved between successive runs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: Update python_tests.sh to generate an HTML report of code coverage [superset]
Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley commented on code in PR #23665:
URL: https://github.com/apache/superset/pull/23665#discussion_r1488291297
##########
scripts/python_tests.sh:
##########
@@ -31,5 +31,4 @@ superset db upgrade
superset init
echo "Running tests"
-
-pytest --durations-min=2 --maxfail=1 --cov-report= --cov=superset ./tests/integration_tests "$@"
+pytest --durations-min=2 --maxfail=1 --cov-report=html --cov=superset --numprocesses=auto --random-order ./tests/integration_tests "$@"
Review Comment:
Having the tests run in a deterministic order is a requirement given these terminate (for right or wrong) after the first failure and thus when debugging tests you need to ensure that the order is preserved between successive runs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] Update python_tests.sh [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #23665:
URL: https://github.com/apache/superset/pull/23665#issuecomment-1936558582
Closing/reopening this PR see how this does with CI. What format was the report in before if not HTML? I'm just wondering if there's some other automation that runs off the result.
As for the randomizing of test order, that sounds like it might wreak havoc. If we had perfect tests, that seems great, but I'm not sure this'll work out well. Adding reviewers who might know better than I do about the pros/cons.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: Update python_tests.sh to generate an HTML report of code coverage [superset]
Posted by "geido (via GitHub)" <gi...@apache.org>.
geido commented on code in PR #23665:
URL: https://github.com/apache/superset/pull/23665#discussion_r1488282192
##########
scripts/python_tests.sh:
##########
@@ -31,5 +31,4 @@ superset db upgrade
superset init
echo "Running tests"
-
-pytest --durations-min=2 --maxfail=1 --cov-report= --cov=superset ./tests/integration_tests "$@"
+pytest --durations-min=2 --maxfail=1 --cov-report=html --cov=superset --numprocesses=auto --random-order ./tests/integration_tests "$@"
Review Comment:
What's the benefit of the random order?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org