You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/07/21 08:21:44 UTC

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25219: [SPARK-28464][Doc][SS] Document Kafka source minPartitions option

dongjoon-hyun commented on a change in pull request #25219: [SPARK-28464][Doc][SS] Document Kafka source minPartitions option
URL: https://github.com/apache/spark/pull/25219#discussion_r305606621
 
 

 ##########
 File path: docs/structured-streaming-kafka-integration.md
 ##########
 @@ -388,6 +388,19 @@ The following configurations are optional:
   <td>streaming and batch</td>
   <td>Rate limit on maximum number of offsets processed per trigger interval. The specified total number of offsets will be proportionally split across topicPartitions of different volume.</td>
 </tr>
+<tr>
+  <td>minPartitions</td>
+  <td>int</td>
+  <td>0 (disabled)</td>
 
 Review comment:
   Thank you for your first contribution, @arunpandianp .
   However, this is wrong because this will mislead the users to try to set `0` and face `IllegalArgumentException`.
   Technically, the default value is `None`. Just leave this line as a blank like `<td></td>`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org