You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Adam Winer (JIRA)" <ji...@apache.org> on 2008/10/02 02:14:44 UTC
[jira] Created: (SHINDIG-638) HandlerProvider should use Providers,
not Injectors
HandlerProvider should use Providers, not Injectors
---------------------------------------------------
Key: SHINDIG-638
URL: https://issues.apache.org/jira/browse/SHINDIG-638
Project: Shindig
Issue Type: Improvement
Components: RESTful API (Java)
Reporter: Adam Winer
HandlerProvider gives Class<? extends DataRequestHandlers>, then ApiServlet uses Injector.getInstance().
It'd be cleaner if HandlerProvider gave Provider<? extends DataRequestHandler>, so ApiServlet didn't need to use the Injector at all.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-638) HandlerProvider should use Providers,
not Injectors
Posted by "Adam Winer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam Winer updated SHINDIG-638:
-------------------------------
Attachment: shindig-638.patch
Patch fixing the Guice circular loop introduced by the previous patch.
> HandlerProvider should use Providers, not Injectors
> ---------------------------------------------------
>
> Key: SHINDIG-638
> URL: https://issues.apache.org/jira/browse/SHINDIG-638
> Project: Shindig
> Issue Type: Improvement
> Components: RESTful API (Java)
> Reporter: Adam Winer
> Assignee: Ian Boston
> Priority: Minor
> Attachments: shindig-638.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> HandlerProvider gives Class<? extends DataRequestHandlers>, then ApiServlet uses Injector.getInstance().
> It'd be cleaner if HandlerProvider gave Provider<? extends DataRequestHandler>, so ApiServlet didn't need to use the Injector at all.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-638) HandlerProvider should use
Providers, not Injectors
Posted by "Adam Winer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641610#action_12641610 ]
Adam Winer commented on SHINDIG-638:
------------------------------------
See SHINDIG-641 (the follow-up issue to this), where there are instructions on how to upgrade.
> HandlerProvider should use Providers, not Injectors
> ---------------------------------------------------
>
> Key: SHINDIG-638
> URL: https://issues.apache.org/jira/browse/SHINDIG-638
> Project: Shindig
> Issue Type: Improvement
> Components: RESTful API (Java)
> Reporter: Adam Winer
> Assignee: Ian Boston
> Priority: Minor
> Attachments: shindig-638-fix.patch, shindig-638.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> HandlerProvider gives Class<? extends DataRequestHandlers>, then ApiServlet uses Injector.getInstance().
> It'd be cleaner if HandlerProvider gave Provider<? extends DataRequestHandler>, so ApiServlet didn't need to use the Injector at all.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-638) HandlerProvider should use Providers,
not Injectors
Posted by "Adam Winer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam Winer updated SHINDIG-638:
-------------------------------
Attachment: shindig-638.patch
Attached patch. Note - this patch deletes SampleContainerHandlerProvider.java; applying the patch just makes that file empty, so a committer would need to delete it for real.
> HandlerProvider should use Providers, not Injectors
> ---------------------------------------------------
>
> Key: SHINDIG-638
> URL: https://issues.apache.org/jira/browse/SHINDIG-638
> Project: Shindig
> Issue Type: Improvement
> Components: RESTful API (Java)
> Reporter: Adam Winer
> Priority: Minor
> Attachments: shindig-638.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> HandlerProvider gives Class<? extends DataRequestHandlers>, then ApiServlet uses Injector.getInstance().
> It'd be cleaner if HandlerProvider gave Provider<? extends DataRequestHandler>, so ApiServlet didn't need to use the Injector at all.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-638) HandlerProvider should use
Providers, not Injectors
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641605#action_12641605 ]
Paul Lindner commented on SHINDIG-638:
--------------------------------------
It would be helpful if you had provided instructions on how implementers of custom providers can convert their code to this obscure usage of Guice. It's not completely obvious and I'm still scratching my head on this...
> HandlerProvider should use Providers, not Injectors
> ---------------------------------------------------
>
> Key: SHINDIG-638
> URL: https://issues.apache.org/jira/browse/SHINDIG-638
> Project: Shindig
> Issue Type: Improvement
> Components: RESTful API (Java)
> Reporter: Adam Winer
> Assignee: Ian Boston
> Priority: Minor
> Attachments: shindig-638-fix.patch, shindig-638.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> HandlerProvider gives Class<? extends DataRequestHandlers>, then ApiServlet uses Injector.getInstance().
> It'd be cleaner if HandlerProvider gave Provider<? extends DataRequestHandler>, so ApiServlet didn't need to use the Injector at all.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SHINDIG-638) HandlerProvider should use
Providers, not Injectors
Posted by "Ian Boston (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ian Boston reassigned SHINDIG-638:
----------------------------------
Assignee: Ian Boston
> HandlerProvider should use Providers, not Injectors
> ---------------------------------------------------
>
> Key: SHINDIG-638
> URL: https://issues.apache.org/jira/browse/SHINDIG-638
> Project: Shindig
> Issue Type: Improvement
> Components: RESTful API (Java)
> Reporter: Adam Winer
> Assignee: Ian Boston
> Priority: Minor
> Attachments: shindig-638.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> HandlerProvider gives Class<? extends DataRequestHandlers>, then ApiServlet uses Injector.getInstance().
> It'd be cleaner if HandlerProvider gave Provider<? extends DataRequestHandler>, so ApiServlet didn't need to use the Injector at all.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-638) HandlerProvider should use Providers,
not Injectors
Posted by "Adam Winer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam Winer updated SHINDIG-638:
-------------------------------
Attachment: shindig-638-fix.patch
Attaching the correct file....
> HandlerProvider should use Providers, not Injectors
> ---------------------------------------------------
>
> Key: SHINDIG-638
> URL: https://issues.apache.org/jira/browse/SHINDIG-638
> Project: Shindig
> Issue Type: Improvement
> Components: RESTful API (Java)
> Reporter: Adam Winer
> Assignee: Ian Boston
> Priority: Minor
> Attachments: shindig-638-fix.patch, shindig-638.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> HandlerProvider gives Class<? extends DataRequestHandlers>, then ApiServlet uses Injector.getInstance().
> It'd be cleaner if HandlerProvider gave Provider<? extends DataRequestHandler>, so ApiServlet didn't need to use the Injector at all.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-638) HandlerProvider should use
Providers, not Injectors
Posted by "Ian Boston (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ian Boston resolved SHINDIG-638.
--------------------------------
Resolution: Fixed
Applied and committed,
thanks
> HandlerProvider should use Providers, not Injectors
> ---------------------------------------------------
>
> Key: SHINDIG-638
> URL: https://issues.apache.org/jira/browse/SHINDIG-638
> Project: Shindig
> Issue Type: Improvement
> Components: RESTful API (Java)
> Reporter: Adam Winer
> Assignee: Ian Boston
> Priority: Minor
> Attachments: shindig-638.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> HandlerProvider gives Class<? extends DataRequestHandlers>, then ApiServlet uses Injector.getInstance().
> It'd be cleaner if HandlerProvider gave Provider<? extends DataRequestHandler>, so ApiServlet didn't need to use the Injector at all.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-638) HandlerProvider should use
Providers, not Injectors
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641632#action_12641632 ]
Paul Lindner commented on SHINDIG-638:
--------------------------------------
okay, got it..
I think we have to work on the docs in the default GuiceModules, as this is the primary way that implementors are going to be customizing shindig for their environment. Here's what I have now:
custom PropertiesModule (uses our canonical properties/config system instead of the default properties file
custom hi5 guice module that subclasses DefaultGuiceModule. This does a super.configure() and then overrides the Person/AppData/Activity/HttpFetcher/SecurityToken bindings.
-- then I have an almost complete version of SocialApiGuice module cut and pasted in this class.
-- OAuthModule is currently used as-is
> HandlerProvider should use Providers, not Injectors
> ---------------------------------------------------
>
> Key: SHINDIG-638
> URL: https://issues.apache.org/jira/browse/SHINDIG-638
> Project: Shindig
> Issue Type: Improvement
> Components: RESTful API (Java)
> Reporter: Adam Winer
> Assignee: Ian Boston
> Priority: Minor
> Attachments: shindig-638-fix.patch, shindig-638.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> HandlerProvider gives Class<? extends DataRequestHandlers>, then ApiServlet uses Injector.getInstance().
> It'd be cleaner if HandlerProvider gave Provider<? extends DataRequestHandler>, so ApiServlet didn't need to use the Injector at all.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-638) HandlerProvider should use Providers,
not Injectors
Posted by "Adam Winer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam Winer updated SHINDIG-638:
-------------------------------
Priority: Minor (was: Major)
> HandlerProvider should use Providers, not Injectors
> ---------------------------------------------------
>
> Key: SHINDIG-638
> URL: https://issues.apache.org/jira/browse/SHINDIG-638
> Project: Shindig
> Issue Type: Improvement
> Components: RESTful API (Java)
> Reporter: Adam Winer
> Priority: Minor
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> HandlerProvider gives Class<? extends DataRequestHandlers>, then ApiServlet uses Injector.getInstance().
> It'd be cleaner if HandlerProvider gave Provider<? extends DataRequestHandler>, so ApiServlet didn't need to use the Injector at all.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-638) HandlerProvider should use
Providers, not Injectors
Posted by "Ian Boston (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636337#action_12636337 ]
Ian Boston commented on SHINDIG-638:
------------------------------------
Patch looks good, apart from one tailing space area.
So fixed that and applied, thanks.
> HandlerProvider should use Providers, not Injectors
> ---------------------------------------------------
>
> Key: SHINDIG-638
> URL: https://issues.apache.org/jira/browse/SHINDIG-638
> Project: Shindig
> Issue Type: Improvement
> Components: RESTful API (Java)
> Reporter: Adam Winer
> Assignee: Ian Boston
> Priority: Minor
> Attachments: shindig-638.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> HandlerProvider gives Class<? extends DataRequestHandlers>, then ApiServlet uses Injector.getInstance().
> It'd be cleaner if HandlerProvider gave Provider<? extends DataRequestHandler>, so ApiServlet didn't need to use the Injector at all.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-638) HandlerProvider should use
Providers, not Injectors
Posted by "Ian Boston (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636460#action_12636460 ]
Ian Boston commented on SHINDIG-638:
------------------------------------
New patches applied fixes the build problem.
Thanks
> HandlerProvider should use Providers, not Injectors
> ---------------------------------------------------
>
> Key: SHINDIG-638
> URL: https://issues.apache.org/jira/browse/SHINDIG-638
> Project: Shindig
> Issue Type: Improvement
> Components: RESTful API (Java)
> Reporter: Adam Winer
> Assignee: Ian Boston
> Priority: Minor
> Attachments: shindig-638-fix.patch, shindig-638.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> HandlerProvider gives Class<? extends DataRequestHandlers>, then ApiServlet uses Injector.getInstance().
> It'd be cleaner if HandlerProvider gave Provider<? extends DataRequestHandler>, so ApiServlet didn't need to use the Injector at all.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-638) HandlerProvider should use Providers,
not Injectors
Posted by "Adam Winer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam Winer updated SHINDIG-638:
-------------------------------
Attachment: (was: shindig-638.patch)
> HandlerProvider should use Providers, not Injectors
> ---------------------------------------------------
>
> Key: SHINDIG-638
> URL: https://issues.apache.org/jira/browse/SHINDIG-638
> Project: Shindig
> Issue Type: Improvement
> Components: RESTful API (Java)
> Reporter: Adam Winer
> Assignee: Ian Boston
> Priority: Minor
> Attachments: shindig-638.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> HandlerProvider gives Class<? extends DataRequestHandlers>, then ApiServlet uses Injector.getInstance().
> It'd be cleaner if HandlerProvider gave Provider<? extends DataRequestHandler>, so ApiServlet didn't need to use the Injector at all.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.