[GitHub] [spark] MaxGekk commented on a change in pull request #27438: [MINOR][SQL][DOCS][2.4] Fix the timestamp pattern in the example for `to_timestamp`

[GitBox <gi...@apache.org>]

MaxGekk commented on a change in pull request #27438: [MINOR][SQL][DOCS][2.4] Fix the timestamp pattern in the example for `to_timestamp`
URL: https://github.com/apache/spark/pull/27438#discussion_r374079736
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala
 ##########
 @@ -2967,7 +2967,7 @@ object functions {
    * See [[java.text.SimpleDateFormat]] for valid date and time format patterns
    *
    * @param s   A date, timestamp or string. If a string, the data must be in a format that can be
-   *            cast to a timestamp, such as `yyyy-MM-dd` or `yyyy-MM-dd HH:mm:ss.SSSS`
 
 Review comment:
   1. The result is incorrect, look at the PR which fixes that https://github.com/apache/spark/pull/26507, and here is an example:
   ```
       val sdf = new java.text.SimpleDateFormat("yyyy-MM-dd HH:mm:ss.SSSS")
       val res = sdf.parse("1970-01-01 00:00:00.1234")
       println(sdf.format(res))
   
   1970-01-01 00:00:01.0234
   ```
   2. And the result of `to_timestamp` is truncated to seconds.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org