You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "aslitaser (via GitHub)" <gi...@apache.org> on 2026/03/04 09:44:53 UTC

[PR] fix: wire readiness manager into ApisixPluginConfig and ApisixUpstream controllers [apisix-ingress-controller]

aslitaser opened a new pull request, #2729:
URL: https://github.com/apache/apisix-ingress-controller/pull/2729

   <!-- Please answer these questions before submitting a pull request -->
   
   ### Type of change:
   
   - [x] Bugfix
   
   ### What this PR does / why we need it:
   
   Fixes #2725
   
   `ApisixPluginConfig` and `ApisixUpstream` controllers were missing the `Readier` field and never called `Done()` on the readiness manager. This caused the provider to always wait the full 5-minute hardcoded timeout before starting the sync loop on every restart.
   
   **Root cause:** When `registerAPIv2ForReadiness()` registers these CRD types with the readiness manager, it adds all existing resources to a pending state. The `ApisixRouteReconciler` correctly calls `defer r.Readier.Done()` in its `Reconcile()` to mark resources as done, but `ApisixPluginConfigReconciler` and `ApisixUpstreamReconciler` were never wired up with the readiness manager — missing both the struct field and the `Done()` call.
   
   **Fix:**
   - Add `Readier readiness.ReadinessManager` field to both controller structs
   - Add `defer r.Readier.Done()` at the start of both `Reconcile()` methods
   - Pass `Readier: readier` when initializing both controllers in `controllers.go`
   
   ### Pre-submission checklist:
   
   - [x] Did you explain what problem does this PR solve? Or what new features have been added?
   - [ ] Have you added corresponding test cases?
   - [ ] Have you modified the corresponding document?
   - [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix-ingress-controller#community) first**


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix: wire readiness manager into ApisixPluginConfig and ApisixUpstream controllers [apisix-ingress-controller]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2729:
URL: https://github.com/apache/apisix-ingress-controller/pull/2729#issuecomment-4426517727

   This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 30 days if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix: wire readiness manager into ApisixPluginConfig and ApisixUpstream controllers [apisix-ingress-controller]

Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop commented on PR #2729:
URL: https://github.com/apache/apisix-ingress-controller/pull/2729#issuecomment-4044570641

   Hi @aslitaser, please add a test case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix: wire readiness manager into ApisixPluginConfig and ApisixUpstream controllers [apisix-ingress-controller]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2729:
URL: https://github.com/apache/apisix-ingress-controller/pull/2729#issuecomment-4676440042

   This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix: wire readiness manager into ApisixPluginConfig and ApisixUpstream controllers [apisix-ingress-controller]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #2729: fix: wire readiness manager into ApisixPluginConfig and ApisixUpstream controllers
URL: https://github.com/apache/apisix-ingress-controller/pull/2729


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org