You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by mmucha-redhat <gi...@git.apache.org> on 2018/01/07 18:15:08 UTC
[GitHub] nifi pull request #2384: NIFI-4745 : configuration property allowing failure...
GitHub user mmucha-redhat opened a pull request:
https://github.com/apache/nifi/pull/2384
NIFI-4745 : configuration property allowing failure description proce…
…ssing
We need to pass description of validation failure further in
processing chain, and eventually pass it back to calling system.
Therefore having failure desc logged in logs and issued as provenance
route event is not sufficient for us.
This patch adds new property, specifying name of attribute to be
created and filled with validation failure description.
Signed-off-by: Martin Mucha <al...@gmail.com>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mmucha-redhat/nifi emitFailureDescription
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2384.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2384
----
commit 34ab2d8df08af00c1363c2f23c442e1ce1d5419a
Author: Martin Mucha <al...@...>
Date: 2018-01-07T10:34:30Z
NIFI-4745 : configuration property allowing failure description processing
We need to pass description of validation failure further in
processing chain, and eventually pass it back to calling system.
Therefore having failure desc logged in logs and issued as provenance
route event is not sufficient for us.
This patch adds new property, specifying name of attribute to be
created and filled with validation failure description.
Signed-off-by: Martin Mucha <al...@gmail.com>
----
---
[GitHub] nifi issue #2384: NIFI-4745 : configuration property allowing failure descri...
Posted by mmucha-redhat <gi...@git.apache.org>.
Github user mmucha-redhat commented on the issue:
https://github.com/apache/nifi/pull/2384
Hi!
This is my first contribution. Please help me to finish this; I don't like the śtate of code in this file, and would like to agree on doing some refactorings, namely completelyFlowFile having too many arguments. Ideally I wouldn't like to pass attributeNameToStoreFailureDescription into this method, but I did not find a way how to add attribute, when writer is not closed yet. Please comment heavily if needed, I'm here ready to fix all issues!
Thanks!
---
[GitHub] nifi pull request #2384: NIFI-4745 : configuration property allowing failure...
Posted by mmucha-redhat <gi...@git.apache.org>.
Github user mmucha-redhat closed the pull request at:
https://github.com/apache/nifi/pull/2384
---
[GitHub] nifi issue #2384: NIFI-4745 : configuration property allowing failure descri...
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/2384
Hi @martin-mucha Thanks for your first contribution! The PR is closed without being reviewed and I can't find other PRs created for NIFI-4745. Do you have a PR ready for being reviewed somewhere?
About your concern to add another argument to the completeFlowFile method which has already lots of arguments, I think that should be fine, since it's just a private method and the method is a good place to add new attribute values.
BTW, ValidateRecord can validate multiple Records within a single incoming FlowFile. Is it going to be sufficient to write validation result to a FlowFile attribute? Isn't it be more useful if we can write validation failure detail to the outgoing Records, so that each record can have its failure detail?
---