You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/08 07:54:12 UTC
[GitHub] [flink] wuchong opened a new pull request #14583: [FLINK-20832][docs] Deliver bootstrap css and js ourselves
wuchong opened a new pull request #14583:
URL: https://github.com/apache/flink/pull/14583
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Delivering the required files ourselves, instead of using a CDN to fix the unstable https://maxcdn.bootstrapcdn.com in China.
## Brief change log
- Copy the resource files into `docs/page/...`
- Update the `base.html`.
## Verifying this change
I shutdowned the network on my machine, and locally build the docs, and everything works well.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14583: [FLINK-20832][docs] Deliver bootstrap css and js ourselves
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14583:
URL: https://github.com/apache/flink/pull/14583#issuecomment-756612029
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14583: [FLINK-20832][docs] Deliver bootstrap css and js ourselves
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14583:
URL: https://github.com/apache/flink/pull/14583#issuecomment-756612029
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "83fe39e016bb3ce3cd113ba9320460f4f1bf4959",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11786",
"triggerID" : "83fe39e016bb3ce3cd113ba9320460f4f1bf4959",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 83fe39e016bb3ce3cd113ba9320460f4f1bf4959 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11786)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14583: [FLINK-20832][docs] Deliver bootstrap css and js ourselves
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14583:
URL: https://github.com/apache/flink/pull/14583#issuecomment-756608804
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 83fe39e016bb3ce3cd113ba9320460f4f1bf4959 (Fri Jan 08 07:56:21 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14583: [FLINK-20832][docs] Deliver bootstrap css and js ourselves
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14583:
URL: https://github.com/apache/flink/pull/14583#issuecomment-756612029
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "83fe39e016bb3ce3cd113ba9320460f4f1bf4959",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "83fe39e016bb3ce3cd113ba9320460f4f1bf4959",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 83fe39e016bb3ce3cd113ba9320460f4f1bf4959 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14583: [FLINK-20832][docs] Deliver bootstrap css and js ourselves
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14583:
URL: https://github.com/apache/flink/pull/14583#issuecomment-756608804
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on a change in pull request #14583: [FLINK-20832][docs] Deliver bootstrap css and js ourselves
Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #14583:
URL: https://github.com/apache/flink/pull/14583#discussion_r553811745
##########
File path: NOTICE
##########
@@ -9,6 +9,10 @@ See bundled license files for details.
- jQuery v3.5.1 | (c) JS Foundation and other contributors
-> in "docs/page/js/jquery.min.js"
+- Bootstrap v3.3.4 (http://getbootstrap.com) Copyright 2011-2015 Twitter, Inc.
+ -> css in "docs/page/css/bootstrap.min.css"
+ -> js in "docs/page/js/bootstrap.min.js"
+ -> fonts in "docs/page/fonts"
Review comment:
```suggestion
- Bootstrap v3.3.4 (http://getbootstrap.com) Copyright 2011-2015 Twitter, Inc.
-> css in "docs/page/css/bootstrap.min.css"
-> js in "docs/page/js/bootstrap.min.js"
-> fonts in "docs/page/fonts"
Note: The "docs/page/fonts/glyphicons-halflings*" fonts are included in Bootstrap, and licensed under the same license as Boostrap. See https://glyphicons.com/old/license.html#old-halflings-bootstrap for more information.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14583: [FLINK-20832][docs] Deliver bootstrap css and js ourselves
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14583:
URL: https://github.com/apache/flink/pull/14583#issuecomment-756608804
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 4a041801f976d5f5c280bc863a074c2ce1a6ff79 (Fri May 28 07:03:23 UTC 2021)
**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14583: [FLINK-20832][docs] Deliver bootstrap css and js ourselves
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14583:
URL: https://github.com/apache/flink/pull/14583#issuecomment-756612029
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "83fe39e016bb3ce3cd113ba9320460f4f1bf4959",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11786",
"triggerID" : "83fe39e016bb3ce3cd113ba9320460f4f1bf4959",
"triggerType" : "PUSH"
}, {
"hash" : "dd86f51733f131dbcf4aba49047bbabfe72a5818",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dd86f51733f131dbcf4aba49047bbabfe72a5818",
"triggerType" : "PUSH"
}, {
"hash" : "4a041801f976d5f5c280bc863a074c2ce1a6ff79",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11791",
"triggerID" : "4a041801f976d5f5c280bc863a074c2ce1a6ff79",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dd86f51733f131dbcf4aba49047bbabfe72a5818 UNKNOWN
* 4a041801f976d5f5c280bc863a074c2ce1a6ff79 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11791)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #14583: [FLINK-20832][docs] Deliver bootstrap css and js ourselves
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #14583:
URL: https://github.com/apache/flink/pull/14583#issuecomment-756611094
@rmetzger , no, I just download them from the bootstrap CDN url.
How do we deal with the existing `docs/page/font-awesome/fonts/FontAwesome.otf`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #14583: [FLINK-20832][docs] Deliver bootstrap css and js ourselves
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #14583:
URL: https://github.com/apache/flink/pull/14583#issuecomment-756615475
It's mentioned in the `/NOTICE` file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #14583: [FLINK-20832][docs] Deliver bootstrap css and js ourselves
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #14583:
URL: https://github.com/apache/flink/pull/14583#issuecomment-756634031
@rmetzger I have added back the anchorjs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on a change in pull request #14583: [FLINK-20832][docs] Deliver bootstrap css and js ourselves
Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #14583:
URL: https://github.com/apache/flink/pull/14583#discussion_r553799205
##########
File path: docs/page/css/bootstrap.min.css
##########
@@ -0,0 +1,5 @@
+/*!
+ * Bootstrap v3.3.4 (http://getbootstrap.com)
+ * Copyright 2011-2015 Twitter, Inc.
+ * Licensed under MIT (https://github.com/twbs/bootstrap/blob/master/LICENSE)
Review comment:
I believe we should mention this dependency in the `NOTICE` file and add a copy of the license to `licenses/LICENSE.bootstrap`.
##########
File path: NOTICE
##########
@@ -9,6 +9,10 @@ See bundled license files for details.
- jQuery v3.5.1 | (c) JS Foundation and other contributors
-> in "docs/page/js/jquery.min.js"
+- Bootstrap v3.3.4 (http://getbootstrap.com) Copyright 2011-2015 Twitter, Inc.
+ -> css in "docs/page/css/bootstrap.min.css"
+ -> js in "docs/page/js/bootstrap.min.js"
+ -> fonts in "docs/page/fonts"
Review comment:
```suggestion
- Bootstrap v3.3.4 (http://getbootstrap.com) Copyright 2011-2015 Twitter, Inc.
-> css in "docs/page/css/bootstrap.min.css"
-> js in "docs/page/js/bootstrap.min.js"
-> fonts in "docs/page/fonts"
Note: The "docs/page/fonts/glyphicons-halflings*" fonts are included in Bootstrap, and licensed under the same license as Boostrap. See https://glyphicons.com/old/license.html#old-halflings-bootstrap for more information.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14583: [FLINK-20832][docs] Deliver bootstrap css and js ourselves
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14583:
URL: https://github.com/apache/flink/pull/14583#issuecomment-756612029
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "83fe39e016bb3ce3cd113ba9320460f4f1bf4959",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11786",
"triggerID" : "83fe39e016bb3ce3cd113ba9320460f4f1bf4959",
"triggerType" : "PUSH"
}, {
"hash" : "dd86f51733f131dbcf4aba49047bbabfe72a5818",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dd86f51733f131dbcf4aba49047bbabfe72a5818",
"triggerType" : "PUSH"
}, {
"hash" : "4a041801f976d5f5c280bc863a074c2ce1a6ff79",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11791",
"triggerID" : "4a041801f976d5f5c280bc863a074c2ce1a6ff79",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 83fe39e016bb3ce3cd113ba9320460f4f1bf4959 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11786)
* dd86f51733f131dbcf4aba49047bbabfe72a5818 UNKNOWN
* 4a041801f976d5f5c280bc863a074c2ce1a6ff79 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11791)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong merged pull request #14583: [FLINK-20832][docs] Deliver bootstrap css and js ourselves
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #14583:
URL: https://github.com/apache/flink/pull/14583
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #14583: [FLINK-20832][docs] Deliver bootstrap css and js ourselves
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #14583:
URL: https://github.com/apache/flink/pull/14583#issuecomment-756623139
@rmetzger , I removed `anchor.min.js` because the website can be loaded even without this resource.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #14583: [FLINK-20832][docs] Deliver bootstrap css and js ourselves
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #14583:
URL: https://github.com/apache/flink/pull/14583#discussion_r553801003
##########
File path: docs/page/css/bootstrap.min.css
##########
@@ -0,0 +1,5 @@
+/*!
+ * Bootstrap v3.3.4 (http://getbootstrap.com)
+ * Copyright 2011-2015 Twitter, Inc.
+ * Licensed under MIT (https://github.com/twbs/bootstrap/blob/master/LICENSE)
Review comment:
Sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14583: [FLINK-20832][docs] Deliver bootstrap css and js ourselves
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14583:
URL: https://github.com/apache/flink/pull/14583#issuecomment-756612029
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "83fe39e016bb3ce3cd113ba9320460f4f1bf4959",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11786",
"triggerID" : "83fe39e016bb3ce3cd113ba9320460f4f1bf4959",
"triggerType" : "PUSH"
}, {
"hash" : "dd86f51733f131dbcf4aba49047bbabfe72a5818",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dd86f51733f131dbcf4aba49047bbabfe72a5818",
"triggerType" : "PUSH"
}, {
"hash" : "4a041801f976d5f5c280bc863a074c2ce1a6ff79",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4a041801f976d5f5c280bc863a074c2ce1a6ff79",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 83fe39e016bb3ce3cd113ba9320460f4f1bf4959 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11786)
* dd86f51733f131dbcf4aba49047bbabfe72a5818 UNKNOWN
* 4a041801f976d5f5c280bc863a074c2ce1a6ff79 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #14583: [FLINK-20832][docs] Deliver bootstrap css and js ourselves
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #14583:
URL: https://github.com/apache/flink/pull/14583#issuecomment-756609137
Thanks for opening the PR. Have you checked the licenses of the font files?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #14583: [FLINK-20832][docs] Deliver bootstrap css and js ourselves
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #14583:
URL: https://github.com/apache/flink/pull/14583#discussion_r553801003
##########
File path: docs/page/css/bootstrap.min.css
##########
@@ -0,0 +1,5 @@
+/*!
+ * Bootstrap v3.3.4 (http://getbootstrap.com)
+ * Copyright 2011-2015 Twitter, Inc.
+ * Licensed under MIT (https://github.com/twbs/bootstrap/blob/master/LICENSE)
Review comment:
Sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #14583: [FLINK-20832][docs] Deliver bootstrap css and js ourselves
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #14583:
URL: https://github.com/apache/flink/pull/14583#issuecomment-756629804
> @rmetzger , I removed anchor.min.js because the website can be loaded even without this resource.
But it seems that we are loading anchor.min.js from a cloudflare CDN.
I would ship the cloudflare files also like bootstrap ourselves.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on a change in pull request #14583: [FLINK-20832][docs] Deliver bootstrap css and js ourselves
Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #14583:
URL: https://github.com/apache/flink/pull/14583#discussion_r553799205
##########
File path: docs/page/css/bootstrap.min.css
##########
@@ -0,0 +1,5 @@
+/*!
+ * Bootstrap v3.3.4 (http://getbootstrap.com)
+ * Copyright 2011-2015 Twitter, Inc.
+ * Licensed under MIT (https://github.com/twbs/bootstrap/blob/master/LICENSE)
Review comment:
I believe we should mention this dependency in the `NOTICE` file and add a copy of the license to `licenses/LICENSE.bootstrap`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14583: [FLINK-20832][docs] Deliver bootstrap css and js ourselves
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14583:
URL: https://github.com/apache/flink/pull/14583#issuecomment-756612029
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "83fe39e016bb3ce3cd113ba9320460f4f1bf4959",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11786",
"triggerID" : "83fe39e016bb3ce3cd113ba9320460f4f1bf4959",
"triggerType" : "PUSH"
}, {
"hash" : "dd86f51733f131dbcf4aba49047bbabfe72a5818",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dd86f51733f131dbcf4aba49047bbabfe72a5818",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 83fe39e016bb3ce3cd113ba9320460f4f1bf4959 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11786)
* dd86f51733f131dbcf4aba49047bbabfe72a5818 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #14583: [FLINK-20832][docs] Deliver bootstrap css and js ourselves
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #14583:
URL: https://github.com/apache/flink/pull/14583#issuecomment-756611094
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #14583: [FLINK-20832][docs] Deliver bootstrap css and js ourselves
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #14583:
URL: https://github.com/apache/flink/pull/14583#issuecomment-756609137
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong merged pull request #14583: [FLINK-20832][docs] Deliver bootstrap css and js ourselves
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #14583:
URL: https://github.com/apache/flink/pull/14583
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org