You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/11/02 19:44:41 UTC
[GitHub] [pinot] amrishlal commented on a diff in pull request #9708: Customize stopword for Lucene Index
amrishlal commented on code in PR #9708:
URL: https://github.com/apache/pinot/pull/9708#discussion_r1012229530
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java:
##########
@@ -319,12 +319,16 @@ public long getLatestIngestionTimestamp() {
// Text index
MutableTextIndex textIndex;
+ List<String> stopWordsInclude = null;
+ List<String> stopWordsExclude = null;
Review Comment:
Minor: it seems like this is the only reason why a null check is needed in `getStandardAnalyzerWithCustomizedStopWords` for `stopWordsInclude` and `stopWordsExclude`. Otherwise, all the other places that create stop world list are returning non null `List<String>` and marked as `NonNull`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org