You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2020/10/29 05:27:08 UTC

[GitHub] [zeppelin] zjffdu opened a new pull request #3958: [ZEPPELIN-5112]. upgrade-note.sh throws exception while upgrading notes on hdfs storage

zjffdu opened a new pull request #3958:
URL: https://github.com/apache/zeppelin/pull/3958


   
   ### What is this PR for?
   
   The root cause is that we didn't put hadoop jars in the classpath in `upgrade-note.sh`. This PR update script `upgrade-note.sh`. Besides that this PR also fix an upgrading issue in `ParagraphRuntimeInfo.java`. The `values` is List<String> in old version of zeppelin, but it is changed to List<Map<String, String>> in new version of zeppelin.
   
   ### What type of PR is it?
   [Bug Fix]
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   * https://issues.apache.org/jira/browse/ZEPPELIN-5112
   
   ### How should this be tested?
   * CI pass
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] zjffdu commented on pull request #3958: [ZEPPELIN-5112]. upgrade-note.sh throws exception while upgrading notes on hdfs storage

Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #3958:
URL: https://github.com/apache/zeppelin/pull/3958#issuecomment-721201100


   Will merge if no more comment


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] asfgit closed pull request #3958: [ZEPPELIN-5112]. upgrade-note.sh throws exception while upgrading notes on hdfs storage

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3958:
URL: https://github.com/apache/zeppelin/pull/3958


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] Reamer commented on a change in pull request #3958: [ZEPPELIN-5112]. upgrade-note.sh throws exception while upgrading notes on hdfs storage

Posted by GitBox <gi...@apache.org>.
Reamer commented on a change in pull request #3958:
URL: https://github.com/apache/zeppelin/pull/3958#discussion_r516046492



##########
File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/ParagraphRuntimeInfo.java
##########
@@ -18,7 +18,7 @@
 
   // runtimeInfos job url or dropdown-menu key in
   // zeppelin-web/src/app/notebook/paragraph/paragraph-control.html
-  private List<Map<String, String>> values;  // values for the key-value pair property
+  private List<Object> values;  // values for the key-value pair property

Review comment:
       Why do you change the type?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org