You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2019/03/12 14:51:15 UTC
[Impala-ASF-CR](2.x) IMPALA-6802 (part 6): Clean up authorization tests
Hello Impala Public Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/12722
to review the following change.
Change subject: IMPALA-6802 (part 6): Clean up authorization tests
......................................................................
IMPALA-6802 (part 6): Clean up authorization tests
This is the last part of the authorization test clean up.
This patch rewrites the following tests:
- alter database
- explain
- comment on
- function
- alter table/view
This patch also adds the following authorization tests:
- update
- upsert
- delete
The tests in AuthorizationTest.java that have been rewritten into
AuthorizationStmtTest.java are removed.
Cherry-picks: not for 2.x
Change-Id: Id594ce09a821aef4a1debfdd61569a11defd1c55
Reviewed-on: http://gerrit.cloudera.org:8080/10841
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java
M fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
2 files changed, 554 insertions(+), 2,045 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/12722/1
--
To view, visit http://gerrit.cloudera.org:8080/12722
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id594ce09a821aef4a1debfdd61569a11defd1c55
Gerrit-Change-Number: 12722
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR](2.x) IMPALA-6802 (part 6): Clean up authorization tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12722 )
Change subject: IMPALA-6802 (part 6): Clean up authorization tests
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2410/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12722
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Id594ce09a821aef4a1debfdd61569a11defd1c55
Gerrit-Change-Number: 12722
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 12 Mar 2019 15:31:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-6802 (part 6): Clean up authorization tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12722 )
Change subject: IMPALA-6802 (part 6): Clean up authorization tests
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3903/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12722
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Id594ce09a821aef4a1debfdd61569a11defd1c55
Gerrit-Change-Number: 12722
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 12 Mar 2019 15:05:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-6802 (part 6): Clean up authorization tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12722 )
Change subject: IMPALA-6802 (part 6): Clean up authorization tests
......................................................................
IMPALA-6802 (part 6): Clean up authorization tests
This is the last part of the authorization test clean up.
This patch rewrites the following tests:
- alter database
- explain
- comment on
- function
- alter table/view
This patch also adds the following authorization tests:
- update
- upsert
- delete
The tests in AuthorizationTest.java that have been rewritten into
AuthorizationStmtTest.java are removed.
Cherry-picks: not for 2.x
Change-Id: Id594ce09a821aef4a1debfdd61569a11defd1c55
Reviewed-on: http://gerrit.cloudera.org:8080/10841
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-on: http://gerrit.cloudera.org:8080/12722
Reviewed-by: Fredy Wijaya <fw...@cloudera.com>
---
M fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java
M fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
2 files changed, 554 insertions(+), 2,045 deletions(-)
Approvals:
Fredy Wijaya: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/12722
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Id594ce09a821aef4a1debfdd61569a11defd1c55
Gerrit-Change-Number: 12722
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR](2.x) IMPALA-6802 (part 6): Clean up authorization tests
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/12722 )
Change subject: IMPALA-6802 (part 6): Clean up authorization tests
......................................................................
Patch Set 1:
Conflicts:
fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
The conflicts in this file are failing to delete some tests. I manually delete them refering to the commit message.
--
To view, visit http://gerrit.cloudera.org:8080/12722
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Id594ce09a821aef4a1debfdd61569a11defd1c55
Gerrit-Change-Number: 12722
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 12 Mar 2019 14:54:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-6802 (part 6): Clean up authorization tests
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12722 )
Change subject: IMPALA-6802 (part 6): Clean up authorization tests
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12722
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Id594ce09a821aef4a1debfdd61569a11defd1c55
Gerrit-Change-Number: 12722
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 12 Mar 2019 15:49:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-6802 (part 6): Clean up authorization tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12722 )
Change subject: IMPALA-6802 (part 6): Clean up authorization tests
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12722
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Id594ce09a821aef4a1debfdd61569a11defd1c55
Gerrit-Change-Number: 12722
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 12 Mar 2019 18:47:09 +0000
Gerrit-HasComments: No