You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/04/23 18:13:10 UTC
[GitHub] [incubator-mxnet] leezu opened a new pull request #18151: Disable tests of numpy operators implemented with CustomOp
leezu opened a new pull request #18151:
URL: https://github.com/apache/incubator-mxnet/pull/18151
## Description ##
https://github.com/apache/incubator-mxnet/issues/18144, https://github.com/apache/incubator-mxnet/pull/18025 disabled `empty_like` which causes hangs. The other 3 CustomOp based fallback operators are also prone to cause deadlock, as exemplified by http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-gpu/detail/PR-18025/59/pipeline/425 where the hang occurs without `np_empty_like` test being run
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] RuRo commented on pull request #18151: Disable tests of numpy operators implemented with CustomOp
Posted by GitBox <gi...@apache.org>.
RuRo commented on pull request #18151:
URL: https://github.com/apache/incubator-mxnet/pull/18151#issuecomment-618755831
The `_np` in `test_np_kron` is `numpy`, not `mxnet.numpy`, so if you disabled that test because of the `_np.unravel_index` calls, then I think we can reenable that one since it's just pure `numpy`.
Nice idea, switching `empty_like` to `ones_like` in `test_np_unary_bool_funcs` though!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #18151: Disable tests of numpy operators implemented with CustomOp
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #18151:
URL: https://github.com/apache/incubator-mxnet/pull/18151#issuecomment-618562629
Hey @leezu , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [unix-gpu, website, sanity, edge, centos-cpu, centos-gpu, windows-gpu, unix-cpu, clang, windows-cpu, miscellaneous]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] RuRo edited a comment on pull request #18151: Disable tests of numpy operators implemented with CustomOp
Posted by GitBox <gi...@apache.org>.
RuRo edited a comment on pull request #18151:
URL: https://github.com/apache/incubator-mxnet/pull/18151#issuecomment-618696201
You might also want to disable other tests, which indirectly use those operators.
A quick grep over the tests only revealed `test_np_unary_bool_funcs`, which uses `np.empty_like`.
Not sure, if there are any more. Also, gonna mention #18090 here, so that this PR appears in the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #18151: Disable tests of numpy operators implemented with CustomOp
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #18151:
URL: https://github.com/apache/incubator-mxnet/pull/18151#issuecomment-618756831
Thanks for catching that @RuRo
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] RuRo edited a comment on pull request #18151: Disable tests of numpy operators implemented with CustomOp
Posted by GitBox <gi...@apache.org>.
RuRo edited a comment on pull request #18151:
URL: https://github.com/apache/incubator-mxnet/pull/18151#issuecomment-618696201
You might also want to disable other tests, which indirectly use those operators.
A quick grep over the tests only revealed `test_np_unary_bool_funcs`, which uses `np.empty_like`.
Not sure, if there are any more.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] RuRo edited a comment on pull request #18151: Disable tests of numpy operators implemented with CustomOp
Posted by GitBox <gi...@apache.org>.
RuRo edited a comment on pull request #18151:
URL: https://github.com/apache/incubator-mxnet/pull/18151#issuecomment-618755831
I think, the `_np` in `test_np_kron` is `numpy`, not `mxnet.numpy`, so if you disabled that test because of the `_np.unravel_index` calls, then I think we can reenable that one since it's just pure `numpy`.
Nice idea, switching `empty_like` to `ones_like` in `test_np_unary_bool_funcs` though!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] RuRo commented on pull request #18151: Disable tests of numpy operators implemented with CustomOp
Posted by GitBox <gi...@apache.org>.
RuRo commented on pull request #18151:
URL: https://github.com/apache/incubator-mxnet/pull/18151#issuecomment-618696201
You might also want to disable other tests, which indirectly use those operators.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org