You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@zipkin.apache.org by GitBox <gi...@apache.org> on 2019/04/30 03:37:02 UTC

[GitHub] [incubator-zipkin-api] adriancole opened a new issue #69: decide if we want to validate thrift on pull request or not

adriancole opened a new issue #69: decide if we want to validate thrift on pull request or not
URL: https://github.com/apache/incubator-zipkin-api/issues/69
 
 
   Unlike swagger and proto, there's no pure javascript tool to validate or use thrifts. You have to rely on a OS binary to first generate the code. This means our travis config either has to invoke two tools or we have a binary dependency in our [validate.test.js](https://github.com/apache/incubator-zipkin-api/blob/master/validate.test.js) only for thrift.
   
   another option is to simply not bother with thrift checking as we don't add anything to it anymore.
   
   cc @apache/zipkin-committers 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services