You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (Created) (JIRA)" <ji...@apache.org> on 2012/01/26 23:53:43 UTC
[jira] [Created] (CASSANDRA-3792) add type information to new
schema_ columnfamilies
add type information to new schema_ columnfamilies
--------------------------------------------------
Key: CASSANDRA-3792
URL: https://issues.apache.org/jira/browse/CASSANDRA-3792
Project: Cassandra
Issue Type: Improvement
Components: Core
Affects Versions: 1.1
Reporter: Jonathan Ellis
Assignee: Jonathan Ellis
Fix For: 1.1
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3792) add type information to new
schema_ columnfamilies
Posted by "Sylvain Lebresne (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227379#comment-13227379 ]
Sylvain Lebresne commented on CASSANDRA-3792:
---------------------------------------------
Follow-up changes are on https://github.com/pcmanus/cassandra/commits/3792. There is like 9 commits on top of the 3 previous ones but some are rather small. This fixes a number of bugs and make all unit test pass.
One of the thing it does is adding a gc_grace_seconds > 0 for schema column families. This is necessary since we now uses normal deletes. I've added a test at https://github.com/riptano/cassandra-dtest/blob/master/schema_test.py that fails with current 1.1.0 to show that problem. This does lead to the question of what value to use for that gc_grace. The current patches set this to 3 months, hoping that no one will keep a node dead that long, but there is some amount of random in that choice.
Note that following those patches, CQL still convert to and from thrift structures to reuse ThriftValidation methods. I've created CASSANDRA-4037 to fix that. I also think we should consider using an enumeration (or equivalent) for the CFMetadata properties names, as reusing strings is a bit fragile, but I'm fine leaving that to a follow up ticket.
> add type information to new schema_ columnfamilies
> --------------------------------------------------
>
> Key: CASSANDRA-3792
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3792
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.1.0
> Reporter: Jonathan Ellis
> Assignee: Sylvain Lebresne
> Fix For: 1.1.0
>
>
> Should also fix the quotes that the current Thrift-based serialization embeds in string schema data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3792) add type information to new
schema_ columnfamilies
Posted by "Jonathan Ellis (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-3792:
--------------------------------------
Reviewer: jbellis (was: xedin)
Assignee: (was: Jonathan Ellis)
> add type information to new schema_ columnfamilies
> --------------------------------------------------
>
> Key: CASSANDRA-3792
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3792
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.1.0
> Reporter: Jonathan Ellis
> Fix For: 1.1.0
>
>
> Should also fix the quotes that the current Thrift-based serialization embeds in string schema data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3792) add type information to new
schema_ columnfamilies
Posted by "Jonathan Ellis (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-3792:
--------------------------------------
Description: Should also fix the quotes that the current Thrift-based serialization embeds in string schema data.
> add type information to new schema_ columnfamilies
> --------------------------------------------------
>
> Key: CASSANDRA-3792
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3792
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.1.0
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 1.1.0
>
>
> Should also fix the quotes that the current Thrift-based serialization embeds in string schema data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CASSANDRA-3792) add type information to new
schema_ columnfamilies
Posted by "Sylvain Lebresne (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne resolved CASSANDRA-3792.
-----------------------------------------
Resolution: Fixed
Committed, thanks
> add type information to new schema_ columnfamilies
> --------------------------------------------------
>
> Key: CASSANDRA-3792
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3792
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.1.0
> Reporter: Jonathan Ellis
> Assignee: Sylvain Lebresne
> Fix For: 1.1.0
>
>
> Should also fix the quotes that the current Thrift-based serialization embeds in string schema data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3792) add type information to new
schema_ columnfamilies
Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227819#comment-13227819 ]
Jonathan Ellis commented on CASSANDRA-3792:
-------------------------------------------
+1
> add type information to new schema_ columnfamilies
> --------------------------------------------------
>
> Key: CASSANDRA-3792
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3792
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.1.0
> Reporter: Jonathan Ellis
> Assignee: Sylvain Lebresne
> Fix For: 1.1.0
>
>
> Should also fix the quotes that the current Thrift-based serialization embeds in string schema data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3792) add type information to new
schema_ columnfamilies
Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225060#comment-13225060 ]
Jonathan Ellis commented on CASSANDRA-3792:
-------------------------------------------
Changes are up on https://github.com/jbellis/cassandra/tree/3792. The first three commits are fairly self-explanatory; the last is the big one. I've tried to avoid logic changes and just replace toSchema/fromSchema with "native" serialization. To make that sane I added some helper methods (Column.create, QueryProcessor.resultify). I also replaced KsDef/CfDef/ColumnDef with KsMetadata/CFMetadata/ColumnDefinition internally.
This is incomplete; FBUtilities has a couple methods stubbed out with "?". I believe the rest compiles but I would be surprised if it works. I won't have time to pick this back up again until next week, so I'm posting this as-is if someone wants to finish it before then.
I've also created CASSANDRA-4017 and CASSANDRA-4018 for further followup.
> add type information to new schema_ columnfamilies
> --------------------------------------------------
>
> Key: CASSANDRA-3792
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3792
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.1.0
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 1.1.0
>
>
> Should also fix the quotes that the current Thrift-based serialization embeds in string schema data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3792) add type information to new
schema_ columnfamilies
Posted by "Sylvain Lebresne (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225084#comment-13225084 ]
Sylvain Lebresne commented on CASSANDRA-3792:
---------------------------------------------
Got some time, I'll pick it over.
> add type information to new schema_ columnfamilies
> --------------------------------------------------
>
> Key: CASSANDRA-3792
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3792
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.1.0
> Reporter: Jonathan Ellis
> Assignee: Sylvain Lebresne
> Fix For: 1.1.0
>
>
> Should also fix the quotes that the current Thrift-based serialization embeds in string schema data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CASSANDRA-3792) add type information to new
schema_ columnfamilies
Posted by "Sylvain Lebresne (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne reassigned CASSANDRA-3792:
-------------------------------------------
Assignee: Sylvain Lebresne
> add type information to new schema_ columnfamilies
> --------------------------------------------------
>
> Key: CASSANDRA-3792
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3792
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.1.0
> Reporter: Jonathan Ellis
> Assignee: Sylvain Lebresne
> Fix For: 1.1.0
>
>
> Should also fix the quotes that the current Thrift-based serialization embeds in string schema data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira