You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/07/20 01:36:42 UTC
[GitHub] [skywalking] EvanLjp opened a new issue #5130: Plugin Cnfig Loader
EvanLjp opened a new issue #5130:
URL: https://github.com/apache/skywalking/issues/5130
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ ] Feature or performance improvement
___
### Requirement or improvement
- Please describe about your requirements or improvement suggestions.
A spi interface to load plugin config
### implementation
1. define a interface called Plugin Config
2. define a spi interface to load Plugin Config(all config schema is defined by submitter)
3. define a container to contain the plugin config,for example Map<class extends config loader spi,Plugin Config>
4. the container is shared with all agent plugins
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5130: Plugin Config Loader
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5130:
URL: https://github.com/apache/skywalking/issues/5130#issuecomment-660785248
> define a container to contain the plugin config,for example Map<class extends config loader spi,Plugin Config>
Read `SnifferConfigInitializer#initialize`. You just need a little refactor about this, and support to set a new Config Class. Such as providing a new method `public static void initialize(String agentOptions, Class<?> config)`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5130: Plugin Config Loader
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5130:
URL: https://github.com/apache/skywalking/issues/5130#issuecomment-660784708
> define a interface called Plugin Config
Why do you need this? I think any class is suitable for Config initialization.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #5130: Plugin Config Loader
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #5130:
URL: https://github.com/apache/skywalking/issues/5130
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] EvanLjp commented on issue #5130: Plugin Config Loader
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on issue #5130:
URL: https://github.com/apache/skywalking/issues/5130#issuecomment-660785695
ok,i read this code first
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org