[jira] [Commented] (GIRAPH-437) Missing progress calls when stopping Netty server

["Maja Kabiljo (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GIRAPH-437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509096#comment-13509096 ] 

Maja Kabiljo commented on GIRAPH-437:
-------------------------------------

Eli, thank you for your comment. We did get the timeout here again.
 
I've been looking through netty.io site, but it states that we can use ChannelGroup.close()
http://static.netty.io/3.5/api/org/jboss/netty/channel/socket/nio/NioServerSocketChannelFactory.html
The problem seems to be that we are not keeping track of all connected channels, so we don't try to close all of them. 

Please take a look at GIRAPH-441.

One thing about NettyClient.stop() - we don't wait for all the connections to close and resources to be released before returning from the call. Is that intentional?

                
> Missing progress calls when stopping Netty server
> -------------------------------------------------
>
>                 Key: GIRAPH-437
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-437
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Maja Kabiljo
>            Assignee: Maja Kabiljo
>         Attachments: GIRAPH-437.patch
>
>
> At the end of a long running job I got an exception about not reporting progress. The last log line was: "stop: Halting netty server", so I suspect it's because awaitUninterruptibly() call there.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira