You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/03/13 22:31:41 UTC

[jira] [Commented] (BEAM-1530) BigQueryIO should support value-dependent windows

    [ https://issues.apache.org/jira/browse/BEAM-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15923097#comment-15923097 ] 

ASF GitHub Bot commented on BEAM-1530:
--------------------------------------

GitHub user reuvenlax opened a pull request:

    https://github.com/apache/beam/pull/2238

    [BEAM-1530] Cleanup BigQueryIO, and allow for value-based tables

    BigQueryIO now conforms to best practices.
    
    BigQueryIO.Write takes in a user type, which the user can convert to a TableRow.
    
    Table functions now take a full WindowedValue, instead of just the window.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/reuvenlax/incubator-beam new_bigquery_api

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2238.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2238
    
----
commit 566ae69cc36a895f9c2dc11e58b06925147e8969
Author: Reuven Lax <re...@relax-macbookpro.roam.corp.google.com>
Date:   2016-11-14T04:29:31Z

    Add PubSub attributes support to PubsubIO.

commit ae0e4d3ba4726fb8024d3f024d41d0ad17e57963
Author: Reuven Lax <re...@google.com>
Date:   2017-03-13T22:25:25Z

    Cleanup BigQueryIO
      * Get rid of bound
      * Input type T
      * Allow table based on WindowedValue

commit 2f5e677ca03251dd48f562c931a799e0fea76a37
Author: Reuven Lax <re...@google.com>
Date:   2017-03-13T22:28:30Z

    CheckStyle fixes

----


> BigQueryIO should support value-dependent windows
> -------------------------------------------------
>
>                 Key: BEAM-1530
>                 URL: https://issues.apache.org/jira/browse/BEAM-1530
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Reuven Lax
>            Assignee: Reuven Lax
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)