You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/08/01 12:41:40 UTC
[GitHub] [incubator-nuttx] jarivanewijk opened a new pull request, #6754: NXP S32K1XX: add initial support for NXP RDDRONE-BMS772 board
jarivanewijk opened a new pull request, #6754:
URL: https://github.com/apache/incubator-nuttx/pull/6754
## Summary
Adds initial support for the NXP RDDRONE-BMS772 board. The basic NSH configuration just initializes the board and enables the console UART. Code to enable other peripherals is also included, but remain mostly untested for the time being.
## Impact
Adds a new board configuration for NXP RDDRONE-BMS772 with NXP S32K144 MCU.
## Testing
Basic NSH config tested on RDDRONE-BMS772 hardware. Most other functionality (not enabled in the :nsh config) has also been tested, but with an older NuttX release. We first need to update our BMS application before we can again test complete board functionality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis merged pull request #6754: NXP S32K1XX: add initial support for NXP RDDRONE-BMS772 board
Posted by GitBox <gi...@apache.org>.
acassis merged PR #6754:
URL: https://github.com/apache/incubator-nuttx/pull/6754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jarivanewijk commented on a diff in pull request #6754: NXP S32K1XX: add initial support for NXP RDDRONE-BMS772 board
Posted by GitBox <gi...@apache.org>.
jarivanewijk commented on code in PR #6754:
URL: https://github.com/apache/incubator-nuttx/pull/6754#discussion_r934596950
##########
boards/arm/s32k1xx/rddrone-bms772/Kconfig:
##########
@@ -0,0 +1,184 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+if ARCH_BOARD_RDDRONE_BMS772
+
+config S32K1XX_NRSTCHECK_PROCFS
+ bool "RDDRONE-BMS772 nRST Check PROCFS entry"
+ default n
+ depends on FS_PROCFS
+ select FS_PROCFS_REGISTER
+ ---help---
+ Self-test to check that the MCU reset pin is connected to an
+ external pull-up resistor (or an IC that pulls the pin high).
+ The input logic level is registered as a PROCFS entry.
+
+config SMBUS_SBD
+ bool "SMBus Smart Battery Data slave"
+ default n
+ depends on I2C_SLAVE
+ ---help---
+ Simple SMBus/I2C slave providing battery management data,
+ specifically implementing a subset of the Smart Battery Data
+ Specification, Revision 1.1
+
+menu "RDDRONE-BMS772 PM configuration"
+depends on PM
+
+menu "PM configuration for PM_STANDBY mode"
+
+choice
+ prompt "MCU power mode"
+ default VLPR_STANDBY
+
+config RUN_STANDBY
+ bool "RUN mode"
+ ---help---
+ The MCU should be in RUN mode in the PM_STANDBY mode
Review Comment:
I agree. I changed the description and help text. We plan to revisit all of these PM-related options in the near future anyway, as it is very difficult to understand this configuration for a new user.
##########
boards/arm/s32k1xx/rddrone-bms772/Kconfig:
##########
@@ -0,0 +1,184 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+if ARCH_BOARD_RDDRONE_BMS772
+
+config S32K1XX_NRSTCHECK_PROCFS
+ bool "RDDRONE-BMS772 nRST Check PROCFS entry"
+ default n
+ depends on FS_PROCFS
+ select FS_PROCFS_REGISTER
+ ---help---
+ Self-test to check that the MCU reset pin is connected to an
+ external pull-up resistor (or an IC that pulls the pin high).
+ The input logic level is registered as a PROCFS entry.
+
+config SMBUS_SBD
+ bool "SMBus Smart Battery Data slave"
+ default n
+ depends on I2C_SLAVE
+ ---help---
+ Simple SMBus/I2C slave providing battery management data,
+ specifically implementing a subset of the Smart Battery Data
+ Specification, Revision 1.1
+
+menu "RDDRONE-BMS772 PM configuration"
+depends on PM
+
+menu "PM configuration for PM_STANDBY mode"
+
+choice
+ prompt "MCU power mode"
+ default VLPR_STANDBY
+
+config RUN_STANDBY
+ bool "RUN mode"
+ ---help---
+ The MCU should be in RUN mode in the PM_STANDBY mode
+
+config VLPR_STANDBY
+ bool "VLPR mode"
+ ---help---
+ The MCU should be in VLPR (very low power run) mode in the PM_STANDBY
+ mode
+
+endchoice # MCU power mode
+
+menuconfig PM_SPI_STANDBY
+ bool "Enable SPI in PM_STANDBY mode"
+ default n
+ depends on SPI
+ ---help---
+ Enable PM configuration for SPI
+
+if PM_SPI_STANDBY
+
+config PM_SPI0_STANDBY
+ bool "Enable LPSPI0 in PM_STANDBY mode"
+ default n
+ depends on S32K1XX_LPSPI0
+
+config PM_SPI1_STANDBY
+ bool "Enable LPSPI1 in PM_STANDBY mode"
+ default n
+ depends on S32K1XX_LPSPI1
+
+endif # PM_SPI_STANDBY
+
+menuconfig PM_SERIAL_STANDBY
+ bool "Enable serial in PM_STANDBY mode"
+ default n
+ depends on SERIAL
+ ---help---
+ Enable PM configuration for SERIAL
+
+if PM_SERIAL_STANDBY
+
+config PM_CONSOLE_STANDBY
+ bool "Enable serial console in PM_STANDBY"
+ default n
+ depends on SERIAL_CONSOLE
+ select PM_SERIAL0_STANDBY if LPUART0_SERIAL_CONSOLE
+ select PM_SERIAL1_STANDBY if LPUART1_SERIAL_CONSOLE
+ select PM_SERIAL2_STANDBY if LPUART2_SERIAL_CONSOLE
+
+config PM_SERIAL0_STANDBY
+ bool "Enable LPUART0 in PM_STANDBY mode"
+ default n
+ depends on S32K1XX_LPUART0
+
+config PM_SERIAL1_STANDBY
+ bool "Enable LPUART1 in PM_STANDBY mode"
+ default n
+ depends on S32K1XX_LPUART1
+
+config PM_SERIAL2_STANDBY
+ bool "Enable LPUART2 in PM_STANDBY mode"
+ default n
+ depends on S32K1XX_LPUART2
+
+endif # PM_SERIAL_STANDBY
+
+endmenu # PM configuration for PM_STANDBY mode
+
+menu "PM configuration for PM_SLEEP mode"
+
+choice
+ prompt "MCU power mode"
+ default VLPR_SLEEP
+
+config RUN_SLEEP
+ bool "RUN mode"
Review Comment:
Changed as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jarivanewijk commented on a diff in pull request #6754: NXP S32K1XX: add initial support for NXP RDDRONE-BMS772 board
Posted by GitBox <gi...@apache.org>.
jarivanewijk commented on code in PR #6754:
URL: https://github.com/apache/incubator-nuttx/pull/6754#discussion_r934598862
##########
boards/arm/s32k1xx/rddrone-bms772/README.txt:
##########
@@ -0,0 +1,142 @@
+README
Review Comment:
I am planning to open a separate PR to add documentation for all of our S32K1 and S32K3 boards later this week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #6754: NXP S32K1XX: add initial support for NXP RDDRONE-BMS772 board
Posted by GitBox <gi...@apache.org>.
acassis commented on code in PR #6754:
URL: https://github.com/apache/incubator-nuttx/pull/6754#discussion_r934536044
##########
boards/arm/s32k1xx/rddrone-bms772/Kconfig:
##########
@@ -0,0 +1,184 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+if ARCH_BOARD_RDDRONE_BMS772
+
+config S32K1XX_NRSTCHECK_PROCFS
+ bool "RDDRONE-BMS772 nRST Check PROCFS entry"
+ default n
+ depends on FS_PROCFS
+ select FS_PROCFS_REGISTER
+ ---help---
+ Self-test to check that the MCU reset pin is connected to an
+ external pull-up resistor (or an IC that pulls the pin high).
+ The input logic level is registered as a PROCFS entry.
+
+config SMBUS_SBD
+ bool "SMBus Smart Battery Data slave"
+ default n
+ depends on I2C_SLAVE
+ ---help---
+ Simple SMBus/I2C slave providing battery management data,
+ specifically implementing a subset of the Smart Battery Data
+ Specification, Revision 1.1
+
+menu "RDDRONE-BMS772 PM configuration"
+depends on PM
+
+menu "PM configuration for PM_STANDBY mode"
+
+choice
+ prompt "MCU power mode"
+ default VLPR_STANDBY
+
+config RUN_STANDBY
+ bool "RUN mode"
+ ---help---
+ The MCU should be in RUN mode in the PM_STANDBY mode
+
+config VLPR_STANDBY
+ bool "VLPR mode"
+ ---help---
+ The MCU should be in VLPR (very low power run) mode in the PM_STANDBY
+ mode
+
+endchoice # MCU power mode
+
+menuconfig PM_SPI_STANDBY
+ bool "Enable SPI in PM_STANDBY mode"
+ default n
+ depends on SPI
+ ---help---
+ Enable PM configuration for SPI
+
+if PM_SPI_STANDBY
+
+config PM_SPI0_STANDBY
+ bool "Enable LPSPI0 in PM_STANDBY mode"
+ default n
+ depends on S32K1XX_LPSPI0
+
+config PM_SPI1_STANDBY
+ bool "Enable LPSPI1 in PM_STANDBY mode"
+ default n
+ depends on S32K1XX_LPSPI1
+
+endif # PM_SPI_STANDBY
+
+menuconfig PM_SERIAL_STANDBY
+ bool "Enable serial in PM_STANDBY mode"
+ default n
+ depends on SERIAL
+ ---help---
+ Enable PM configuration for SERIAL
+
+if PM_SERIAL_STANDBY
+
+config PM_CONSOLE_STANDBY
+ bool "Enable serial console in PM_STANDBY"
+ default n
+ depends on SERIAL_CONSOLE
+ select PM_SERIAL0_STANDBY if LPUART0_SERIAL_CONSOLE
+ select PM_SERIAL1_STANDBY if LPUART1_SERIAL_CONSOLE
+ select PM_SERIAL2_STANDBY if LPUART2_SERIAL_CONSOLE
+
+config PM_SERIAL0_STANDBY
+ bool "Enable LPUART0 in PM_STANDBY mode"
+ default n
+ depends on S32K1XX_LPUART0
+
+config PM_SERIAL1_STANDBY
+ bool "Enable LPUART1 in PM_STANDBY mode"
+ default n
+ depends on S32K1XX_LPUART1
+
+config PM_SERIAL2_STANDBY
+ bool "Enable LPUART2 in PM_STANDBY mode"
+ default n
+ depends on S32K1XX_LPUART2
+
+endif # PM_SERIAL_STANDBY
+
+endmenu # PM configuration for PM_STANDBY mode
+
+menu "PM configuration for PM_SLEEP mode"
+
+choice
+ prompt "MCU power mode"
+ default VLPR_SLEEP
+
+config RUN_SLEEP
+ bool "RUN mode"
Review Comment:
Same here: "Keep in RUN mode during PM Sleep mode"
##########
boards/arm/s32k1xx/rddrone-bms772/Kconfig:
##########
@@ -0,0 +1,184 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+if ARCH_BOARD_RDDRONE_BMS772
+
+config S32K1XX_NRSTCHECK_PROCFS
+ bool "RDDRONE-BMS772 nRST Check PROCFS entry"
+ default n
+ depends on FS_PROCFS
+ select FS_PROCFS_REGISTER
+ ---help---
+ Self-test to check that the MCU reset pin is connected to an
+ external pull-up resistor (or an IC that pulls the pin high).
+ The input logic level is registered as a PROCFS entry.
+
+config SMBUS_SBD
+ bool "SMBus Smart Battery Data slave"
+ default n
+ depends on I2C_SLAVE
+ ---help---
+ Simple SMBus/I2C slave providing battery management data,
+ specifically implementing a subset of the Smart Battery Data
+ Specification, Revision 1.1
+
+menu "RDDRONE-BMS772 PM configuration"
+depends on PM
+
+menu "PM configuration for PM_STANDBY mode"
+
+choice
+ prompt "MCU power mode"
+ default VLPR_STANDBY
+
+config RUN_STANDBY
+ bool "RUN mode"
+ ---help---
+ The MCU should be in RUN mode in the PM_STANDBY mode
Review Comment:
Maybe the description name of this mode should be more clear: i.e.: "Keep in RUN mode during PM Standby"
##########
boards/arm/s32k1xx/rddrone-bms772/README.txt:
##########
@@ -0,0 +1,142 @@
+README
Review Comment:
Please add the board Documentation too: https://nuttx.apache.org/docs/latest/platforms/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #6754: NXP S32K1XX: add initial support for NXP RDDRONE-BMS772 board
Posted by GitBox <gi...@apache.org>.
acassis commented on code in PR #6754:
URL: https://github.com/apache/incubator-nuttx/pull/6754#discussion_r934641333
##########
boards/arm/s32k1xx/rddrone-bms772/README.txt:
##########
@@ -0,0 +1,142 @@
+README
Review Comment:
Ok! Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org