You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by muratsu <gi...@git.apache.org> on 2014/12/16 00:13:17 UTC
[GitHub] cordova-cli pull request: added --list support
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-cli/pull/199
added --list support
For more details please check the dev mailing list and the [JIRA issue](https://issues.apache.org/jira/browse/CB-8168)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-cli CB-8168
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-cli/pull/199.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #199
----
commit baf6b2a998712eac85910383f7a6ae94a6fb62bf
Author: Murat Sutunc <mu...@microsoft.com>
Date: 2014-12-08T22:40:13Z
added --list support
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-cli pull request: added --list support
Posted by jsoref <gi...@git.apache.org>.
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/199#discussion_r22110399
--- Diff: src/cli.js ---
@@ -288,4 +288,4 @@ function cli(inputArgs) {
};
cordova.raw[cmd](subcommand, targets, download_opts).done();
}
-}
+}
--- End diff --
You should not be removing the new line at end of file (i.e. if you see this red null on a green background at the end, your patch/commit/file is bad, open the file in your text editor, add a blank line at the end of the file, and save it, then commit --amend...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-cli pull request: added --list support
Posted by jsoref <gi...@git.apache.org>.
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/199#discussion_r22110323
--- Diff: doc/run.txt ---
@@ -31,3 +31,4 @@ Experimental Flags
--browserify ....................... Plugins javascript gets loaded at build time instead of runtime using browserify.
Replaces cordovajs file with one that includes the JS of the installed plugins.
+ --list ............................. Prints out available targets for Cordova - device and emulator.
--- End diff --
This should have a way to list only device / only emulator.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-cli pull request: added --list support
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-cli/pull/199
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-cli pull request: added --list support
Posted by jsoref <gi...@git.apache.org>.
Github user jsoref commented on the pull request:
https://github.com/apache/cordova-cli/pull/199#issuecomment-67654989
Lastly, you need to include a JIRA number in each commit, please read:
http://wiki.apache.org/cordova/IssueWorkflow
(And if there are bugs in the workflow, please let us know, we're happy to fix any ambiguities...)
If each of your pull requests for this feature shared a CB- number, then it'd be a lot easier for me to get from here to apache/cordova-android#139 or apache/cordova-ios#122
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-cli pull request: added --list support
Posted by jsoref <gi...@git.apache.org>.
Github user jsoref commented on the pull request:
https://github.com/apache/cordova-cli/pull/199#issuecomment-67654548
There already is functionally for this:
https://issues.apache.org/jira/browse/CB-2972
You really should reuse this instead of forcing each platform to reimplement this feature.
If you want to use it as a fallback instead of a first preference, that's ok. But it isn't ok to make us do work again just to catch up when we've already implemented a feature.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-cli pull request: added --list support
Posted by jsoref <gi...@git.apache.org>.
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/199#discussion_r22110362
--- Diff: src/cli.js ---
@@ -91,13 +90,13 @@ function cli(inputArgs) {
};
// If no inputArgs given, use process.argv.
- inputArgs = inputArgs || process.argv
--- End diff --
Please split fixes to code style from feature work -- i.e. they should be distinct commits (you can put them together in the same pull request).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org