[GitHub] [pulsar] merlimat opened a new pull request #7068: [C++] ClientImpl::handleClose shouldn't use statics

[GitBox <gi...@apache.org>]

merlimat opened a new pull request #7068:
URL: https://github.com/apache/pulsar/pull/7068


   ### Motivation
   
   `ClientImpl::handleClose` was using static variables to record the first
   error on closing a client. This is just wrong. A static stack variable
   in c++ acts like a global. So if errorClosing was ever set to true in
   a process, all clients closed in that process after that point would
   be errored with first error.
   
   This fixes a failure in `BasicEndToEndTest.testDelayedMessages`, which
   happens sporadically on C++, and always when running the tests in
   serial, probably due to a double close in some other test.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #7068: [C++] ClientImpl::handleClose shouldn't use statics

[GitBox <gi...@apache.org>]

codelipenghui merged pull request #7068:
URL: https://github.com/apache/pulsar/pull/7068


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org