You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tez.apache.org by "abstractdog (via GitHub)" <gi...@apache.org> on 2025/02/19 14:54:53 UTC
[PR] TEZ-4600: JobTokenSecretManager should respect the algorithm set by hadoop [tez]
abstractdog opened a new pull request, #393:
URL: https://github.com/apache/tez/pull/393
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4600: Secret managers in Tez should respect the algorithm set by hadoop [tez]
Posted by "ayushtkn (via GitHub)" <gi...@apache.org>.
ayushtkn commented on code in PR #393:
URL: https://github.com/apache/tez/pull/393#discussion_r1969471336
##########
tez-api/src/main/java/org/apache/tez/common/security/JobTokenSecretManager.java:
##########
@@ -37,11 +39,31 @@
@InterfaceAudience.Private
@InterfaceStability.Unstable
public class JobTokenSecretManager extends SecretManager<JobTokenIdentifier> {
- private static final String DEFAULT_HMAC_ALGORITHM = "HmacSHA1";
- private final SecretKey masterKey;
private final Map<String, SecretKey> currentJobTokens;
private final Mac mac;
+
+ /**
+ * @param conf a mandatory configuration for JobTokenSecretManager to prevent algorithm mismatch
+ */
+ public JobTokenSecretManager(Configuration conf) {
+ this(null, conf);
+ }
+
+ public JobTokenSecretManager(SecretKey key, Configuration conf) {
+ String algorithm = getAlgorithm(conf);
+ SecretKey masterKey = (key == null) ? generateSecret() : key;
+ this.currentJobTokens = new TreeMap<>();
+ try {
+ mac = Mac.getInstance(algorithm);
+ mac.init(masterKey);
+ } catch (NoSuchAlgorithmException nsa) {
+ throw new IllegalArgumentException("Can't find " + algorithm + " algorithm.", nsa);
+ } catch (InvalidKeyException ike) {
+ throw new IllegalArgumentException("Invalid key to HMAC computation", ike);
Review Comment:
Do we want to hardcode `HMAC` over here? ``InvalidKeyException`` can be thrown for other algorithms as well, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4600: Secret managers in Tez should respect the algorithm set by hadoop [tez]
Posted by "abstractdog (via GitHub)" <gi...@apache.org>.
abstractdog commented on code in PR #393:
URL: https://github.com/apache/tez/pull/393#discussion_r1969502619
##########
tez-api/src/main/java/org/apache/tez/common/security/JobTokenSecretManager.java:
##########
@@ -37,11 +39,31 @@
@InterfaceAudience.Private
@InterfaceStability.Unstable
public class JobTokenSecretManager extends SecretManager<JobTokenIdentifier> {
- private static final String DEFAULT_HMAC_ALGORITHM = "HmacSHA1";
- private final SecretKey masterKey;
private final Map<String, SecretKey> currentJobTokens;
private final Mac mac;
+
+ /**
+ * @param conf a mandatory configuration for JobTokenSecretManager to prevent algorithm mismatch
+ */
+ public JobTokenSecretManager(Configuration conf) {
+ this(null, conf);
+ }
+
+ public JobTokenSecretManager(SecretKey key, Configuration conf) {
+ String algorithm = getAlgorithm(conf);
+ SecretKey masterKey = (key == null) ? generateSecret() : key;
+ this.currentJobTokens = new TreeMap<>();
+ try {
+ mac = Mac.getInstance(algorithm);
+ mac.init(masterKey);
+ } catch (NoSuchAlgorithmException nsa) {
+ throw new IllegalArgumentException("Can't find " + algorithm + " algorithm.", nsa);
+ } catch (InvalidKeyException ike) {
+ throw new IllegalArgumentException("Invalid key to HMAC computation", ike);
Review Comment:
oh, right, this is a leftover from the default HMAC-era
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4600: Secret managers in Tez should respect the algorithm set by hadoop [tez]
Posted by "tez-yetus (via GitHub)" <gi...@apache.org>.
tez-yetus commented on PR #393:
URL: https://github.com/apache/tez/pull/393#issuecomment-2684729806
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 25m 6s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 12 new or modified test files. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 2m 0s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 10m 19s | master passed |
| +1 :green_heart: | compile | 3m 34s | master passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04 |
| +1 :green_heart: | compile | 3m 20s | master passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~22.04-b06 |
| +1 :green_heart: | checkstyle | 2m 48s | master passed |
| +1 :green_heart: | javadoc | 2m 57s | master passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04 |
| +1 :green_heart: | javadoc | 2m 43s | master passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~22.04-b06 |
| +0 :ok: | spotbugs | 0m 46s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 5m 57s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 18s | the patch passed |
| +1 :green_heart: | compile | 2m 19s | the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04 |
| +1 :green_heart: | javac | 2m 19s | the patch passed |
| +1 :green_heart: | compile | 2m 6s | the patch passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~22.04-b06 |
| +1 :green_heart: | javac | 2m 6s | the patch passed |
| -0 :warning: | checkstyle | 0m 13s | tez-api: The patch generated 1 new + 41 unchanged - 1 fixed = 42 total (was 42) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 1m 32s | the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04 |
| +1 :green_heart: | javadoc | 1m 29s | the patch passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~22.04-b06 |
| +1 :green_heart: | findbugs | 5m 23s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 16s | tez-api in the patch passed. |
| +1 :green_heart: | unit | 5m 47s | tez-runtime-library in the patch passed. |
| +1 :green_heart: | unit | 1m 23s | tez-mapreduce in the patch passed. |
| +1 :green_heart: | unit | 5m 5s | tez-dag in the patch passed. |
| +1 :green_heart: | unit | 4m 32s | tez-ext-service-tests in the patch passed. |
| +1 :green_heart: | unit | 2m 50s | tez-aux-services in the patch passed. |
| +1 :green_heart: | asflicense | 0m 55s | The patch does not generate ASF License warnings. |
| | | 100m 56s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-393/4/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/tez/pull/393 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile |
| uname | Linux a4dd1a21cd29 5.15.0-131-generic #141-Ubuntu SMP Fri Jan 10 21:18:28 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / 82b3476e0 |
| Default Java | Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~22.04-b06 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~22.04-b06 |
| checkstyle | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-393/4/artifact/out/diff-checkstyle-tez-api.txt |
| Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-393/4/testReport/ |
| Max. process+thread count | 2100 (vs. ulimit of 5500) |
| modules | C: tez-api tez-runtime-library tez-mapreduce tez-dag tez-ext-service-tests tez-plugins/tez-aux-services U: . |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-393/4/console |
| versions | git=2.34.1 maven=3.6.3 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4600: Secret managers in Tez should respect the algorithm set by hadoop [tez]
Posted by "abstractdog (via GitHub)" <gi...@apache.org>.
abstractdog commented on PR #393:
URL: https://github.com/apache/tez/pull/393#issuecomment-2684782813
changed hadoop enums to strings until TEZ-4607
merging this soon assuming that @ayushtkn 's approval still holds
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4600: Secret managers in Tez should respect the algorithm set by hadoop [tez]
Posted by "ayushtkn (via GitHub)" <gi...@apache.org>.
ayushtkn merged PR #393:
URL: https://github.com/apache/tez/pull/393
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4600: Secret managers in Tez should respect the algorithm set by hadoop [tez]
Posted by "tez-yetus (via GitHub)" <gi...@apache.org>.
tez-yetus commented on PR #393:
URL: https://github.com/apache/tez/pull/393#issuecomment-2681995826
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 38s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 10 new or modified test files. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 2m 51s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 9m 44s | master passed |
| +1 :green_heart: | compile | 5m 45s | master passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04 |
| +1 :green_heart: | compile | 5m 24s | master passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~22.04-b06 |
| +1 :green_heart: | checkstyle | 3m 58s | master passed |
| +1 :green_heart: | javadoc | 4m 7s | master passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04 |
| +1 :green_heart: | javadoc | 3m 50s | master passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~22.04-b06 |
| +0 :ok: | spotbugs | 5m 47s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 11m 29s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 57s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 7m 11s | the patch passed |
| +1 :green_heart: | compile | 6m 6s | the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04 |
| +1 :green_heart: | javac | 6m 6s | the patch passed |
| +1 :green_heart: | compile | 5m 39s | the patch passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~22.04-b06 |
| +1 :green_heart: | javac | 5m 39s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 28s | tez-api: The patch generated 0 new + 41 unchanged - 1 fixed = 41 total (was 42) |
| +1 :green_heart: | checkstyle | 0m 31s | The patch passed checkstyle in tez-runtime-library |
| +1 :green_heart: | checkstyle | 0m 25s | The patch passed checkstyle in tez-mapreduce |
| +1 :green_heart: | checkstyle | 0m 35s | The patch passed checkstyle in tez-dag |
| +1 :green_heart: | checkstyle | 0m 24s | The patch passed checkstyle in tez-ext-service-tests |
| +1 :green_heart: | checkstyle | 0m 23s | The patch passed checkstyle in tez-aux-services |
| +1 :green_heart: | checkstyle | 0m 58s | root: The patch generated 0 new + 329 unchanged - 1 fixed = 329 total (was 330) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 3m 56s | the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04 |
| +1 :green_heart: | javadoc | 3m 52s | the patch passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~22.04-b06 |
| +1 :green_heart: | findbugs | 12m 23s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 45s | tez-api in the patch passed. |
| +1 :green_heart: | unit | 0m 36s | tez-runtime-library in the patch passed. |
| +1 :green_heart: | unit | 0m 34s | tez-mapreduce in the patch passed. |
| +1 :green_heart: | unit | 0m 41s | tez-dag in the patch passed. |
| +1 :green_heart: | unit | 0m 35s | tez-ext-service-tests in the patch passed. |
| +1 :green_heart: | unit | 0m 33s | tez-aux-services in the patch passed. |
| +1 :green_heart: | unit | 3m 17s | root in the patch passed. |
| +1 :green_heart: | asflicense | 2m 38s | The patch does not generate ASF License warnings. |
| | | 105m 9s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-393/3/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/tez/pull/393 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile spotbugs findbugs checkstyle |
| uname | Linux 64af6b038ae0 5.15.0-130-generic #140-Ubuntu SMP Wed Dec 18 17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / 82b3476e0 |
| Default Java | Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~22.04-b06 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~22.04-b06 |
| Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-393/3/testReport/ |
| Max. process+thread count | 101 (vs. ulimit of 5500) |
| modules | C: tez-api tez-runtime-library tez-mapreduce tez-dag tez-ext-service-tests tez-plugins/tez-aux-services . U: . |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-393/3/console |
| versions | git=2.34.1 maven=3.6.3 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4600: Secret managers in Tez should respect the algorithm set by hadoop [tez]
Posted by "tez-yetus (via GitHub)" <gi...@apache.org>.
tez-yetus commented on PR #393:
URL: https://github.com/apache/tez/pull/393#issuecomment-2696719724
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 25m 44s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 12 new or modified test files. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 2m 5s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 9m 45s | master passed |
| +1 :green_heart: | compile | 3m 30s | master passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04 |
| +1 :green_heart: | compile | 3m 13s | master passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~22.04-b06 |
| +1 :green_heart: | checkstyle | 2m 43s | master passed |
| +1 :green_heart: | javadoc | 2m 39s | master passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04 |
| +1 :green_heart: | javadoc | 2m 29s | master passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~22.04-b06 |
| +0 :ok: | spotbugs | 0m 41s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 5m 29s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 11s | the patch passed |
| +1 :green_heart: | compile | 2m 7s | the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04 |
| +1 :green_heart: | javac | 2m 7s | the patch passed |
| +1 :green_heart: | compile | 1m 56s | the patch passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~22.04-b06 |
| +1 :green_heart: | javac | 1m 56s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 12s | tez-api: The patch generated 0 new + 41 unchanged - 1 fixed = 41 total (was 42) |
| +1 :green_heart: | checkstyle | 0m 16s | The patch passed checkstyle in tez-runtime-library |
| +1 :green_heart: | checkstyle | 0m 10s | The patch passed checkstyle in tez-mapreduce |
| +1 :green_heart: | checkstyle | 0m 19s | The patch passed checkstyle in tez-dag |
| +1 :green_heart: | checkstyle | 0m 10s | The patch passed checkstyle in tez-ext-service-tests |
| +1 :green_heart: | checkstyle | 0m 10s | The patch passed checkstyle in tez-aux-services |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 1m 22s | the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04 |
| +1 :green_heart: | javadoc | 1m 21s | the patch passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~22.04-b06 |
| +1 :green_heart: | findbugs | 5m 1s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 11s | tez-api in the patch passed. |
| +1 :green_heart: | unit | 6m 17s | tez-runtime-library in the patch passed. |
| +1 :green_heart: | unit | 1m 21s | tez-mapreduce in the patch passed. |
| +1 :green_heart: | unit | 5m 1s | tez-dag in the patch passed. |
| +1 :green_heart: | unit | 4m 43s | tez-ext-service-tests in the patch passed. |
| +1 :green_heart: | unit | 2m 51s | tez-aux-services in the patch passed. |
| +1 :green_heart: | asflicense | 0m 53s | The patch does not generate ASF License warnings. |
| | | 98m 44s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-393/5/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/tez/pull/393 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile |
| uname | Linux c3870ff10f60 5.15.0-131-generic #141-Ubuntu SMP Fri Jan 10 21:18:28 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / 82b3476e0 |
| Default Java | Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~22.04-b06 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~22.04-b06 |
| Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-393/5/testReport/ |
| Max. process+thread count | 1534 (vs. ulimit of 5500) |
| modules | C: tez-api tez-runtime-library tez-mapreduce tez-dag tez-ext-service-tests tez-plugins/tez-aux-services U: . |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-393/5/console |
| versions | git=2.34.1 maven=3.6.3 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4600: Secret managers in Tez should respect the algorithm set by hadoop [tez]
Posted by "tez-yetus (via GitHub)" <gi...@apache.org>.
tez-yetus commented on PR #393:
URL: https://github.com/apache/tez/pull/393#issuecomment-2681664818
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 25m 45s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 10 new or modified test files. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 2m 54s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 9m 51s | master passed |
| +1 :green_heart: | compile | 5m 50s | master passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04 |
| +1 :green_heart: | compile | 5m 26s | master passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~22.04-b06 |
| +1 :green_heart: | checkstyle | 4m 0s | master passed |
| +1 :green_heart: | javadoc | 4m 12s | master passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04 |
| +1 :green_heart: | javadoc | 3m 52s | master passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~22.04-b06 |
| +0 :ok: | spotbugs | 5m 47s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 11m 29s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 1m 3s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 7m 1s | the patch passed |
| +1 :green_heart: | compile | 6m 8s | the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04 |
| +1 :green_heart: | javac | 6m 8s | the patch passed |
| +1 :green_heart: | compile | 5m 44s | the patch passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~22.04-b06 |
| +1 :green_heart: | javac | 5m 44s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 26s | tez-api: The patch generated 0 new + 41 unchanged - 1 fixed = 41 total (was 42) |
| +1 :green_heart: | checkstyle | 0m 31s | The patch passed checkstyle in tez-runtime-library |
| +1 :green_heart: | checkstyle | 0m 25s | The patch passed checkstyle in tez-mapreduce |
| +1 :green_heart: | checkstyle | 0m 36s | The patch passed checkstyle in tez-dag |
| +1 :green_heart: | checkstyle | 0m 24s | The patch passed checkstyle in tez-ext-service-tests |
| -0 :warning: | checkstyle | 0m 24s | tez-plugins/tez-aux-services: The patch generated 1 new + 65 unchanged - 0 fixed = 66 total (was 65) |
| -0 :warning: | checkstyle | 1m 0s | root: The patch generated 1 new + 329 unchanged - 1 fixed = 330 total (was 330) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 4m 6s | the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04 |
| +1 :green_heart: | javadoc | 3m 22s | the patch passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~22.04-b06 |
| +1 :green_heart: | findbugs | 12m 35s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 47s | tez-api in the patch passed. |
| +1 :green_heart: | unit | 0m 36s | tez-runtime-library in the patch passed. |
| +1 :green_heart: | unit | 0m 34s | tez-mapreduce in the patch passed. |
| +1 :green_heart: | unit | 0m 41s | tez-dag in the patch passed. |
| +1 :green_heart: | unit | 0m 34s | tez-ext-service-tests in the patch passed. |
| +1 :green_heart: | unit | 0m 32s | tez-aux-services in the patch passed. |
| +1 :green_heart: | unit | 3m 11s | root in the patch passed. |
| +1 :green_heart: | asflicense | 2m 41s | The patch does not generate ASF License warnings. |
| | | 130m 34s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-393/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/tez/pull/393 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile spotbugs findbugs checkstyle |
| uname | Linux b46208e797c3 5.15.0-130-generic #140-Ubuntu SMP Wed Dec 18 17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / 82b3476e0 |
| Default Java | Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~22.04-b06 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~22.04-b06 |
| checkstyle | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-393/2/artifact/out/diff-checkstyle-tez-plugins_tez-aux-services.txt |
| checkstyle | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-393/2/artifact/out/diff-checkstyle-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-393/2/testReport/ |
| Max. process+thread count | 101 (vs. ulimit of 5500) |
| modules | C: tez-api tez-runtime-library tez-mapreduce tez-dag tez-ext-service-tests tez-plugins/tez-aux-services . U: . |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-393/2/console |
| versions | git=2.34.1 maven=3.6.3 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4600: Secret managers in Tez should respect the algorithm set by hadoop [tez]
Posted by "abstractdog (via GitHub)" <gi...@apache.org>.
abstractdog commented on PR #393:
URL: https://github.com/apache/tez/pull/393#issuecomment-2682052499
tests passed
let me know @ayushtkn if this can be approved
we cannot merge until Hadoop 3.5.0, created [TEZ-4606](https://issues.apache.org/jira/browse/TEZ-4606) for blocking this jira
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4600: Secret managers in Tez should respect the algorithm set by hadoop [tez]
Posted by "abstractdog (via GitHub)" <gi...@apache.org>.
abstractdog commented on PR #393:
URL: https://github.com/apache/tez/pull/393#issuecomment-2696458709
> there is a checkstyle warning that has shown up for the unused import, we need to fix it before we merge
makes sense, I just pushed a commit to remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4600: Secret managers in Tez should respect the algorithm set by hadoop [tez]
Posted by "ayushtkn (via GitHub)" <gi...@apache.org>.
ayushtkn commented on PR #393:
URL: https://github.com/apache/tez/pull/393#issuecomment-2695764385
there is a checkstyle warning that has shown up for the unused import, we need to fix it before we merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4600: JobTokenSecretManager should respect the algorithm set by hadoop [tez]
Posted by "tez-yetus (via GitHub)" <gi...@apache.org>.
tez-yetus commented on PR #393:
URL: https://github.com/apache/tez/pull/393#issuecomment-2669069143
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 22s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 2m 35s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 9m 20s | master passed |
| +1 :green_heart: | compile | 2m 55s | master passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04 |
| +1 :green_heart: | compile | 2m 30s | master passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~22.04-b06 |
| +1 :green_heart: | checkstyle | 1m 25s | master passed |
| +1 :green_heart: | javadoc | 1m 48s | master passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04 |
| +1 :green_heart: | javadoc | 1m 38s | master passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~22.04-b06 |
| +0 :ok: | spotbugs | 5m 39s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 6m 54s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 53s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 13s | the patch passed |
| +1 :green_heart: | compile | 3m 2s | the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04 |
| +1 :green_heart: | javac | 3m 2s | the patch passed |
| +1 :green_heart: | compile | 2m 56s | the patch passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~22.04-b06 |
| +1 :green_heart: | javac | 2m 56s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 19s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 1m 48s | the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04 |
| +1 :green_heart: | javadoc | 1m 50s | the patch passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~22.04-b06 |
| +1 :green_heart: | findbugs | 7m 54s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 43s | tez-api in the patch passed. |
| +1 :green_heart: | unit | 3m 17s | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 53s | The patch does not generate ASF License warnings. |
| | | 61m 46s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-393/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/tez/pull/393 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile spotbugs findbugs checkstyle |
| uname | Linux 3bca46bd2c42 5.15.0-131-generic #141-Ubuntu SMP Fri Jan 10 21:18:28 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / 871866edd |
| Default Java | Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~22.04-b06 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~22.04-b06 |
| Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-393/1/testReport/ |
| Max. process+thread count | 100 (vs. ulimit of 5500) |
| modules | C: tez-api . U: . |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-393/1/console |
| versions | git=2.34.1 maven=3.6.3 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org