You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by michaelomichael <gi...@git.apache.org> on 2018/10/03 07:18:52 UTC

[GitHub] tomcat pull request #124: Allow empty 'Host' HTTP header

GitHub user michaelomichael opened a pull request:

    https://github.com/apache/tomcat/pull/124

    Allow empty 'Host' HTTP header

    Sending an empty string for the value of the 'Host' header no longer
    results in a 400 (Bad Request) response.  This new behaviour reflects
    RFC 7230 and is particularly helpful for load balancer ping-style
    requests, where there is often limited control over the HTTP request
    headers.
    
    https://bz.apache.org/bugzilla/show_bug.cgi?id=62739

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/michaelomichael/tomcat bug62739_allow_empty_host_header

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tomcat/pull/124.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #124
    
----
commit 747e1ae5192bc9da978ead09d251496ae2238480
Author: Michael Orr <mi...@...>
Date:   2018-10-02T17:09:44Z

    Allow empty 'Host' HTTP header
    
    Sending an empty string for the value of the 'Host' header no longer
    results in a 400 (Bad Request) response.  This new behaviour reflects
    RFC 7230 and is particularly helpful for load balancer ping-style
    requests, where there is often limited control over the HTTP request
    headers.
    
    https://bz.apache.org/bugzilla/show_bug.cgi?id=62739

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[GitHub] tomcat pull request #124: Allow empty 'Host' HTTP header

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/tomcat/pull/124


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[GitHub] tomcat issue #124: Allow empty 'Host' HTTP header

Posted by markt-asf <gi...@git.apache.org>.
Github user markt-asf commented on the issue:

    https://github.com/apache/tomcat/pull/124
  
    Nice catch with handling the port. The patch I had come up with missed that.
    I refactored populateHost() as it bugged me to set the server name one way (that might throw an IOE and break the request) only to immediately overwrite the result with an empty String.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org