You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jackwener (via GitHub)" <gi...@apache.org> on 2023/02/10 07:53:11 UTC
[GitHub] [arrow-datafusion] jackwener opened a new pull request, #5236: refactor: correct the implementation of `all_schemas()`
jackwener opened a new pull request, #5236:
URL: https://github.com/apache/arrow-datafusion/pull/5236
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #5192.
# Rationale for this change
Currently, all_schema() can return schema of child of child.
For example: plan is A join (B join C)
result will include B and C.
But, plan shouldn't get schema of child of child (and more).
It just should get info of itself and children.
# What changes are included in this PR?
Just return children schema and itself schema
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackwener commented on pull request #5236: refactor: correct the implementation of `all_schemas()`
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on PR #5236:
URL: https://github.com/apache/arrow-datafusion/pull/5236#issuecomment-1427027021
> I wonder if we can work on getting rid of it entirely.
This is my ultimate goal, I will continue to try to work on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5236: refactor: correct the implementation of `all_schemas()`
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #5236:
URL: https://github.com/apache/arrow-datafusion/pull/5236#discussion_r1103102991
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -177,59 +177,51 @@ impl LogicalPlan {
/// Get a vector of references to all schemas in every node of the logical plan
Review Comment:
I think we should update the docstring of this function to reflect its new purpose
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #5236: refactor: correct the implementation of `all_schemas()`
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #5236:
URL: https://github.com/apache/arrow-datafusion/pull/5236#issuecomment-1427041315
Benchmark runs are scheduled for baseline = 4eb1a57ffec82a8b3abd3ee266716921897f1630 and contender = 0f95966cc28d2ff55c225d8522027d61cdcdf4af. 0f95966cc28d2ff55c225d8522027d61cdcdf4af is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/af32feb3e45c4c86b5a61f6f451d6418...6cdda80b04654277a571e2005060ae2a/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/ac4745b44cee4f1799404d926da1253e...8b15e44da1b14d5589daae6e9eeb5c28/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/341b94d3ac4d40af9e4776617b142da9...590409b5b5ee49ae8246016b872a3538/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/da22109c10524b66af0aca297785c0a8...43f7896d01bc40139677135cd1f3fac5/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5236: refactor: correct the implementation of `all_schemas()`
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5236:
URL: https://github.com/apache/arrow-datafusion/pull/5236#issuecomment-1427040197
Thanks again @jackwener
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #5236: refactor: correct the implementation of `all_schemas()`
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #5236:
URL: https://github.com/apache/arrow-datafusion/pull/5236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org