You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/08/27 03:44:41 UTC
[GitHub] [dubbo-go-samples] sunrui1225 opened a new pull request #213: Config enhance rpc dubbo
sunrui1225 opened a new pull request #213:
URL: https://github.com/apache/dubbo-go-samples/pull/213
rpc dubbo samples enhance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] sunrui1225 commented on a change in pull request #213: Config enhance rpc dubbo
Posted by GitBox <gi...@apache.org>.
sunrui1225 commented on a change in pull request #213:
URL: https://github.com/apache/dubbo-go-samples/pull/213#discussion_r701728337
##########
File path: rpc/dubbo/go-client/cmd/client.go
##########
@@ -57,84 +49,84 @@ func main() {
time.Sleep(6 * time.Second)
- gxlog.CInfo("\n\ntest")
+ logger.Info("\n\ntest")
test()
}
func test() {
- gxlog.CInfo("\n\n\necho")
+ logger.Info("\n\n\necho")
res, err := userProvider.Echo(context.TODO(), "OK")
if err != nil {
panic(err)
}
- gxlog.CInfo("res: %v\n", res)
+ logger.Info("res: %v\n", res)
- gxlog.CInfo("\n\n\nstart to test dubbo")
+ logger.Info("\n\n\nstart to test dubbo")
user := &pkg.User{}
err = userProvider.GetUser(context.TODO(), []interface{}{"A003"}, user)
Review comment:
已经按照接口规范更改
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] LaurenceLiZhixin commented on pull request #213: Config enhance rpc dubbo
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on pull request #213:
URL: https://github.com/apache/dubbo-go-samples/pull/213#issuecomment-909790459
Pls add your samples' integrate test. @sunrui1225
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] LaurenceLiZhixin commented on a change in pull request #213: Config enhance rpc dubbo
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on a change in pull request #213:
URL: https://github.com/apache/dubbo-go-samples/pull/213#discussion_r697144163
##########
File path: rpc/dubbo/README_zh.md
##########
@@ -0,0 +1,22 @@
+# RPC Dubbo for Dubbo-go 3.0
+
+api 定义以及 go 客户端、服务端启动，可以参考 [dubbo-go 3.0 快速开始](https://dubbogo.github.io/zh-cn/docs/user/quickstart/3.0/quickstart.html)
+
+## 使用方法
+1. 启动 zookeeper
+
+2. 启动服务端
+
+使用 goland 启动 rpc-dubbo-go-server
+
+或者
+
+在 java-server 文件夹下执行 `rpc/dubbo/java-server/2.6/src/main/java/org/apache/dubbo/Provider#main()` 启动 java server
Review comment:
@sunrui1225 这个如何执行？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] LaurenceLiZhixin commented on pull request #213: Config enhance rpc dubbo
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on pull request #213:
URL: https://github.com/apache/dubbo-go-samples/pull/213#issuecomment-909790459
Pls add your samples' integrate test. @sunrui1225
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] LaurenceLiZhixin merged pull request #213: Config enhance rpc dubbo
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin merged pull request #213:
URL: https://github.com/apache/dubbo-go-samples/pull/213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] sunrui1225 commented on a change in pull request #213: Config enhance rpc dubbo
Posted by GitBox <gi...@apache.org>.
sunrui1225 commented on a change in pull request #213:
URL: https://github.com/apache/dubbo-go-samples/pull/213#discussion_r701201321
##########
File path: rpc/dubbo/go-server/conf/dubbogo.yml
##########
@@ -0,0 +1,45 @@
+# dubbo server yaml configure file
+
+dubbo:
+ registries:
+ "demoZK":
+ protocol: "zookeeper"
+ timeout: "3s"
+ address: "127.0.0.1:2181"
+ protocols:
+ "dubbo":
+ name: "dubbo"
+ port: 20000
+ provider:
+ registry:
+ - demoZK
+ services:
+ "UserProvider":
+ protocol: "dubbo"
+ interface: "org.apache.dubbo.UserProvider"
+ loadbalance: "random"
+ warmup: "100"
+ cluster: "failover"
+ methods:
+ - name: "GetUser"
+ retries: 1
+ loadbalance: "random"
+
+protocol_conf:
Review comment:
已经去掉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] LaurenceLiZhixin commented on a change in pull request #213: Config enhance rpc dubbo
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on a change in pull request #213:
URL: https://github.com/apache/dubbo-go-samples/pull/213#discussion_r697145339
##########
File path: rpc/dubbo/go-client/cmd/client.go
##########
@@ -57,84 +49,84 @@ func main() {
time.Sleep(6 * time.Second)
- gxlog.CInfo("\n\ntest")
+ logger.Info("\n\ntest")
test()
}
func test() {
- gxlog.CInfo("\n\n\necho")
+ logger.Info("\n\n\necho")
res, err := userProvider.Echo(context.TODO(), "OK")
if err != nil {
panic(err)
}
- gxlog.CInfo("res: %v\n", res)
+ logger.Info("res: %v\n", res)
- gxlog.CInfo("\n\n\nstart to test dubbo")
+ logger.Info("\n\n\nstart to test dubbo")
user := &pkg.User{}
err = userProvider.GetUser(context.TODO(), []interface{}{"A003"}, user)
Review comment:
我们按照新的接口规范定义samples的接口，摒弃这种旧的方式。https://www.yuque.com/docs/share/eff9c51f-a7f4-47d6-87ff-11a2152bdffe?#
相关的例子可以删掉了，只保留我们规范的接口即可。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] sunrui1225 commented on a change in pull request #213: Config enhance rpc dubbo
Posted by GitBox <gi...@apache.org>.
sunrui1225 commented on a change in pull request #213:
URL: https://github.com/apache/dubbo-go-samples/pull/213#discussion_r701201701
##########
File path: rpc/dubbo/README_zh.md
##########
@@ -0,0 +1,22 @@
+# RPC Dubbo for Dubbo-go 3.0
+
+api 定义以及 go 客户端、服务端启动，可以参考 [dubbo-go 3.0 快速开始](https://dubbogo.github.io/zh-cn/docs/user/quickstart/3.0/quickstart.html)
+
+## 使用方法
+1. 启动 zookeeper
+
+2. 启动服务端
+
+使用 goland 启动 rpc-dubbo-go-server
+
+或者
+
+在 java-server 文件夹下执行 `rpc/dubbo/java-server/2.6/src/main/java/org/apache/dubbo/Provider#main()` 启动 java server
Review comment:
添加了run.sh文件
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] LaurenceLiZhixin commented on a change in pull request #213: Config enhance rpc dubbo
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on a change in pull request #213:
URL: https://github.com/apache/dubbo-go-samples/pull/213#discussion_r697143655
##########
File path: rpc/dubbo/go-server/conf/dubbogo.yml
##########
@@ -0,0 +1,45 @@
+# dubbo server yaml configure file
+
+dubbo:
+ registries:
+ "demoZK":
+ protocol: "zookeeper"
+ timeout: "3s"
+ address: "127.0.0.1:2181"
+ protocols:
+ "dubbo":
+ name: "dubbo"
+ port: 20000
+ provider:
+ registry:
+ - demoZK
+ services:
+ "UserProvider":
+ protocol: "dubbo"
+ interface: "org.apache.dubbo.UserProvider"
+ loadbalance: "random"
+ warmup: "100"
+ cluster: "failover"
+ methods:
+ - name: "GetUser"
+ retries: 1
+ loadbalance: "random"
+
+protocol_conf:
Review comment:
@zhaoyunxing92 这块怎么搞？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org