You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/07/27 23:34:21 UTC
[jira] [Commented] (CB-8978) Adding New Image Element to config.xml
[ https://issues.apache.org/jira/browse/CB-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15396657#comment-15396657 ]
ASF GitHub Bot commented on CB-8978:
------------------------------------
GitHub user dpogue opened a pull request:
https://github.com/apache/cordova-lib/pull/468
CB-8978 Add resource-file parsing to config.xml
Original JIRA issue https://issues.apache.org/jira/browse/CB-8978
Related to/replaces https://github.com/apache/cordova-lib/pull/214
See also https://github.com/cordova/cordova-discuss/issues/6
This is just the first pass, we'll also need to update the platform API in each platform to actually copy the resource files around on prepare.
This returns the same data structure as the PluginInfo class. To be determined if we think having top-level `resource-file` elements makes sense, it appears that plugin.xml does not support them.
/cc @ktop @jcesarmobile
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dpogue/cordova-lib resource-file
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/468.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #468
----
commit 552ce1da2932ccf43b2a137c641fcb90a4bfc27b
Author: Darryl Pogue <da...@ayogo.com>
Date: 2016-07-27T23:28:08Z
CB-8978 Add resource-file parsing to config.xml
----
> Adding New Image Element to config.xml
> --------------------------------------
>
> Key: CB-8978
> URL: https://issues.apache.org/jira/browse/CB-8978
> Project: Apache Cordova
> Issue Type: New Feature
> Components: CLI, CordovaLib
> Affects Versions: Master
> Environment: Android, iOS, WP8, Windows, Blackberry
> Reporter: Karen Tran
> Assignee: Karen Tran
> Labels: config.xml, images
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> At present, there are only an icon element and splashscreen element that handles copying images from a source to destination in the config.xml. These elements also only handle copying 1 image only and replacing what was previously there as the icon.png or splash.png.
> I'm creating a new tag that will copy non-main app icon images, which could be notification icons, button icons, custom image text, etc. and not limited to just 1 image.
> Example:
> <image src="res/android/notification.png" name="notification.png" />
> <image src="res/android/notification-mdpi.png" name="notification.png" density="mdpi" />
> The required attributes will be src and name.
> Depending on the directory that the image gets copied to, the width and height attribute may not be needed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org