You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2016/04/04 21:40:06 UTC
Review Request 45701: Remove TaskQuery from killTasks RPC.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45701/
-----------------------------------------------------------
Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Bugs: AURORA-1591 and AURORA-1592
https://issues.apache.org/jira/browse/AURORA-1591
https://issues.apache.org/jira/browse/AURORA-1592
Repository: aurora
Description
-------
This also implicitly pulled out the wildcard auth support that only existed to support `TaskQuery`.
Diffs
-----
api/src/main/thrift/org/apache/aurora/gen/api.thrift d4b8904031e6671a8083cac9b82d934377797fe2
src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java d9039c935bb11f218558924609906b4b178711ec
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7eda474622388eb41695b65a4b349f416409a467
src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java f2f69f9d7c34bbd24aaa7cb90455f32ebf9aa2cd
src/main/python/apache/aurora/client/api/__init__.py c5469bd89e57465e75a7c20c897a0bf9ce23c6f7
src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java dbec26ffb852c7804365467fbc00bb4efe19f2fb
src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java a70473074c3cf21e4395241217b6b3f694f346ea
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 85ca86cb333ec023c0cfd8379ac3308b83b6686f
Diff: https://reviews.apache.org/r/45701/diff/
Testing
-------
Build and end-to-end tests are green.
Thanks,
Bill Farner
Re: Review Request 45701: Remove TaskQuery from killTasks RPC.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45701/#review127399
-----------------------------------------------------------
Master (ddbb965) is red with this patch.
./build-support/jenkins/build.sh
[1m start = time.time()[0m
[1m while not self._terminating.is_set() and ([0m
[1m time.time() - start) < self.RPC_MAXIMUM_WAIT.as_(Time.SECONDS):[0m
[1m [0m
[1m try:[0m
[1m method = getattr(self.client(), method_name)[0m
[1m if not callable(method):[0m
[1m return method[0m
[1m [0m
[1m resp = method(*args)[0m
[1m if resp is not None and resp.responseCode == ResponseCode.ERROR_TRANSIENT:[0m
[1m raise self.TransientError(", ".join([0m
[1m [m.message for m in resp.details] if resp.details else []))[0m
[1m return resp[0m
[1m except TRequestsTransport.AuthError as e:[0m
[1m log.error(self.scheduler_client().get_failed_auth_message())[0m
[1m raise self.AuthError(e)[0m
[1m except (TTransport.TTransportException, self.TimeoutError, self.TransientError) as e:[0m
[1m if not self._terminating.is_set():[0m
[1m log.warning('Connection error with scheduler: %s, reconnecting...' % e)[0m
[1m self.invalidate()[0m
[1m self._terminating.wait(self.RPC_RETRY_INTERVAL.as_(Time.SECONDS))[0m
[1m except Exception as e:[0m
[1m # Take any error that occurs during the RPC call, and transform it[0m
[1m # into something clients can handle.[0m
[1m if not self._terminating.is_set():[0m
[1m raise self.ThriftInternalError("Error during thrift call %s to %s: %s" %[0m
[1m> (method_name, self.cluster.name, e))[0m
[1m[31mE ThriftInternalError: Error during thrift call killTasks to local: <lambda>() takes exactly 3 arguments (4 given)[0m
.pants.d/python-setup/chroots/72cb2c90cf0cd6d21e8887bca95f002178ed28f6/apache/aurora/client/api/scheduler_client.py:334: ThriftInternalError
generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
[1m[31m 2 failed, 663 passed, 5 skipped, 1 warnings in 208.42 seconds [0m
FAILURE
[32m
Waiting for background workers to finish.[0m
18:15:09 04:31 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 6, 2016, 5:37 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45701/
> -----------------------------------------------------------
>
> (Updated April 6, 2016, 5:37 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-1591 and AURORA-1592
> https://issues.apache.org/jira/browse/AURORA-1591
> https://issues.apache.org/jira/browse/AURORA-1592
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This also implicitly pulled out the wildcard auth support that only existed to support `TaskQuery`.
>
>
> Diffs
> -----
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift 2412490b40f4836ac9e1d01aeb91f0e1e8c17028
> src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java e32862034a1ad47dae8fff89cb04deb34ccd90e2
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java d9039c935bb11f218558924609906b4b178711ec
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 9e6ea3c7b6d25e1c2c32a499246612fb2ca8a34b
> src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java f2959921d77ba4c1407a19fe7c752116cea47e26
> src/main/python/apache/aurora/client/api/__init__.py 18a10e224ec5ea88aee4315672ee84a4505473af
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java 903121767778bf9451636bb8bae7e1c7b5af9ea8
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 503f0c34eafb970085d98b2786c73e4d28ba8184
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 2b557e2c20127e86114f8277ae5b2954d6c4bc2e
> src/test/python/apache/aurora/api_util.py 1497332d266d00e5ae3b56dbde67539aadcf990d
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 0b14b09c8da5053501917e6b4b502714abc80b71
>
> Diff: https://reviews.apache.org/r/45701/diff/
>
>
> Testing
> -------
>
> Build and end-to-end tests are green.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 45701: Remove TaskQuery from killTasks RPC.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45701/#review127412
-----------------------------------------------------------
Ship it!
Master (ddbb965) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 6, 2016, 6:33 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45701/
> -----------------------------------------------------------
>
> (Updated April 6, 2016, 6:33 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-1591 and AURORA-1592
> https://issues.apache.org/jira/browse/AURORA-1591
> https://issues.apache.org/jira/browse/AURORA-1592
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This also implicitly pulled out the wildcard auth support that only existed to support `TaskQuery`.
>
>
> Diffs
> -----
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift 2412490b40f4836ac9e1d01aeb91f0e1e8c17028
> src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java e32862034a1ad47dae8fff89cb04deb34ccd90e2
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java d9039c935bb11f218558924609906b4b178711ec
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 9e6ea3c7b6d25e1c2c32a499246612fb2ca8a34b
> src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java f2959921d77ba4c1407a19fe7c752116cea47e26
> src/main/python/apache/aurora/client/api/__init__.py 18a10e224ec5ea88aee4315672ee84a4505473af
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java 903121767778bf9451636bb8bae7e1c7b5af9ea8
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 503f0c34eafb970085d98b2786c73e4d28ba8184
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 2b557e2c20127e86114f8277ae5b2954d6c4bc2e
> src/test/python/apache/aurora/api_util.py 1497332d266d00e5ae3b56dbde67539aadcf990d
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 0b14b09c8da5053501917e6b4b502714abc80b71
>
> Diff: https://reviews.apache.org/r/45701/diff/
>
>
> Testing
> -------
>
> Build and end-to-end tests are green.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 45701: Remove TaskQuery from killTasks RPC.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45701/
-----------------------------------------------------------
(Updated April 6, 2016, 11:33 a.m.)
Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Changes
-------
update python code to match post-rebase API changes
Bugs: AURORA-1591 and AURORA-1592
https://issues.apache.org/jira/browse/AURORA-1591
https://issues.apache.org/jira/browse/AURORA-1592
Repository: aurora
Description
-------
This also implicitly pulled out the wildcard auth support that only existed to support `TaskQuery`.
Diffs (updated)
-----
api/src/main/thrift/org/apache/aurora/gen/api.thrift 2412490b40f4836ac9e1d01aeb91f0e1e8c17028
src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java e32862034a1ad47dae8fff89cb04deb34ccd90e2
src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java d9039c935bb11f218558924609906b4b178711ec
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 9e6ea3c7b6d25e1c2c32a499246612fb2ca8a34b
src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java f2959921d77ba4c1407a19fe7c752116cea47e26
src/main/python/apache/aurora/client/api/__init__.py 18a10e224ec5ea88aee4315672ee84a4505473af
src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java 903121767778bf9451636bb8bae7e1c7b5af9ea8
src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 503f0c34eafb970085d98b2786c73e4d28ba8184
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 2b557e2c20127e86114f8277ae5b2954d6c4bc2e
src/test/python/apache/aurora/api_util.py 1497332d266d00e5ae3b56dbde67539aadcf990d
src/test/python/apache/aurora/client/api/test_scheduler_client.py 0b14b09c8da5053501917e6b4b502714abc80b71
Diff: https://reviews.apache.org/r/45701/diff/
Testing
-------
Build and end-to-end tests are green.
Thanks,
Bill Farner
Re: Review Request 45701: Remove TaskQuery from killTasks RPC.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45701/
-----------------------------------------------------------
(Updated April 6, 2016, 10:37 a.m.)
Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Changes
-------
rebase
Bugs: AURORA-1591 and AURORA-1592
https://issues.apache.org/jira/browse/AURORA-1591
https://issues.apache.org/jira/browse/AURORA-1592
Repository: aurora
Description
-------
This also implicitly pulled out the wildcard auth support that only existed to support `TaskQuery`.
Diffs (updated)
-----
api/src/main/thrift/org/apache/aurora/gen/api.thrift 2412490b40f4836ac9e1d01aeb91f0e1e8c17028
src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java e32862034a1ad47dae8fff89cb04deb34ccd90e2
src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java d9039c935bb11f218558924609906b4b178711ec
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 9e6ea3c7b6d25e1c2c32a499246612fb2ca8a34b
src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java f2959921d77ba4c1407a19fe7c752116cea47e26
src/main/python/apache/aurora/client/api/__init__.py 18a10e224ec5ea88aee4315672ee84a4505473af
src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java 903121767778bf9451636bb8bae7e1c7b5af9ea8
src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 503f0c34eafb970085d98b2786c73e4d28ba8184
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 2b557e2c20127e86114f8277ae5b2954d6c4bc2e
src/test/python/apache/aurora/api_util.py 1497332d266d00e5ae3b56dbde67539aadcf990d
src/test/python/apache/aurora/client/api/test_scheduler_client.py 0b14b09c8da5053501917e6b4b502714abc80b71
Diff: https://reviews.apache.org/r/45701/diff/
Testing
-------
Build and end-to-end tests are green.
Thanks,
Bill Farner
Re: Review Request 45701: Remove TaskQuery from killTasks RPC.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45701/#review126955
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On April 4, 2016, 9:30 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45701/
> -----------------------------------------------------------
>
> (Updated April 4, 2016, 9:30 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-1591 and AURORA-1592
> https://issues.apache.org/jira/browse/AURORA-1591
> https://issues.apache.org/jira/browse/AURORA-1592
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This also implicitly pulled out the wildcard auth support that only existed to support `TaskQuery`.
>
>
> Diffs
> -----
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift d4b8904031e6671a8083cac9b82d934377797fe2
> src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java e32862034a1ad47dae8fff89cb04deb34ccd90e2
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java d9039c935bb11f218558924609906b4b178711ec
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7eda474622388eb41695b65a4b349f416409a467
> src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java f2f69f9d7c34bbd24aaa7cb90455f32ebf9aa2cd
> src/main/python/apache/aurora/client/api/__init__.py c5469bd89e57465e75a7c20c897a0bf9ce23c6f7
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java dbec26ffb852c7804365467fbc00bb4efe19f2fb
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java a70473074c3cf21e4395241217b6b3f694f346ea
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 85ca86cb333ec023c0cfd8379ac3308b83b6686f
> src/test/python/apache/aurora/api_util.py 4bb306fe577864c8611b6a34466b2189d903f103
> src/test/python/apache/aurora/client/api/test_scheduler_client.py bed800d838d63ef76ec8f48d7c34cc0b165c26a2
>
> Diff: https://reviews.apache.org/r/45701/diff/
>
>
> Testing
> -------
>
> Build and end-to-end tests are green.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 45701: Remove TaskQuery from killTasks RPC.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45701/#review126952
-----------------------------------------------------------
Ship it!
Master (9847b02) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 4, 2016, 9:30 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45701/
> -----------------------------------------------------------
>
> (Updated April 4, 2016, 9:30 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-1591 and AURORA-1592
> https://issues.apache.org/jira/browse/AURORA-1591
> https://issues.apache.org/jira/browse/AURORA-1592
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This also implicitly pulled out the wildcard auth support that only existed to support `TaskQuery`.
>
>
> Diffs
> -----
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift d4b8904031e6671a8083cac9b82d934377797fe2
> src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java e32862034a1ad47dae8fff89cb04deb34ccd90e2
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java d9039c935bb11f218558924609906b4b178711ec
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7eda474622388eb41695b65a4b349f416409a467
> src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java f2f69f9d7c34bbd24aaa7cb90455f32ebf9aa2cd
> src/main/python/apache/aurora/client/api/__init__.py c5469bd89e57465e75a7c20c897a0bf9ce23c6f7
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java dbec26ffb852c7804365467fbc00bb4efe19f2fb
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java a70473074c3cf21e4395241217b6b3f694f346ea
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 85ca86cb333ec023c0cfd8379ac3308b83b6686f
> src/test/python/apache/aurora/api_util.py 4bb306fe577864c8611b6a34466b2189d903f103
> src/test/python/apache/aurora/client/api/test_scheduler_client.py bed800d838d63ef76ec8f48d7c34cc0b165c26a2
>
> Diff: https://reviews.apache.org/r/45701/diff/
>
>
> Testing
> -------
>
> Build and end-to-end tests are green.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 45701: Remove TaskQuery from killTasks RPC.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45701/#review127354
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On April 4, 2016, 2:30 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45701/
> -----------------------------------------------------------
>
> (Updated April 4, 2016, 2:30 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-1591 and AURORA-1592
> https://issues.apache.org/jira/browse/AURORA-1591
> https://issues.apache.org/jira/browse/AURORA-1592
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This also implicitly pulled out the wildcard auth support that only existed to support `TaskQuery`.
>
>
> Diffs
> -----
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift d4b8904031e6671a8083cac9b82d934377797fe2
> src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java e32862034a1ad47dae8fff89cb04deb34ccd90e2
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java d9039c935bb11f218558924609906b4b178711ec
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7eda474622388eb41695b65a4b349f416409a467
> src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java f2f69f9d7c34bbd24aaa7cb90455f32ebf9aa2cd
> src/main/python/apache/aurora/client/api/__init__.py c5469bd89e57465e75a7c20c897a0bf9ce23c6f7
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java dbec26ffb852c7804365467fbc00bb4efe19f2fb
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java a70473074c3cf21e4395241217b6b3f694f346ea
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 85ca86cb333ec023c0cfd8379ac3308b83b6686f
> src/test/python/apache/aurora/api_util.py 4bb306fe577864c8611b6a34466b2189d903f103
> src/test/python/apache/aurora/client/api/test_scheduler_client.py bed800d838d63ef76ec8f48d7c34cc0b165c26a2
>
> Diff: https://reviews.apache.org/r/45701/diff/
>
>
> Testing
> -------
>
> Build and end-to-end tests are green.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 45701: Remove TaskQuery from killTasks RPC.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45701/
-----------------------------------------------------------
(Updated April 4, 2016, 2:30 p.m.)
Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Bugs: AURORA-1591 and AURORA-1592
https://issues.apache.org/jira/browse/AURORA-1591
https://issues.apache.org/jira/browse/AURORA-1592
Repository: aurora
Description
-------
This also implicitly pulled out the wildcard auth support that only existed to support `TaskQuery`.
Diffs (updated)
-----
api/src/main/thrift/org/apache/aurora/gen/api.thrift d4b8904031e6671a8083cac9b82d934377797fe2
src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java e32862034a1ad47dae8fff89cb04deb34ccd90e2
src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java d9039c935bb11f218558924609906b4b178711ec
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7eda474622388eb41695b65a4b349f416409a467
src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java f2f69f9d7c34bbd24aaa7cb90455f32ebf9aa2cd
src/main/python/apache/aurora/client/api/__init__.py c5469bd89e57465e75a7c20c897a0bf9ce23c6f7
src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java dbec26ffb852c7804365467fbc00bb4efe19f2fb
src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java a70473074c3cf21e4395241217b6b3f694f346ea
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 85ca86cb333ec023c0cfd8379ac3308b83b6686f
src/test/python/apache/aurora/api_util.py 4bb306fe577864c8611b6a34466b2189d903f103
src/test/python/apache/aurora/client/api/test_scheduler_client.py bed800d838d63ef76ec8f48d7c34cc0b165c26a2
Diff: https://reviews.apache.org/r/45701/diff/
Testing
-------
Build and end-to-end tests are green.
Thanks,
Bill Farner
Re: Review Request 45701: Remove TaskQuery from killTasks RPC.
Posted by Bill Farner <wf...@apache.org>.
> On April 4, 2016, 12:51 p.m., Maxim Khutornenko wrote:
> > Does this test still pass with your change? https://github.com/apache/aurora/blob/master/src/test/python/apache/aurora/api_util.py#L88
All green now.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45701/#review126921
-----------------------------------------------------------
On April 4, 2016, 12:40 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45701/
> -----------------------------------------------------------
>
> (Updated April 4, 2016, 12:40 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-1591 and AURORA-1592
> https://issues.apache.org/jira/browse/AURORA-1591
> https://issues.apache.org/jira/browse/AURORA-1592
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This also implicitly pulled out the wildcard auth support that only existed to support `TaskQuery`.
>
>
> Diffs
> -----
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift d4b8904031e6671a8083cac9b82d934377797fe2
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java d9039c935bb11f218558924609906b4b178711ec
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7eda474622388eb41695b65a4b349f416409a467
> src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java f2f69f9d7c34bbd24aaa7cb90455f32ebf9aa2cd
> src/main/python/apache/aurora/client/api/__init__.py c5469bd89e57465e75a7c20c897a0bf9ce23c6f7
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java dbec26ffb852c7804365467fbc00bb4efe19f2fb
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java a70473074c3cf21e4395241217b6b3f694f346ea
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 85ca86cb333ec023c0cfd8379ac3308b83b6686f
>
> Diff: https://reviews.apache.org/r/45701/diff/
>
>
> Testing
> -------
>
> Build and end-to-end tests are green.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 45701: Remove TaskQuery from killTasks RPC.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45701/#review126921
-----------------------------------------------------------
Does this test still pass with your change? https://github.com/apache/aurora/blob/master/src/test/python/apache/aurora/api_util.py#L88
- Maxim Khutornenko
On April 4, 2016, 7:40 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45701/
> -----------------------------------------------------------
>
> (Updated April 4, 2016, 7:40 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-1591 and AURORA-1592
> https://issues.apache.org/jira/browse/AURORA-1591
> https://issues.apache.org/jira/browse/AURORA-1592
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This also implicitly pulled out the wildcard auth support that only existed to support `TaskQuery`.
>
>
> Diffs
> -----
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift d4b8904031e6671a8083cac9b82d934377797fe2
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java d9039c935bb11f218558924609906b4b178711ec
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7eda474622388eb41695b65a4b349f416409a467
> src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java f2f69f9d7c34bbd24aaa7cb90455f32ebf9aa2cd
> src/main/python/apache/aurora/client/api/__init__.py c5469bd89e57465e75a7c20c897a0bf9ce23c6f7
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java dbec26ffb852c7804365467fbc00bb4efe19f2fb
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java a70473074c3cf21e4395241217b6b3f694f346ea
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 85ca86cb333ec023c0cfd8379ac3308b83b6686f
>
> Diff: https://reviews.apache.org/r/45701/diff/
>
>
> Testing
> -------
>
> Build and end-to-end tests are green.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 45701: Remove TaskQuery from killTasks RPC.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45701/#review126924
-----------------------------------------------------------
Master (9847b02) is red with this patch.
./build-support/jenkins/build.sh
:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain
:compileTestJava/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java:38: Note: Wrote forwarder org.apache.aurora.scheduler.thrift.aop.MockDecoratedThriftForwarder
@Forward(AnnotatedAuroraAdmin.class)
^
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
:processTestResources
:testClasses
:checkstyleTest
:findbugsJmh
:findbugsMain
:findbugsTest
:licenseJmh UP-TO-DATE
:licenseMain UP-TO-DATE
:licenseTest UP-TO-DATE
:license UP-TO-DATE
:pmdJmh
:pmdMain
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java:270: Avoid unused private fields such as 'domain'.
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java:270: Perhaps 'domain' could be replaced by a local variable.
:pmdMain FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':pmdMain'.
> 2 PMD rule violations were found. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/pmd/main.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED
Total time: 6 mins 45.405 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 4, 2016, 7:40 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45701/
> -----------------------------------------------------------
>
> (Updated April 4, 2016, 7:40 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-1591 and AURORA-1592
> https://issues.apache.org/jira/browse/AURORA-1591
> https://issues.apache.org/jira/browse/AURORA-1592
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This also implicitly pulled out the wildcard auth support that only existed to support `TaskQuery`.
>
>
> Diffs
> -----
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift d4b8904031e6671a8083cac9b82d934377797fe2
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java d9039c935bb11f218558924609906b4b178711ec
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7eda474622388eb41695b65a4b349f416409a467
> src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java f2f69f9d7c34bbd24aaa7cb90455f32ebf9aa2cd
> src/main/python/apache/aurora/client/api/__init__.py c5469bd89e57465e75a7c20c897a0bf9ce23c6f7
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java dbec26ffb852c7804365467fbc00bb4efe19f2fb
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java a70473074c3cf21e4395241217b6b3f694f346ea
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 85ca86cb333ec023c0cfd8379ac3308b83b6686f
>
> Diff: https://reviews.apache.org/r/45701/diff/
>
>
> Testing
> -------
>
> Build and end-to-end tests are green.
>
>
> Thanks,
>
> Bill Farner
>
>