[GitHub] [spark] huaxingao commented on issue #27011: [SPARK-30354][ML] GBT reuse DecisionTreeMetadata among iterations

[GitBox <gi...@apache.org>]

huaxingao commented on issue #27011: [SPARK-30354][ML] GBT reuse DecisionTreeMetadata among iterations
URL: https://github.com/apache/spark/pull/27011#issuecomment-569147124
 
 
   The change looks good to me. I will wait for this PR to get merged in first, then I will change https://github.com/apache/spark/pull/26972 to pass the instr of GBTClassifier/GBTRegressor to impl/GBT,  and use it to log the metrics in the first tree building: 
   ```
       val firstTreeModel = RandomForest.run(input, treeStrategy, numTrees = 1,
         featureSubsetStrategy, seed = seed, instr = None,
         parentUID = None, precomputedMetadata = Some(metadata))
         .head.asInstanceOf[DecisionTreeRegressionModel]
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org