You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kylin.apache.org by Li Yang <li...@apache.org> on 2015/01/16 08:32:24 UTC
No write access to merge pull request
Hi Mentors
We have the first pull request to apache git mirror:
https://github.com/apache/incubator-kylin/pull/1
But Luke and me both have no "write access" in order to merge. Could you
advice?
Thanks
Yang
Re: No write access to merge pull request
Posted by Luke Han <lu...@apache.org>.
One idea:
1. Using this fork under KylinOLAP account as staging:
https://github.com/KylinOLAP/incubator-kylin
2. Each member fork and pull request to this repo.
3. Committer pull this repo to local and push to Apache Git Repo.
4. Committer handle other pull request as Julian doing now
It's more easy to handle such pull request without too many git command.
Just for you reference:)
Regards.
Luke
2015-01-16 16:41 GMT+08:00 Li Yang <li...@apache.org>:
> Understood. Let me try to survive.
>
> On Fri, Jan 16, 2015 at 4:24 PM, Julian Hyde <ju...@hydromatic.net>
> wrote:
>
> > If there is an easier way, I haven't found one! (There's plenty of room
> > for automation. You could write a shell script such that "doPullRequest
> > https://github.com/apache/incubator-kylin/pull/1" does the steps I just
> > described. And automated pre-commit testing would be very useful.)
> >
> > Pull request to apache git repo is not possible... pull requests are a
> > github concept, not a git concept.
> >
> > Julian
> >
> >
> > > On Jan 16, 2015, at 12:19 AM, Li Yang <li...@apache.org> wrote:
> > >
> > > ... Thanks Julian...
> > >
> > > Is there an easier way to accept external contribution? Maybe they
> > should
> > > pull request to Apache repo directly?
> > >
> > > On Fri, Jan 16, 2015 at 3:48 PM, Julian Hyde <ju...@gmail.com>
> > wrote:
> > >
> > >> PS Note that you are pushing to the Apache repo. It will magically
> > appear
> > >> in the github mirror shortly. You never write to the github mirror.
> > >>
> > >>> On Jan 15, 2015, at 11:46 PM, Julian Hyde <ju...@gmail.com>
> > wrote:
> > >>>
> > >>> It is not possible to accept the pull request via the github UI,
> > because
> > >> of the access control on the github mirror.
> > >>>
> > >>> I don't know whether the project's policy is to merge or to rebase.
> In
> > >> Calcite, we rebase. Here are the steps I would use to accept that pull
> > >> request using rebase:
> > >>>
> > >>> git config --list # check that user.name=something@apache.org
> > >>> git remote add origin
> > >> https://git-wip-us.apache.org/repos/asf/incubator-kylin.git # you
> > >> probably already have this
> > >>> git remote add shaofengshi git@github.com:
> > >> shaofengshi/incubator-kylin.git
> > >>> git fetch shaofengshi
> > >>> git checkout -b temp shaofengshi/inverted-index
> > >>> git rebase -i master # in case the pull request is a bit stale
> > >>> mvn clean && mvn install # make sure that it builds
> > >>> git checkout master
> > >>> git merge --ff-only temp
> > >>> mvn clean && mvn install # make sure that it still builds (somewhat
> > >> paranoid)
> > >>> git push origin master
> > >>>
> > >>> (Actually the pull request is to Apache inverted-index branch, but I
> > >> pretended it was a pull request to Apache master, to make the example
> > >> clearer. Change "master" to "inverted-index".)
> > >>>
> > >>> Julian
> > >>>
> > >>>
> > >>>> On Jan 15, 2015, at 11:32 PM, Li Yang <li...@apache.org> wrote:
> > >>>>
> > >>>> Hi Mentors
> > >>>>
> > >>>> We have the first pull request to apache git mirror:
> > >>>> https://github.com/apache/incubator-kylin/pull/1
> > >>>>
> > >>>> But Luke and me both have no "write access" in order to merge. Could
> > you
> > >>>> advice?
> > >>>>
> > >>>> Thanks
> > >>>> Yang
> > >>>
> > >>
> > >>
> >
> >
>
Re: No write access to merge pull request
Posted by Li Yang <li...@apache.org>.
Understood. Let me try to survive.
On Fri, Jan 16, 2015 at 4:24 PM, Julian Hyde <ju...@hydromatic.net> wrote:
> If there is an easier way, I haven't found one! (There's plenty of room
> for automation. You could write a shell script such that "doPullRequest
> https://github.com/apache/incubator-kylin/pull/1" does the steps I just
> described. And automated pre-commit testing would be very useful.)
>
> Pull request to apache git repo is not possible... pull requests are a
> github concept, not a git concept.
>
> Julian
>
>
> > On Jan 16, 2015, at 12:19 AM, Li Yang <li...@apache.org> wrote:
> >
> > ... Thanks Julian...
> >
> > Is there an easier way to accept external contribution? Maybe they
> should
> > pull request to Apache repo directly?
> >
> > On Fri, Jan 16, 2015 at 3:48 PM, Julian Hyde <ju...@gmail.com>
> wrote:
> >
> >> PS Note that you are pushing to the Apache repo. It will magically
> appear
> >> in the github mirror shortly. You never write to the github mirror.
> >>
> >>> On Jan 15, 2015, at 11:46 PM, Julian Hyde <ju...@gmail.com>
> wrote:
> >>>
> >>> It is not possible to accept the pull request via the github UI,
> because
> >> of the access control on the github mirror.
> >>>
> >>> I don't know whether the project's policy is to merge or to rebase. In
> >> Calcite, we rebase. Here are the steps I would use to accept that pull
> >> request using rebase:
> >>>
> >>> git config --list # check that user.name=something@apache.org
> >>> git remote add origin
> >> https://git-wip-us.apache.org/repos/asf/incubator-kylin.git # you
> >> probably already have this
> >>> git remote add shaofengshi git@github.com:
> >> shaofengshi/incubator-kylin.git
> >>> git fetch shaofengshi
> >>> git checkout -b temp shaofengshi/inverted-index
> >>> git rebase -i master # in case the pull request is a bit stale
> >>> mvn clean && mvn install # make sure that it builds
> >>> git checkout master
> >>> git merge --ff-only temp
> >>> mvn clean && mvn install # make sure that it still builds (somewhat
> >> paranoid)
> >>> git push origin master
> >>>
> >>> (Actually the pull request is to Apache inverted-index branch, but I
> >> pretended it was a pull request to Apache master, to make the example
> >> clearer. Change "master" to "inverted-index".)
> >>>
> >>> Julian
> >>>
> >>>
> >>>> On Jan 15, 2015, at 11:32 PM, Li Yang <li...@apache.org> wrote:
> >>>>
> >>>> Hi Mentors
> >>>>
> >>>> We have the first pull request to apache git mirror:
> >>>> https://github.com/apache/incubator-kylin/pull/1
> >>>>
> >>>> But Luke and me both have no "write access" in order to merge. Could
> you
> >>>> advice?
> >>>>
> >>>> Thanks
> >>>> Yang
> >>>
> >>
> >>
>
>
Re: No write access to merge pull request
Posted by Julian Hyde <ju...@hydromatic.net>.
If there is an easier way, I haven't found one! (There's plenty of room for automation. You could write a shell script such that "doPullRequest https://github.com/apache/incubator-kylin/pull/1" does the steps I just described. And automated pre-commit testing would be very useful.)
Pull request to apache git repo is not possible... pull requests are a github concept, not a git concept.
Julian
> On Jan 16, 2015, at 12:19 AM, Li Yang <li...@apache.org> wrote:
>
> ... Thanks Julian...
>
> Is there an easier way to accept external contribution? Maybe they should
> pull request to Apache repo directly?
>
> On Fri, Jan 16, 2015 at 3:48 PM, Julian Hyde <ju...@gmail.com> wrote:
>
>> PS Note that you are pushing to the Apache repo. It will magically appear
>> in the github mirror shortly. You never write to the github mirror.
>>
>>> On Jan 15, 2015, at 11:46 PM, Julian Hyde <ju...@gmail.com> wrote:
>>>
>>> It is not possible to accept the pull request via the github UI, because
>> of the access control on the github mirror.
>>>
>>> I don't know whether the project's policy is to merge or to rebase. In
>> Calcite, we rebase. Here are the steps I would use to accept that pull
>> request using rebase:
>>>
>>> git config --list # check that user.name=something@apache.org
>>> git remote add origin
>> https://git-wip-us.apache.org/repos/asf/incubator-kylin.git # you
>> probably already have this
>>> git remote add shaofengshi git@github.com:
>> shaofengshi/incubator-kylin.git
>>> git fetch shaofengshi
>>> git checkout -b temp shaofengshi/inverted-index
>>> git rebase -i master # in case the pull request is a bit stale
>>> mvn clean && mvn install # make sure that it builds
>>> git checkout master
>>> git merge --ff-only temp
>>> mvn clean && mvn install # make sure that it still builds (somewhat
>> paranoid)
>>> git push origin master
>>>
>>> (Actually the pull request is to Apache inverted-index branch, but I
>> pretended it was a pull request to Apache master, to make the example
>> clearer. Change "master" to "inverted-index".)
>>>
>>> Julian
>>>
>>>
>>>> On Jan 15, 2015, at 11:32 PM, Li Yang <li...@apache.org> wrote:
>>>>
>>>> Hi Mentors
>>>>
>>>> We have the first pull request to apache git mirror:
>>>> https://github.com/apache/incubator-kylin/pull/1
>>>>
>>>> But Luke and me both have no "write access" in order to merge. Could you
>>>> advice?
>>>>
>>>> Thanks
>>>> Yang
>>>
>>
>>
Re: No write access to merge pull request
Posted by Li Yang <li...@apache.org>.
... Thanks Julian...
Is there an easier way to accept external contribution? Maybe they should
pull request to Apache repo directly?
On Fri, Jan 16, 2015 at 3:48 PM, Julian Hyde <ju...@gmail.com> wrote:
> PS Note that you are pushing to the Apache repo. It will magically appear
> in the github mirror shortly. You never write to the github mirror.
>
> > On Jan 15, 2015, at 11:46 PM, Julian Hyde <ju...@gmail.com> wrote:
> >
> > It is not possible to accept the pull request via the github UI, because
> of the access control on the github mirror.
> >
> > I don't know whether the project's policy is to merge or to rebase. In
> Calcite, we rebase. Here are the steps I would use to accept that pull
> request using rebase:
> >
> > git config --list # check that user.name=something@apache.org
> > git remote add origin
> https://git-wip-us.apache.org/repos/asf/incubator-kylin.git # you
> probably already have this
> > git remote add shaofengshi git@github.com:
> shaofengshi/incubator-kylin.git
> > git fetch shaofengshi
> > git checkout -b temp shaofengshi/inverted-index
> > git rebase -i master # in case the pull request is a bit stale
> > mvn clean && mvn install # make sure that it builds
> > git checkout master
> > git merge --ff-only temp
> > mvn clean && mvn install # make sure that it still builds (somewhat
> paranoid)
> > git push origin master
> >
> > (Actually the pull request is to Apache inverted-index branch, but I
> pretended it was a pull request to Apache master, to make the example
> clearer. Change "master" to "inverted-index".)
> >
> > Julian
> >
> >
> >> On Jan 15, 2015, at 11:32 PM, Li Yang <li...@apache.org> wrote:
> >>
> >> Hi Mentors
> >>
> >> We have the first pull request to apache git mirror:
> >> https://github.com/apache/incubator-kylin/pull/1
> >>
> >> But Luke and me both have no "write access" in order to merge. Could you
> >> advice?
> >>
> >> Thanks
> >> Yang
> >
>
>
Re: No write access to merge pull request
Posted by Julian Hyde <ju...@gmail.com>.
PS Note that you are pushing to the Apache repo. It will magically appear in the github mirror shortly. You never write to the github mirror.
> On Jan 15, 2015, at 11:46 PM, Julian Hyde <ju...@gmail.com> wrote:
>
> It is not possible to accept the pull request via the github UI, because of the access control on the github mirror.
>
> I don't know whether the project's policy is to merge or to rebase. In Calcite, we rebase. Here are the steps I would use to accept that pull request using rebase:
>
> git config --list # check that user.name=something@apache.org
> git remote add origin https://git-wip-us.apache.org/repos/asf/incubator-kylin.git # you probably already have this
> git remote add shaofengshi git@github.com:shaofengshi/incubator-kylin.git
> git fetch shaofengshi
> git checkout -b temp shaofengshi/inverted-index
> git rebase -i master # in case the pull request is a bit stale
> mvn clean && mvn install # make sure that it builds
> git checkout master
> git merge --ff-only temp
> mvn clean && mvn install # make sure that it still builds (somewhat paranoid)
> git push origin master
>
> (Actually the pull request is to Apache inverted-index branch, but I pretended it was a pull request to Apache master, to make the example clearer. Change "master" to "inverted-index".)
>
> Julian
>
>
>> On Jan 15, 2015, at 11:32 PM, Li Yang <li...@apache.org> wrote:
>>
>> Hi Mentors
>>
>> We have the first pull request to apache git mirror:
>> https://github.com/apache/incubator-kylin/pull/1
>>
>> But Luke and me both have no "write access" in order to merge. Could you
>> advice?
>>
>> Thanks
>> Yang
>
Re: No write access to merge pull request
Posted by Julian Hyde <ju...@gmail.com>.
It is not possible to accept the pull request via the github UI, because of the access control on the github mirror.
I don't know whether the project's policy is to merge or to rebase. In Calcite, we rebase. Here are the steps I would use to accept that pull request using rebase:
git config --list # check that user.name=something@apache.org
git remote add origin https://git-wip-us.apache.org/repos/asf/incubator-kylin.git # you probably already have this
git remote add shaofengshi git@github.com:shaofengshi/incubator-kylin.git
git fetch shaofengshi
git checkout -b temp shaofengshi/inverted-index
git rebase -i master # in case the pull request is a bit stale
mvn clean && mvn install # make sure that it builds
git checkout master
git merge --ff-only temp
mvn clean && mvn install # make sure that it still builds (somewhat paranoid)
git push origin master
(Actually the pull request is to Apache inverted-index branch, but I pretended it was a pull request to Apache master, to make the example clearer. Change "master" to "inverted-index".)
Julian
> On Jan 15, 2015, at 11:32 PM, Li Yang <li...@apache.org> wrote:
>
> Hi Mentors
>
> We have the first pull request to apache git mirror:
> https://github.com/apache/incubator-kylin/pull/1
>
> But Luke and me both have no "write access" in order to merge. Could you
> advice?
>
> Thanks
> Yang