You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/10/02 11:28:29 UTC
[GitHub] [camel-k] llowinge opened a new pull request #1737: Fix doc: kamelet connect via direct endpoint
llowinge opened a new pull request #1737:
URL: https://github.com/apache/camel-k/pull/1737
Fixes wrong swapped definition of source/sink connection to direct endpoint + the formatting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] llowinge commented on pull request #1737: Fix doc: kamelet connect via direct endpoint
Posted by GitBox <gi...@apache.org>.
llowinge commented on pull request #1737:
URL: https://github.com/apache/camel-k/pull/1737#issuecomment-702703614
@nicolaferraro @astefanutti
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] llowinge commented on pull request #1737: Fix doc: kamelet connect via direct endpoint
Posted by GitBox <gi...@apache.org>.
llowinge commented on pull request #1737:
URL: https://github.com/apache/camel-k/pull/1737#issuecomment-702838524
@nicolaferraro Probably whole kamelets.adoc should be updated. I will close this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] lburgazzoli commented on pull request #1737: Fix doc: kamelet connect via direct endpoint
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on pull request #1737:
URL: https://github.com/apache/camel-k/pull/1737#issuecomment-702749411
> This changed in the runtime.
>
> @lburgazzoli isn't it a bit confusing? :D
what is confusing ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] nicolaferraro commented on a change in pull request #1737: Fix doc: kamelet connect via direct endpoint
Posted by GitBox <gi...@apache.org>.
nicolaferraro commented on a change in pull request #1737:
URL: https://github.com/apache/camel-k/pull/1737#discussion_r498836165
##########
File path: docs/modules/ROOT/pages/kamelets/kamelets.adoc
##########
@@ -497,8 +497,9 @@ spec:
----
Source and sink flows will connect to the outside route via the `direct:{{routeId}}` endpoint:
-- A source Kamelet must start **from** `direct:{{routeId}}`
-- A sink Kamelet must contain a call **to** `direct:{{routeId}}`
+
+- A source Kamelet must contain a call **to** `direct:{{routeId}}`
+- A sink Kamelet must start **from** `direct:{{routeId}}`
Review comment:
```suggestion
- A sink Kamelet must start **from** `kamelet:source`
```
##########
File path: docs/modules/ROOT/pages/kamelets/kamelets.adoc
##########
@@ -497,8 +497,9 @@ spec:
----
Source and sink flows will connect to the outside route via the `direct:{{routeId}}` endpoint:
-- A source Kamelet must start **from** `direct:{{routeId}}`
-- A sink Kamelet must contain a call **to** `direct:{{routeId}}`
+
+- A source Kamelet must contain a call **to** `direct:{{routeId}}`
Review comment:
```suggestion
- A source Kamelet must contain a call **to** `kamelet:sink`
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] llowinge closed pull request #1737: Fix doc: kamelet connect via direct endpoint
Posted by GitBox <gi...@apache.org>.
llowinge closed pull request #1737:
URL: https://github.com/apache/camel-k/pull/1737
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org