You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/11/17 16:04:00 UTC

[GitHub] [netbeans] jherkel opened a new pull request #2542: NETBEANS-5034 fix wrong javadoc error hint

jherkel opened a new pull request #2542:
URL: https://github.com/apache/netbeans/pull/2542


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] lkishalmi commented on pull request #2542: [NETBEANS-5034] fix wrong javadoc error hint

Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #2542:
URL: https://github.com/apache/netbeans/pull/2542#issuecomment-731773787


   It would be good to reason, why the original problem happened and how that condition removal fixes it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] jherkel commented on pull request #2542: [NETBEANS-5034] fix wrong javadoc error hint

Posted by GitBox <gi...@apache.org>.
jherkel commented on pull request #2542:
URL: https://github.com/apache/netbeans/pull/2542#issuecomment-731778714


   I think probably this PR https://github.com/apache/netbeans/pull/2470 caused this behaviour. After some studying of code I think that correct place where we can omit some html tags with optional end tag is in visitEndElement method, not visitStartElement. And there is a code :
   ```
   while (!tagStack.isEmpty()) {
   ....
   else if (tag != null && tag.hasOptionalEndTag()) {
   tagStack.pop();
   }
   ...
   ```
   which processes these start tags and remove them from stack.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] jlahoda commented on pull request #2542: [NETBEANS-5034] fix wrong javadoc error hint

Posted by GitBox <gi...@apache.org>.
jlahoda commented on pull request #2542:
URL: https://github.com/apache/netbeans/pull/2542#issuecomment-731947558


   I think this fix (removing `!t.hasOptionalEndTag()` in start element) is great.I'd suggest to add a test, like:
   
   ```
       public void testOptionalEndTag() throws Exception {
           HintTest.create()
                   .input(
                   "package test;\n" +
                   "/**\n" +
                   " * <ul><li>One<li>Two</li></ul>\n" +
                   " */\n" +
                   "class Zima {\n" +
                   "}\n")
                   .preference(AVAILABILITY_KEY + true, true)
                   .preference(SCOPE_KEY, "private")
                   .run(JavadocHint.class)
                   .assertWarnings();
       }
   ```
   
   in `java/javadoc/test/unit/src/org/netbeans/modules/javadoc/hints/Analyzer2Test.java`.
   
   Sorry for the trouble!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] lkishalmi merged pull request #2542: [NETBEANS-5034] fix wrong javadoc error hint

Posted by GitBox <gi...@apache.org>.
lkishalmi merged pull request #2542:
URL: https://github.com/apache/netbeans/pull/2542


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists