You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Konrad Windszus (Jira)" <ji...@apache.org> on 2019/08/26 11:18:00 UTC

[jira] [Updated] (JCRVLT-356) Add equals and toString methods to DocViewNode and DocViewProperty

     [ https://issues.apache.org/jira/browse/JCRVLT-356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konrad Windszus updated JCRVLT-356:
-----------------------------------
    Status: Patch Available  (was: In Progress)

PR in https://github.com/apache/jackrabbit-filevault/pull/53.
[~tripod] Would you mind to review?

> Add equals and toString methods to DocViewNode and DocViewProperty
> ------------------------------------------------------------------
>
>                 Key: JCRVLT-356
>                 URL: https://issues.apache.org/jira/browse/JCRVLT-356
>             Project: Jackrabbit FileVault
>          Issue Type: Improvement
>          Components: vlt
>            Reporter: Konrad Windszus
>            Assignee: Konrad Windszus
>            Priority: Major
>             Fix For: 3.2.10
>
>
> Both classes should implement decent {{equals}} and {{toString}} methods, instead of relying on an external util method (https://github.com/apache/jackrabbit-filevault/blob/927f43c887b9f5e6c7109f87a6aa224c8c7db538/vault-core/src/test/java/org/apache/jackrabbit/vault/util/DocViewPropertyTest.java#L187). That eases downstream test cases for methods leveraging those types as return values and storing those in collections like a Map.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)