[GitHub] [hive] pgaref commented on a change in pull request #2408: HIVE-25190 Fix many small allocations in BytesColumnVector

[GitBox <gi...@apache.org>]

pgaref commented on a change in pull request #2408:
URL: https://github.com/apache/hive/pull/2408#discussion_r656253168



##########
File path: storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/BytesColumnVector.java
##########
@@ -49,13 +49,14 @@
    */
   public int[] length;
 
-  // A call to increaseBufferSpace() or ensureValPreallocated() will ensure that buffer[] points to
-  // a byte[] with sufficient space for the specified size.
-  private byte[] buffer;   // optional buffer to use when actually copying in data
+  // Calls to ensureValPreallocated() ensure that buffer starting at nextFree
+  // points to a byte[] with sufficient space for the specified size.

Review comment:
       I find the use of smallBuffer and buffer rather confusing after refactoring.
   Would it make sense to rename to something more descriprive like currBuffer and next Buffer?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org