You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sebastien Goasguen <ru...@gmail.com> on 2015/03/30 10:24:22 UTC
Re: Review Request 31302: CLOUDSTACK-8278: Usage test path - Correct
code
flow in case the usage job configuration is not to be set through test case
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31302/#review78181
-----------------------------------------------------------
Gaurav, can you move this one to GitHub and mark it as discarded.
thanks
- Sebastien Goasguen
On Feb. 23, 2015, 11:19 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31302/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2015, 11:19 a.m.)
>
>
> Review request for cloudstack and sanjeev n.
>
>
> Bugs: CLOUDSTACK-8278
> https://issues.apache.org/jira/browse/CLOUDSTACK-8278
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The flag "setUsageConfigurationThroughTestCase" dictates whether we should set the usage related config from test case itself (And restart the management server and usage server in the process) or not.
>
> When the flag is False (When we don't want to disrupt other test cases and/or usage server/job is already configured), then it should be ensured that the code is broken anywhere. Set the current date to cls.curDate variable in this case to avoid code break.
>
> Ensured above changes are in.
>
>
> Diffs
> -----
>
> test/integration/testpaths/testpath_usage.py 17d56cc
>
> Diff: https://reviews.apache.org/r/31302/diff/
>
>
> Testing
> -------
>
> yes.
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 31302: CLOUDSTACK-8278: Usage test path - Correct
code flow in case the usage job configuration is not to be set through test case
Posted by Gaurav Aradhye <ga...@clogeny.com>.
Done. No open requests now.
Regards,
Gaurav
On Mon, Mar 30, 2015 at 1:54 PM, Sebastien Goasguen <ru...@gmail.com>
wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31302/
>
> Gaurav, can you move this one to GitHub and mark it as discarded.
>
> thanks
>
>
> - Sebastien Goasguen
>
> On February 23rd, 2015, 11:19 a.m. UTC, Gaurav Aradhye wrote:
> Review request for cloudstack and sanjeev n.
> By Gaurav Aradhye.
>
> *Updated Feb. 23, 2015, 11:19 a.m.*
> *Bugs: * CLOUDSTACK-8278
> <https://issues.apache.org/jira/browse/CLOUDSTACK-8278>
> *Repository: * cloudstack-git
> Description
>
> The flag "setUsageConfigurationThroughTestCase" dictates whether we should set the usage related config from test case itself (And restart the management server and usage server in the process) or not.
>
> When the flag is False (When we don't want to disrupt other test cases and/or usage server/job is already configured), then it should be ensured that the code is broken anywhere. Set the current date to cls.curDate variable in this case to avoid code break.
>
> Ensured above changes are in.
>
> Testing
>
> yes.
>
> Diffs
>
> - test/integration/testpaths/testpath_usage.py (17d56cc)
>
> View Diff <https://reviews.apache.org/r/31302/diff/>
>