You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Jason Dere <jd...@hortonworks.com> on 2014/08/07 04:16:48 UTC

Review Request 24439: HIVE-7634: Use Configuration.getPassword() if available to eliminate passwords from hive-site.xml

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24439/
-----------------------------------------------------------

Review request for hive and Thejas Nair.


Bugs: HIVE-7634
    https://issues.apache.org/jira/browse/HIVE-7634


Repository: hive-git


Description
-------

Create shims method getPassword(), which uses Configuration.getPassword() if available, or falls back to Configuration.get().


Diffs
-----

  beeline/pom.xml 6ec1d1a 
  beeline/src/java/org/apache/hive/beeline/HiveSchemaTool.java de3ad4e 
  itests/hive-unit-hadoop2/src/test/java/org/apache/hadoop/hive/ql/security/TestPasswordWithCredentialProvider.java PRE-CREATION 
  itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestPasswordWithConfig.java PRE-CREATION 
  metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnDbUtil.java 3ab5827 
  metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java e78cd75 
  service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java b009a88 
  service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java 98d75b5 
  shims/0.20/src/main/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java 5d70e03 
  shims/0.20S/src/main/java/org/apache/hadoop/hive/shims/Hadoop20SShims.java b85a69c 
  shims/0.23/src/main/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java 40757f5 
  shims/common/src/main/java/org/apache/hadoop/hive/shims/HadoopShims.java 697d4b7 

Diff: https://reviews.apache.org/r/24439/diff/


Testing
-------


Thanks,

Jason Dere


Re: Review Request 24439: HIVE-7634: Use Configuration.getPassword() if available to eliminate passwords from hive-site.xml

Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24439/#review49938
-----------------------------------------------------------

Ship it!


Ship It!

- Thejas Nair


On Aug. 7, 2014, 2:16 a.m., Jason Dere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24439/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2014, 2:16 a.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Bugs: HIVE-7634
>     https://issues.apache.org/jira/browse/HIVE-7634
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Create shims method getPassword(), which uses Configuration.getPassword() if available, or falls back to Configuration.get().
> 
> 
> Diffs
> -----
> 
>   beeline/pom.xml 6ec1d1a 
>   beeline/src/java/org/apache/hive/beeline/HiveSchemaTool.java de3ad4e 
>   itests/hive-unit-hadoop2/src/test/java/org/apache/hadoop/hive/ql/security/TestPasswordWithCredentialProvider.java PRE-CREATION 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestPasswordWithConfig.java PRE-CREATION 
>   metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnDbUtil.java 3ab5827 
>   metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java e78cd75 
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java b009a88 
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java 98d75b5 
>   shims/0.20/src/main/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java 5d70e03 
>   shims/0.20S/src/main/java/org/apache/hadoop/hive/shims/Hadoop20SShims.java b85a69c 
>   shims/0.23/src/main/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java 40757f5 
>   shims/common/src/main/java/org/apache/hadoop/hive/shims/HadoopShims.java 697d4b7 
> 
> Diff: https://reviews.apache.org/r/24439/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jason Dere
> 
>